Re: `"prefix" is not set` error message in early GRUB startup

2010-12-29 Thread Seth Goldberg
Quoting Vladimir 'φ-coder/phcoder' Serbinenko, who wrote the following on...: My suggested fix is to move the calls to grub_machine_set_prefix() and grub_set_root_dev before grub_load_modules(). A cursory examination of these functions doesn't reveal any dependence on any loadable modules,

Re: `"prefix" is not set` error message in early GRUB startup

2010-12-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> My suggested fix is to move the calls to grub_machine_set_prefix() > and grub_set_root_dev before grub_load_modules(). A cursory > examination of these functions doesn't reveal any dependence on any > loadable modules, but I'm not 100% sure about that. The dependence is subtle: set_prefix may

Re: `"prefix" is not set` error message in early GRUB startup

2010-12-27 Thread Seth Goldberg
however there's a problem -- if gzio does exist on the tftp server and it's loaded, when we hit gzio during the grub_load_modules() iteration, a fatal error occurs (we should be able to detect this and just ignore the fact that the module as already been loaded). Sorry -- this is wrong. I

Re: `"prefix" is not set` error message in early GRUB startup

2010-12-27 Thread Seth Goldberg
Hi, Following up on this, I tried moving the calls to grub_machine_set_prefix() and grub_set_root_dev() before the call to grub_load_modules(), and while it does result in the prefix and root variables getting set earlier, it's still possible to have error messages emitted, depending on the

`"prefix" is not set` error message in early GRUB startup

2010-12-25 Thread Seth Goldberg
Hi, Recently, I've been seeing the error message in the subject line while GRUB2 is starting. I've tracked it down to code in normal.mod (specifically, the code in GRUB_MOD_INIT(normal) that tries to grub_dl_load the gzio module. Since normal.mod is loaded by the call to grub_load_modules()