Re: Bug in multiboot_mbi2.c

2010-06-23 Thread Colin Watson
On Mon, Jun 21, 2010 at 07:22:00PM -0700, Seth Goldberg wrote: > The code that constructs the framebuffer info has a nasty bug where the > field position and mask size for red are set to the GREEN values: > > tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; > tag->commo

Re: Bug in multiboot_mbi2.c

2010-06-22 Thread Seth Goldberg
Quoting richardvo...@gmail.com, who wrote the following on Tue, 22 Jun 2010: What, you want to control color channels independently? Aren't monochromatic amber displays good enough any more? As much as I enjoyed that amber goodness, I would like to be able to see red :). --S

Re: Bug in multiboot_mbi2.c

2010-06-22 Thread richardvo...@gmail.com
What, you want to control color channels independently? Aren't monochromatic amber displays good enough any more? :) On Mon, Jun 21, 2010 at 9:22 PM, Seth Goldberg wrote: > >  The code that constructs the framebuffer info has a nasty bug where the > field position and mask size for red are set

Re: Bug in multiboot_mbi2.c

2010-06-21 Thread Seth Goldberg
BTW, while we're at it, we can remove the redundant tag->common.framebuffer_type assignment :). --S Quoting Seth Goldberg, who wrote the following on Mon, 21 Jun 2010: The code that constructs the framebuffer info has a nasty bug where the field position and mask size for red are set t

Bug in multiboot_mbi2.c

2010-06-21 Thread Seth Goldberg
The code that constructs the framebuffer info has a nasty bug where the field position and mask size for red are set to the GREEN values: tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; tag->common.framebuffer_type = MULTIBOOT_FRAMEBUFFER_TYPE_RGB; --> tag->frame