Re: [PATCHv2] FIXME: These should be dynamically obtained from a terminal.

2005-08-08 Thread Hollis Blanchard
On Aug 4, 2005, at 1:13 PM, Marco Gerards wrote: Marco Gerards <[EMAIL PROTECTED]> writes: Vincent Pelletier <[EMAIL PROTECTED]> writes: Hi Vincent, Finally I had the time and energy to both proofread and test your patch. It did work for me after making some changes. I have committed your

Re: [PATCHv2] FIXME: These should be dynamically obtained from a terminal.

2005-08-04 Thread Marco Gerards
Marco Gerards <[EMAIL PROTECTED]> writes: > Vincent Pelletier <[EMAIL PROTECTED]> writes: > > Hi Vincent, > > Finally I had the time and energy to both proofread and test your > patch. It did work for me after making some changes. Hi Vincent, I have committed your patch with some changes and so

Re: [PATCHv2] FIXME: These should be dynamically obtained from a terminal.

2005-08-04 Thread Marco Gerards
include/grub/term.h 19 Feb 2005 20:56:07 - 1.7 > +++ include/grub/term.h 13 Jul 2005 21:19:36 -0000 > @@ -71,9 +71,9 @@ grub_term_color_state; > > /* Menu-related geometrical constants. */ > > -/* FIXME: These should be dynamically obtained from a terminal. */ &g

Re: [PATCHv2] FIXME: These should be dynamically obtained from a terminal.

2005-07-13 Thread Vincent Pelletier
RCS file: /cvsroot/grub/grub2/include/grub/term.h,v retrieving revision 1.7 diff -u -p -r1.7 term.h --- include/grub/term.h 19 Feb 2005 20:56:07 - 1.7 +++ include/grub/term.h 13 Jul 2005 21:19:36 - @@ -71,9 +71,9 @@ grub_term_color_state; /* Menu-related geometrical con

Re: [PATCHv2] FIXME: These should be dynamically obtained from a terminal.

2005-07-13 Thread Marco Gerards
Vincent Pelletier <[EMAIL PROTECTED]> writes: > Vincent Pelletier wrote: >> Warning : terms other than console.c & vga.c will be broken by this >> patch, as long as they don't have the function. > > It's fixed in this patch for sparc64 port (see sparc_getwh.diff, which > is a diff between term/pow

[PATCHv2] FIXME: These should be dynamically obtained from a terminal.

2005-07-13 Thread Vincent Pelletier
=== RCS file: /cvsroot/grub/grub2/include/grub/term.h,v retrieving revision 1.7 diff -u -p -r1.7 term.h --- include/grub/term.h 19 Feb 2005 20:56:07 -0000 1.7 +++ include/grub/term.h 12 Jul 2005 19:55:33 - @@ -71,9 +71,9 @@ grub_te

[PATCH] FIXME: These should be dynamically obtained from a terminal.

2005-07-12 Thread Vincent Pelletier
++ include/grub/term.h 12 Jul 2005 19:55:33 - @@ -71,9 +71,9 @@ grub_term_color_state; /* Menu-related geometrical constants. */ -/* FIXME: These should be dynamically obtained from a terminal. */ -#define GRUB_TERM_WIDTH80 -#define GRUB_TERM_HEIGHT 25 +/* FIXME:

Re: FIXME: These should be dynamically obtained from a terminal.

2005-07-05 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Tuesday 05 July 2005 12:15, Marco Gerards wrote: >> The menu should support all kinds of screen sizes anyway. For example on >> the PPC the text screen is really big. > > I think there are 2 different issues in a high resolution: > > - How to

Re: FIXME: These should be dynamically obtained from a terminal.

2005-07-05 Thread Yoshinori K. Okuji
On Tuesday 05 July 2005 12:15, Marco Gerards wrote: > The menu should support all kinds of screen sizes anyway. For example on > the PPC the text screen is really big. I think there are 2 different issues in a high resolution: - How to adapt the menu without making it too ugly - How to use bigg

Re: FIXME: These should be dynamically obtained from a terminal.

2005-07-05 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > No. Since the BIOS does not provide the geometry for each VGA mode, we must > maintain a table in that case. And, the table differs among video cards. So I > do not want to allow the user to change it to an arbitrary mode. > > What we really nee

Re: FIXME: These should be dynamically obtained from a terminal.

2005-07-04 Thread Vincent Pelletier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Yoshinori K. Okuji wrote: > We need to call grub_getwh only once. Possibly in grub_menu_init_page. So we have to redesign the way sizes are computed to use something else than macros. > BTW, is the VGA terminal working well? Since Marco changed the m

Re: FIXME: These should be dynamically obtained from a terminal.

2005-07-04 Thread Yoshinori K. Okuji
On Sunday 03 July 2005 23:06, Vincent Pelletier wrote: > -add an asm function to get the current vga mode without changing it (or > maybe a global var to keep the current vga mode) Probably it is better to keep the current mode in a variable. It is not funny to go back to real mode every time. >

Re: [Bulk] FIXME: These should be dynamically obtained from a terminal.

2005-07-03 Thread Vincent Pelletier
rub/term.h 3 Jul 2005 20:34:40 - @@ -72,8 +72,10 @@ grub_term_color_state; /* Menu-related geometrical constants. */ /* FIXME: These should be dynamically obtained from a terminal. */ -#define GRUB_TERM_WIDTH80 -#define GRUB_TERM_HEIGHT 25 +/*#define GRUB_TERM_WI

FIXME: These should be dynamically obtained from a terminal.

2005-07-03 Thread Vincent Pelletier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm trying to fix that thing. I'm only working on the i386 part, because I have no ppc. Here is how I plan to do it (almost done, but I have some questions) : - -add an asm function to get the current vga mode without changing it (or maybe a global v