On Thu, Feb 23, 2012 at 12:43:08PM -0500, Lennart Sorensen wrote:
gcc-4.6 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1
-DGRUB_LIBDIR=\/usr/lib/grub\ -DLOCALEDIR=\/usr/share/locale\
-DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1
On Thu, Feb 23, 2012 at 07:17:49AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
../../../grub-core/normal/charset.c: In function
'grub_bidi_line_logical_to_visual':
../../../grub-core/normal/charset.c:737: error: cannot optimize
possibly infinite
loops If I do what is already done
On Tue, Feb 21, 2012 at 09:29:08PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
diff --exclude Makefile.util.am --exclude Makefile.in --exclude grub.info
--exclude configure --exclude aclocal.m4 --exclude '*autom4te.cache*' -ur
mainline/configure.ac mainline-mod/configure.ac
---
On Wed, Feb 22, 2012 at 10:34:18AM -0500, Lennart Sorensen wrote:
OK, still seeing things like:
gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1
-DGRUB_LIBDIR=\/usr/lib/grub\ -DLOCALEDIR=\/usr/share/locale\
-DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU
So with this patch, gcc 4.4 is down to 201 warnings, and gcc 4.6 has 175.
102 of those warnings are about missing prototypes for argp_usage
_option_is_short and _option_is_end in argp.h which leaves 99 warnings
for gcc 4.4 and 73 for gcc 4.6.
Hm we don't add -Wmissing-prototypes for
On Wed, Feb 22, 2012 at 04:57:11PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
So with this patch, gcc 4.4 is down to 201 warnings, and gcc 4.6 has 175.
102 of those warnings are about missing prototypes for argp_usage
_option_is_short and _option_is_end in argp.h which leaves 99
On Wed, Feb 22, 2012 at 11:18:54AM -0500, Lennart Sorensen wrote:
Well it is in WARN_FLAGS and TARGET_CFLAGS in configure.
And during build:
gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1
-DGRUB_LIBDIR=\/usr/lib/grub\ -DLOCALEDIR=\/usr/share/locale\
On Wed, Feb 22, 2012 at 11:25:22AM -0500, Lennart Sorensen wrote:
That actually looks like a mistake.
HOST_CFLAGS=$HOST_CFLAGS $WARN_FLAGS
TARGET_CFLAGS=$TARGET_CFLAGS $WARN_FLAGS -g -Wredundant-decls
-Wmissing-prototypes
but WARN_FLAGS=-Wall -W -Wshadow -Wold-style-declaration
On 22.02.2012 17:25, Lennart Sorensen wrote:
On Wed, Feb 22, 2012 at 11:18:54AM -0500, Lennart Sorensen wrote:
Well it is in WARN_FLAGS and TARGET_CFLAGS in configure.
And during build:
gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1 -DGRUB_LIBDIR=\/usr/lib/grub\
On Wed, Feb 22, 2012 at 11:18:54AM -0500, Lennart Sorensen wrote:
On Wed, Feb 22, 2012 at 04:57:11PM +0100, Vladimir 'φ-coder/phcoder'
Serbinenko wrote:
So with this patch, gcc 4.4 is down to 201 warnings, and gcc 4.6 has 175.
102 of those warnings are about missing prototypes for
On Wed, Feb 22, 2012 at 05:50:31PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
=== modified file 'conf/Makefile.common'
--- conf/Makefile.common 2012-02-22 15:27:39 +
+++ conf/Makefile.common 2012-02-22 16:29:31 +
@@ -104,7 +104,7 @@
CFLAGS_GCRY = -Wno-error
I don't think -Wno-unsafe-loop-optimisations is valid. One has to
remove -Wunsafe-loop-optimisations instead, which is currently in
WARN_FLAGS.
It's just a question of spelling.
Also note that warnings from gnulib and minilzo are -Wno-error
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
On Wed, Feb 22, 2012 at 12:16:12PM -0500, Lennart Sorensen wrote:
OK I checked out the latest bzr tree, and applied this patch.
I now get:
../../grub-core/gnulib/argp.h:610:1: warning: no previous declaration for
'argp_usage' [-Wmissing-declarations]
../../grub-core/gnulib/argp.h:616:1:
On Wed, Feb 22, 2012 at 06:35:49PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
I don't think -Wno-unsafe-loop-optimisations is valid. One has to
remove -Wunsafe-loop-optimisations instead, which is currently in
WARN_FLAGS.
It's just a question of spelling.
Also note that warnings
On Wed, Feb 22, 2012 at 12:46:14PM -0500, Lennart Sorensen wrote:
Hmm.
gcc-4.4 -DHAVE_CONFIG_H -I. -I../.. -Wall -W -I./include -DGRUB_UTIL=1
-DGRUB_LIBDIR=\/usr/lib/grub\ -DLOCALEDIR=\/usr/share/locale\
-DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1
On Wed, Feb 22, 2012 at 12:41:56PM -0500, Lennart Sorensen wrote:
On Wed, Feb 22, 2012 at 06:35:49PM +0100, Vladimir 'φ-coder/phcoder'
Serbinenko wrote:
I don't think -Wno-unsafe-loop-optimisations is valid. One has to
remove -Wunsafe-loop-optimisations instead, which is currently in
On Wed, Feb 22, 2012 at 01:01:41PM -0500, Lennart Sorensen wrote:
gcc 4.6 on the other hand now seems to compile with -Werror enabled.
Oh the feature for doing multiple #pragma statements throughout the code
is new in gcc 4.6. It can't be done in earlier versions. In older
versions whatever
On Wed, Feb 22, 2012 at 01:28:06PM -0500, Lennart Sorensen wrote:
Oh the feature for doing multiple #pragma statements throughout the code
is new in gcc 4.6. It can't be done in earlier versions. In older
versions whatever you say last applies to the whole file.
Perhaps a slightly ugly
On 22.02.2012 19:41, Lennart Sorensen wrote:
On Wed, Feb 22, 2012 at 01:28:06PM -0500, Lennart Sorensen wrote:
Oh the feature for doing multiple #pragma statements throughout the code
is new in gcc 4.6. It can't be done in earlier versions. In older
versions whatever you say last applies to
On Wed, Feb 22, 2012 at 08:00:54PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
Alternative is to add a condition which will ensure the loop
termination but don't interfere with it other wise by using the fact
that min (UINT_MAX, r)=r if r is unsigned int.
--
Regards
Vladimir
On Wed, Feb 22, 2012 at 05:50:37PM -0500, Lennart Sorensen wrote:
Now I get:
gcc-4.6 -DHAVE_CONFIG_H -I. -I../../../grub-core -I.. -Wall -W
-I../../../include -I../include -DGRUB_MACHINE_EMU=1
-DGRUB_MACHINE=POWERPC_EMU -DGRUB_TARGET_CPU_POWERPC=1 -m32
-DGRUB_FILE=\normal/charset.c\
On 02/22/2012 06:03 PM, Lennart Sorensen wrote:
On Wed, Feb 22, 2012 at 05:50:37PM -0500, Lennart Sorensen wrote:
Now I get:
gcc-4.6 -DHAVE_CONFIG_H -I. -I../../../grub-core -I.. -Wall -W -I../../../include
-I../include -DGRUB_MACHINE_EMU=1 -DGRUB_MACHINE=POWERPC_EMU
../../../grub-core/normal/charset.c: In function
'grub_bidi_line_logical_to_visual':
../../../grub-core/normal/charset.c:737: error: cannot optimize possibly
infinite
loops If I do what is already done for GRUB_LONG_MIN and use: #define
GRUB_INT_MIN (-0x7fff - 1) ...then gcc 4.6 is happy.
On 21.02.2012 17:19, Lennart Sorensen wrote:
On Tue, Feb 21, 2012 at 05:12:12PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
Hello, it's to announce that from 27th of February the GRUB will be
frozen for 2.00 release. From that date on, no new features will be
committed only bugfixes.
On Tue, Feb 21, 2012 at 06:09:36PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
Try attached patch
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
=== modified file 'grub-core/kern/list.c'
--- grub-core/kern/list.c 2012-02-12 02:52:17 +
+++ grub-core/kern/list.c
On Tue, Feb 21, 2012 at 01:46:27PM -0500, Lennart Sorensen wrote:
That actually seems to have done it. I am still trying to wrap my head
around why that made a difference since it appears to be identical code
moved somewhere else. It isn't inlined anymore, but should that make
a big
On 21.02.2012 20:58, Lennart Sorensen wrote:
On Tue, Feb 21, 2012 at 01:46:27PM -0500, Lennart Sorensen wrote:
That actually seems to have done it. I am still trying to wrap my head
around why that made a difference since it appears to be identical code
moved somewhere else. It isn't inlined
27 matches
Mail list logo
