Re: New patch for video subsystem...

2006-05-05 Thread Johan Rydberg
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > But the idea here was to make it easier to make function that operates > on different render targets without knowing about it. eg: > > set_target a > call common_func > set target b > call common_func > set target c > > With your proposal this would

Re: New patch for video subsystem...

2006-05-05 Thread Vesa Jääskeläinen
Johan Rydberg wrote: > Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > >> Here is the newest modifications to video subsystem. > > Hi Vesa. What a suitable name :) :) > Sorry for the delay, and lack of earlier comments, but I've been out > of the GRUB loop for a while. But I have a few commen

Re: New patch for video subsystem...

2006-05-04 Thread Johan Rydberg
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Here is the newest modifications to video subsystem. Hi Vesa. What a suitable name :) Sorry for the delay, and lack of earlier comments, but I've been out of the GRUB loop for a while. But I have a few comments on the video subsystem; Correct me

Re: New patch for video subsystem...

2006-03-12 Thread Vesa Jääskeläinen
Marco Gerards wrote: > Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > > Hi Vesa, > > Thanks a lot for the amount of work you did again! Sorry I am this > late with reviewing the patch. I assume if someone else wanted to > comment on your code, he would've done so by now. Can you please > corr

Re: New patch for video subsystem...

2006-03-12 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: >> >> Hi Vesa, >> >> Thanks for your patch. I have done a review, but you should know that >> I am not a graphics expert and don't understand all of the code in >> detail. Most

Re: New patch for video subsystem...

2006-03-12 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: Hi Vesa, Thanks a lot for the amount of work you did again! Sorry I am this late with reviewing the patch. I assume if someone else wanted to comment on your code, he would've done so by now. Can you please correct the patch using my comments (and

Re: New patch for video subsystem...

2006-03-10 Thread Vesa Jääskeläinen
Vesa Jääskeläinen wrote: > Is there a nice way to split vbe driver to > more source files without causing generation of more modules. I was > thinking that "optimized" versions of some blitting operations would be > good to place on some other file as source might grow to quite large. I should ha

Re: New patch for video subsystem...

2006-03-10 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: Hi Vesa, Thanks for your patch. I have done a review, but you should know that I am not a graphics expert and don't understand all of the code in detail. Most issues are GCS related, they don't only apply to the line I commented on, but in general.

Re: New patch for video subsystem...

2006-03-09 Thread Vesa Jääskeläinen
Vesa Jääskeläinen wrote: > Yoshinori K. Okuji wrote: >> On Friday 03 March 2006 15:23, Vesa Jääskeläinen wrote: >>> Nowadays 1024x768 is a normal standard resolution. >> Even if it is very popular, since the boot loader is a critical part of an >> operation system, the default should be set to som

Re: New patch for video subsystem...

2006-03-07 Thread Vesa Jääskeläinen
Yoshinori K. Okuji wrote: > On Friday 03 March 2006 15:23, Vesa Jääskeläinen wrote: >> Nowadays 1024x768 is a normal standard resolution. > > Even if it is very popular, since the boot loader is a critical part of an > operation system, the default should be set to something really safe. So I >

Re: New patch for video subsystem...

2006-03-06 Thread Yoshinori K. Okuji
On Friday 03 March 2006 15:23, Vesa Jääskeläinen wrote: > Nowadays 1024x768 is a normal standard resolution. Even if it is very popular, since the boot loader is a critical part of an operation system, the default should be set to something really safe. So I prefer 640x480. It is up to the user