Re: On gratuitous modularization

2010-02-07 Thread Christian Franke
Vladimir 'φ-coder/phcoder' Serbinenko wrote: Christian Franke wrote: Hi Robert, Robert Millan wrote: Please be careful when adding modules. I see that too often new modules are added without any real need to host this code separately. ... kern/disk.c:struct

Re: On gratuitous modularization

2010-01-26 Thread Robert Millan
On Mon, Jan 25, 2010 at 09:13:11PM +0100, Christian Franke wrote: The module ata_pthru.mod exists only to keep ata.mod small, see: http://lists.gnu.org/archive/html/grub-devel/2009-02/msg00091.html I see. Thanks for pointing this out. Keeping the ata.mod specific pass-through function

On gratuitous modularization

2010-01-25 Thread Robert Millan
Please be careful when adding modules. I see that too often new modules are added without any real need to host this code separately. There are many examples where this happened. I just noticed: commands/hdparm.c: struct grub_disk_ata_pass_through_parms apt; commands/hdparm.c: if

Re: On gratuitous modularization

2010-01-25 Thread Christian Franke
Hi Robert, Robert Millan wrote: Please be careful when adding modules. I see that too often new modules are added without any real need to host this code separately. There are many examples where this happened. I just noticed: commands/hdparm.c: struct grub_disk_ata_pass_through_parms