Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2023-01-12 Thread Thomas Schmitt
Hi, Lidong Chen wrote: > To test it, I am thinking to add the ISO entry in 40_custom script, then > select > the ISO from Grub menu. Is it the right way to test it? Or, is there a better > way > to it? I have to leave the answer to the experienced GRUB developers. Testing is my weak spot with

Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2023-01-11 Thread Lidong Chen
Hi Thomas, > On Jan 11, 2023, at 3:54 AM, Thomas Schmitt wrote: > > Hi, > > i created another bad ISO which i expect to lead to an endless loop in > existing GRUB (i.e. before applying the proposed change). > > Both ISOs can be downloaded as gzip-compressed files now: > >

Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2023-01-11 Thread Thomas Schmitt
Hi, i created another bad ISO which i expect to lead to an endless loop in existing GRUB (i.e. before applying the proposed change). Both ISOs can be downloaded as gzip-compressed files now: http://scdbackup.webframe.org/ce_loop.iso.gz SHA256:

Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2023-01-09 Thread Thomas Schmitt
Hi, Lidong Chen wrote: > Thanks for the clarification. I created a new patch for the fix and added > you as the “Signed-off-by”. > My question is how to test it. I just sent libisofs into an endless recursion loop. Grrr. For this i created a small ISO with a file which surely needs a CE, changed

Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2023-01-08 Thread Lidong Chen
Hi Thomas, > On Jan 6, 2023, at 8:00 AM, Thomas Schmitt wrote: > > Hi, > > i wrote on Fri, 16 Dec 2022 10:42:13 +0100: >>> If processing of a SUSP CE entry leads to a continuation area which begins >>> by entry CE or ST, then these entries were skipped without interpretation. >>> In case of CE

Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2023-01-06 Thread Thomas Schmitt
Hi, i wrote on Fri, 16 Dec 2022 10:42:13 +0100: > > If processing of a SUSP CE entry leads to a continuation area which begins > > by entry CE or ST, then these entries were skipped without interpretation. > > In case of CE this would lead to premature end of processing the SUSP > > entries of

Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2023-01-05 Thread Lidong Chen
On Dec 16, 2022, at 4:57 AM, Thomas Schmitt mailto:scdbac...@gmx.net>> wrote: Hi, i realize that my previous proposal opens a possibility for regression with a very bad ISO image. The danger is in an endless loop by a CE entry which points to itself. The bug which i want to see fixed

Re: Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2022-12-20 Thread Lidong Chen
> On Dec 16, 2022, at 4:57 AM, Thomas Schmitt wrote: > > Hi, > > i realize that my previous proposal opens a possibility for regression with > a very bad ISO image. > The danger is in an endless loop by a CE entry which points to itself. > The bug which i want to see fixed currently prevents

Proposal v2: fs/iso9660: Prevent skipping CE or ST at start of continuation area

2022-12-16 Thread Thomas Schmitt
Hi, i realize that my previous proposal opens a possibility for regression with a very bad ISO image. The danger is in an endless loop by a CE entry which points to itself. The bug which i want to see fixed currently prevents this special pitfall. (Other endless loops by CE are possible and not