Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-16 Thread Daniel Kiper
On Fri, Jun 16, 2023 at 02:24:51PM +0200, Christian Hesse wrote: > Robin Candau on Fri, 2023/06/16 12:48: > > Le 16/06/2023 à 12:35, Daniel Kiper a écrit : > > > On Fri, Jun 16, 2023 at 09:15:19AM +0200, Robin Candau wrote: > > >> Le 15/06/2023 à 23:36, Christian Hesse a écrit : > > >>> Daniel

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-16 Thread Christian Hesse
Robin Candau on Fri, 2023/06/16 12:48: > Le 16/06/2023 à 12:35, Daniel Kiper a écrit : > > On Fri, Jun 16, 2023 at 09:15:19AM +0200, Robin Candau wrote: > >> Le 15/06/2023 à 23:36, Christian Hesse a écrit : > >>> Daniel Kiper on Thu, 2023/06/15 17:05: > > It looks I was able to

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-16 Thread Robin Candau
Le 16/06/2023 à 12:35, Daniel Kiper a écrit : On Fri, Jun 16, 2023 at 09:15:19AM +0200, Robin Candau wrote: Le 15/06/2023 à 23:36, Christian Hesse a écrit : Daniel Kiper on Thu, 2023/06/15 17:05: It looks I was able to reproduce this problem. I will be checking what is going on in following

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-16 Thread Daniel Kiper
On Fri, Jun 16, 2023 at 09:15:19AM +0200, Robin Candau wrote: > Le 15/06/2023 à 23:36, Christian Hesse a écrit : > > Daniel Kiper on Thu, 2023/06/15 17:05: > > > > It looks I was able to reproduce this problem. I will be checking what > > > > is going on in following days... > > > Here [1] is the

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-16 Thread Robin Candau
Le 15/06/2023 à 23:36, Christian Hesse a écrit : Daniel Kiper on Thu, 2023/06/15 17:05: It looks I was able to reproduce this problem. I will be checking what is going on in following days... Here [1] is the fix. Please test... Works for me, thanks! Works for me as well, thanks! --

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-15 Thread Christian Hesse
Daniel Kiper on Thu, 2023/06/15 17:05: > > It looks I was able to reproduce this problem. I will be checking what > > is going on in following days... > > Here [1] is the fix. Please test... Works for me, thanks! -- main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH"

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-15 Thread Daniel Kiper
On Wed, Jun 14, 2023 at 05:15:43PM +0200, Daniel Kiper wrote: > On Mon, Jun 12, 2023 at 10:53:09PM +0200, Robin Candau wrote: > > Le 12/06/2023 à 21:05, Daniel Kiper a écrit : > > > On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote: > > > > Ard Biesheuvel on Tue, 2023/05/23 17:31: >

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-15 Thread Thomas Frauendorfer
On Wed, Jun 14, 2023 at 5:17 PM Daniel Kiper wrote: > > On Mon, Jun 12, 2023 at 10:53:09PM +0200, Robin Candau wrote: > > Le 12/06/2023 à 21:05, Daniel Kiper a écrit : > > > On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote: > > > > Ard Biesheuvel on Tue, 2023/05/23 17:31: > > > >

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-14 Thread Daniel Kiper
On Mon, Jun 12, 2023 at 10:53:09PM +0200, Robin Candau wrote: > Le 12/06/2023 à 21:05, Daniel Kiper a écrit : > > On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote: > > > Ard Biesheuvel on Tue, 2023/05/23 17:31: > > > > Now that GCC can generate function calls using the correct

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-12 Thread Robin Candau
Le 12/06/2023 à 21:05, Daniel Kiper a écrit : On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote: Ard Biesheuvel on Tue, 2023/05/23 17:31: Now that GCC can generate function calls using the correct calling convention for us, we can stop using the efi_call_XX () wrappers, and just

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-12 Thread Daniel Kiper
On Mon, Jun 12, 2023 at 07:19:53PM +0200, Christian Hesse wrote: > Ard Biesheuvel on Tue, 2023/05/23 17:31: > > Now that GCC can generate function calls using the correct calling > > convention for us, we can stop using the efi_call_XX () wrappers, and > > just dereference the function pointers

Re: [PATCH v4 3/5] efi: Drop all uses of efi_call_XX wrappers

2023-06-12 Thread Christian Hesse
Ard Biesheuvel on Tue, 2023/05/23 17:31: > Now that GCC can generate function calls using the correct calling > convention for us, we can stop using the efi_call_XX () wrappers, and > just dereference the function pointers directly. > > This avoids the untyped variadic wrapper routines, which