Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 15.01.2014 19:14, Andrey Borzenkov wrote: + * Copyright (C) 2014 Free Software Foundation, Inc. please preserve copyright years when copying code around (just copying whole string and adding 2104 is fine) Otherwise, go ahead. signature.asc Description: OpenPGP digital signature

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-18 Thread SevenBits
On Jan 18, 2014, at 12:12 PM, Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com wrote: On 15.01.2014 19:14, Andrey Borzenkov wrote: + * Copyright (C) 2014 Free Software Foundation, Inc. please preserve copyright years when copying code around (just copying whole string and adding

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-15 Thread Andrey Borzenkov
В Mon, 13 Jan 2014 23:00:47 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 13.01.2014 20:44, Andrey Borzenkov wrote: I'd rather move compiler features into separate file (like grub/compiler.h) and include it from misc.h and separately from list.h. This would

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-14 Thread Colin Watson
On Tue, Jan 14, 2014 at 06:49:12AM +0400, Andrey Borzenkov wrote: Unless there is some redefinition, it seems to be used almost only in core? Is it wrong? Those matches are in grub-core, but are not in a typical core.img. Vladimir meant the latter. -- Colin Watson

conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-13 Thread Andrey Borzenkov
In file included from ./include/grub/dl.h:23:0, from grub-core/lib/libgcrypt-grub/cipher/rfc2268.c:3: ./include/grub/list.h:34:18: warning: conflicting types for 'grub_list_push' [en abled by default] void EXPORT_FUNC(grub_list_push) (grub_list_t *head, grub_list_t item);

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-13 Thread Colin Watson
On Mon, Jan 13, 2014 at 10:17:05PM +0400, Andrey Borzenkov wrote: I'm not sure what to do here. list.h needs misc.h apparently only for definition of ATTRIBUTE_ERROR which in turn does not appear to be used anywhere else. This is not fatal so may be can be ignored for now, but still would be

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-13 Thread Andrey Borzenkov
В Mon, 13 Jan 2014 18:33:41 + Colin Watson cjwat...@ubuntu.com пишет: On Mon, Jan 13, 2014 at 10:17:05PM +0400, Andrey Borzenkov wrote: I'm not sure what to do here. list.h needs misc.h apparently only for definition of ATTRIBUTE_ERROR which in turn does not appear to be used anywhere

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-13 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.01.2014 20:44, Andrey Borzenkov wrote: В Mon, 13 Jan 2014 18:33:41 + Colin Watson cjwat...@ubuntu.com пишет: On Mon, Jan 13, 2014 at 10:17:05PM +0400, Andrey Borzenkov wrote: I'm not sure what to do here. list.h needs misc.h apparently only for definition of ATTRIBUTE_ERROR which

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-13 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.01.2014 19:33, Colin Watson wrote: On Mon, Jan 13, 2014 at 10:17:05PM +0400, Andrey Borzenkov wrote: I'm not sure what to do here. list.h needs misc.h apparently only for definition of ATTRIBUTE_ERROR which in turn does not appear to be used anywhere else. This is not fatal so may be

Re: conflicting types for 'grub_list_push' on MinGW (include loop)

2014-01-13 Thread Andrey Borzenkov
В Mon, 13 Jan 2014 23:00:22 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 13.01.2014 19:33, Colin Watson wrote: On Mon, Jan 13, 2014 at 10:17:05PM +0400, Andrey Borzenkov wrote: I'm not sure what to do here. list.h needs misc.h apparently only for definition of