Re: play.c

2005-11-29 Thread Hollis Blanchard
On Nov 29, 2005, at 4:05 PM, Vincent Pelletier wrote: + status = inb (SPEAKER); + outb (SPEAKER, status & ~(SPEAKER_TMR2 | SPEAKER_DATA)); You changed the style here... + status = inb (SPEAKER) | SPEAKER_TMR2 | SPEAKER_DATA; + outb (SPEAKER, status); ... but not here. + grub_dprintf

Re: play.c

2005-11-29 Thread Vincent Pelletier
t9XlC2XS4zLj08Tf6A2HHzyIPwMFAUOM0KcURCgpFDKO1REC0rwAnifHHB66WIvU wL5TGVG7yAyONtADAKC02lDTu8C178IVqV2ejfWdsAi4WQ== =4UJg -END PGP SIGNATURE- Index: commands/i386/pc/play.c === RCS file: commands/i386/pc/play.c diff -N commands/i386/pc/play.c --- /dev/null 1 Jan

Re: play.c

2005-11-06 Thread Dennis Clarke
On 11/6/05, Marco Gerards <[EMAIL PROTECTED]> wrote: > Hollis Blanchard <[EMAIL PROTECTED]> writes: > > On Nov 5, 2005, at 2:48 PM, Dennis Clarke wrote: > >> On 11/5/05, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: > >>> On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote: > Here i

Re: play.c

2005-11-06 Thread Marco Gerards
Hollis Blanchard <[EMAIL PROTECTED]> writes: > On Nov 5, 2005, at 2:48 PM, Dennis Clarke wrote: > >> On 11/5/05, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: >>> On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote: Here is the play command, along with some songs. >>> >>> I point o

Re: play.c

2005-11-06 Thread Marco Gerards
Dennis Clarke <[EMAIL PROTECTED]> writes: > On 11/5/05, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: >> On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote: >> > Here is the play command, along with some songs. >> >> I point out some stylish mistakes. > > Personally I was thrilled with

Re: play.c

2005-11-06 Thread Marco Gerards
Vincent Pelletier <[EMAIL PROTECTED]> writes: Hi Vincent, > Here is the play command, along with some songs. Cool, thanks for this neat patch. :-) > Vincent Pelletier > Index: commands/i386/pc/play.c > === &g

Re: play.c

2005-11-05 Thread Vincent Pelletier
On Sat, 5 Nov 2005 23:23:25 +0100 Samuel Thibault <[EMAIL PROTECTED]> wrote: > Hollis Blanchard, le Sat 05 Nov 2005 16:17:33 -0600, a écrit : BTW, thank for your comments, I'll send another version tomorrow. > > Can you describe how the PIT is related to the speaker? > That's the way one can make

Re: play.c

2005-11-05 Thread Samuel Thibault
Hollis Blanchard, le Sat 05 Nov 2005 16:17:33 -0600, a écrit : > On Nov 5, 2005, at 8:17 AM, Vincent Pelletier wrote: > >Here is the play command, along with some songs. > > Can you describe how the PIT is related to the speaker? That's the way one can make the speaker beep without having to keep

Re: play.c

2005-11-05 Thread Hollis Blanchard
00:00 - +++ commands/i386/pc/play.c 5 Nov 2005 14:06:00 - @@ -0,0 +1,248 @@ ... +/* Lots of this file is borowed from GNU/Hurd generic-speaker driver */ "borrowed" +/* Read a byte from a port. */ +static inline unsigned char +inb (unsigned short port) +{ + unsigned char

Re: play.c

2005-11-05 Thread Hollis Blanchard
On Nov 5, 2005, at 3:25 PM, Dennis Clarke wrote: I was sitting on some changes and was thinking about how to submit them and then thought, oh great, I have no idea what style is needed or wanted. So then after seeing this, an inside joke or something like that, I then felt "why bother". Forma

Re: play.c

2005-11-05 Thread Dennis Clarke
On 11/5/05, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: > On Saturday 05 November 2005 10:12 pm, Hollis Blanchard wrote: > > On Nov 5, 2005, at 2:48 PM, Dennis Clarke wrote: > > > On 11/5/05, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: > > >> On Saturday 05 November 2005 03:17 pm, Vincent Pelle

Re: play.c

2005-11-05 Thread Yoshinori K. Okuji
On Saturday 05 November 2005 10:12 pm, Hollis Blanchard wrote: > On Nov 5, 2005, at 2:48 PM, Dennis Clarke wrote: > > On 11/5/05, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: > >> On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote: > >>> Here is the play command, along with some songs.

Re: play.c

2005-11-05 Thread Hollis Blanchard
On Nov 5, 2005, at 2:48 PM, Dennis Clarke wrote: On 11/5/05, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote: Here is the play command, along with some songs. I point out some stylish mistakes. Personally I was thrilled with the

Re: play.c

2005-11-05 Thread Dennis Clarke
On 11/5/05, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: > On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote: > > Here is the play command, along with some songs. > > I point out some stylish mistakes. Personally I was thrilled with the idea of sound and really, these little "style"

Re: play.c

2005-11-05 Thread Vincent Pelletier
rectly... > The lines are folded incorrectly. I also corrected the lines length where needed. Vincent Pelletier Index: commands/i386/pc/play.c === RCS file: commands/i386/pc/play.c diff -N commands/i386/pc/play.c --- /dev/null

Re: play.c

2005-11-05 Thread Yoshinori K. Okuji
On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote: > Here is the play command, along with some songs. I point out some stylish mistakes. > +struct note { > +  short pitch; > +  short duration; > +}; You must put the starting brace character on next line: struct note { short pitch

play.c

2005-11-05 Thread Vincent Pelletier
Hi. Here is the play command, along with some songs. 2005-11-05 Vincent Pelletier <[EMAIL PROTECTED]> * commands/i386/pc/play.c: New file. * conf/i386-pc.rmk (pkgdata_MODULES): Added play.mod. (play_mod_SOURCES, play_mod_CFLAGS, play_mod_LDFLAGS): New