Re: a new combo box

2014-12-27 Thread Tristan Van Berkom
On Sat, 2014-12-27 at 16:29 -0500, Matthias Clasen wrote: > On Sat, Dec 27, 2014 at 12:59 PM, Tristan Van Berkom > wrote: > > > > > It's really not that bad, combobox is currently < 6k lines of code which > > is really not much for all that it does, sure we could afford to do a > > bit less (like

Re: a new combo box

2014-12-27 Thread Alberto Ruiz
My main concern with the design is that users can't make a difference between a normal button and this widget (usually related to an action, perhaps with the exception of iconized menus like the ones we're using in headerbars these days). Is there any design rationale to remove the usual arrow? 2

Re: a new combo box

2014-12-27 Thread Cosimo Cecchi
Thanks, Matthias for working on this, it looks great! It's pretty clear to me that this widget is different enough from the current combobox that using the old API and pushing the new design on every current client is not a good idea - in the same way that GtkPopover was made a different widget tha

Re: a new combo box

2014-12-27 Thread Christian Hergert
On 12/27/2014 01:44 PM, Morten Welinder wrote: > Can we keep the api -- function names, etc.? > > I.e., could we, for once, do such an upgrade without inflicting > pain on the users? Even at the cost of some pain for > developers. On the other hand, this is the type of thing where people also co

Re: a new combo box

2014-12-27 Thread Morten Welinder
Can we keep the api -- function names, etc.? I.e., could we, for once, do such an upgrade without inflicting pain on the users? Even at the cost of some pain for developers. Morten On Sat, Dec 27, 2014 at 4:29 PM, Matthias Clasen wrote: > On Sat, Dec 27, 2014 at 12:59 PM, Tristan Van Berkom >

Re: a new combo box

2014-12-27 Thread Matthias Clasen
On Sat, Dec 27, 2014 at 12:59 PM, Tristan Van Berkom wrote: > > It's really not that bad, combobox is currently < 6k lines of code which > is really not much for all that it does, sure we could afford to do a > bit less (like dropping the crazy tabular menus). Tbh, thats only true after your sho

Re: a new combo box

2014-12-27 Thread Tristan Van Berkom
On Sat, 2014-12-27 at 11:44 -0800, Christian Hergert wrote: > On 12/27/2014 07:50 AM, Tristan Van Berkom wrote: > > In any case, I think this misses the point I was trying to make, I think > > someone had to raise the obvious question: is it justified to bring in a > > whole new combo API ? Or can

Re: a new combo box

2014-12-27 Thread Christian Hergert
On 12/27/2014 07:50 AM, Tristan Van Berkom wrote: > In any case, I think this misses the point I was trying to make, I think > someone had to raise the obvious question: is it justified to bring in a > whole new combo API ? Or can we / should we get the most out of the API > we have ? Can I style

Re: a new combo box

2014-12-27 Thread Tristan Van Berkom
On Sat, 2014-12-27 at 18:05 +0100, Sébastien Wilmet wrote: > On Sun, Dec 28, 2014 at 12:50:24AM +0900, Tristan Van Berkom wrote: > > In any case, I think this misses the point I was trying to make, I think > > someone had to raise the obvious question: is it justified to bring in a > > whole new co

Re: a new combo box

2014-12-27 Thread Sébastien Wilmet
On Sun, Dec 28, 2014 at 12:50:24AM +0900, Tristan Van Berkom wrote: > In any case, I think this misses the point I was trying to make, I think > someone had to raise the obvious question: is it justified to bring in a > whole new combo API ? Or can we / should we get the most out of the API > we ha

Re: a new combo box

2014-12-27 Thread Genghis Khan
Does it work as depicted with Tiling Window Managers? On Sat, 27 Dec 2014 08:02:44 -0500 Matthias Clasen wrote: > Hi, > > over Christmas, I had some for a little side project, a new combo > box. It is based on these mockups: > https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/m

Re: a new combo box

2014-12-27 Thread David Nečas
On Sat, Dec 27, 2014 at 08:02:44AM -0500, Matthias Clasen wrote: > over Christmas, I had some for a little side project, a new combo > box. It is based on these mockups: > https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/theming/widgets/combobox-replacements.png > > ... >

Re: a new combo box

2014-12-27 Thread Tristan Van Berkom
On Sat, 2014-12-27 at 16:21 +0100, Sébastien Wilmet wrote: > On Sat, Dec 27, 2014 at 10:52:27PM +0900, Tristan Van Berkom wrote: > > From a quick look at gtkcombobox.h, the only really problematic part > > is the tabular menu nonsense (set_wrap_width(), set_row_span_column(), > > set_column_span_co

Re: a new combo box

2014-12-27 Thread Sébastien Wilmet
On Sat, Dec 27, 2014 at 10:52:27PM +0900, Tristan Van Berkom wrote: > From a quick look at gtkcombobox.h, the only really problematic part > is the tabular menu nonsense (set_wrap_width(), set_row_span_column(), > set_column_span_column()). Is there any way we could get around that ? > perhaps just

Re: a new combo box

2014-12-27 Thread Timm Bäder
On 27.12, Matthias Clasen wrote: > Hi, > > over Christmas, I had some for a little side project, a new combo > box. It is based on these mockups: > https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/theming/widgets/combobox-replacements.png Seems like these mockups (and the

Re: a new combo box

2014-12-27 Thread Tristan Van Berkom
On Sat, 2014-12-27 at 08:02 -0500, Matthias Clasen wrote: > Hi, > > over Christmas, I had some for a little side project, a new combo > box. It is based on these mockups: > https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/theming/widgets/combobox-replacements.png Looks ve

a new combo box

2014-12-27 Thread Matthias Clasen
Hi, over Christmas, I had some for a little side project, a new combo box. It is based on these mockups: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/theming/widgets/combobox-replacements.png One question I need some feedback on is naming: We currently have GtkComboBo