Re: Blacklisting themes?

2007-07-04 Thread Benjamin Berg
On Wed, 2007-04-07 at 01:48 +0200, Milosz Derezynski wrote: Reminds me all of http://bugzilla.gnome.org/show_bug.cgi?id=326249 I'm not sure this ever got a proper audit and all themes in general could need one. s/themes/engines/ ! And none of the engines in gtk-engines is exporting

Re: Blacklisting themes?

2007-07-03 Thread Milosz Derezynski
Reminds me all of http://bugzilla.gnome.org/show_bug.cgi?id=326249 I'm not sure this ever got a proper audit and all themes in general could need one. Does there exist a unittest suite for theme engines (and yeah i gues i just volunteered to write one if it doesn't. heh :) ? On 6/25/07, Morten

Re: Blacklisting themes?

2007-07-03 Thread Federico Mena Quintero
On Wed, 2007-07-04 at 01:48 +0200, Milosz Derezynski wrote: Reminds me all of http://bugzilla.gnome.org/show_bug.cgi?id=326249 I'm not sure this ever got a proper audit and all themes in general could need one. Hmm, didn't that get fixed? At least for the well-known themes? Does there

Re: Blacklisting themes?

2007-06-24 Thread Morten Welinder
I was thinking more of gtk+ blacklisting the theme, but nevermind that. 4. User updates gnumeric, and can't run it anymore because it barfs on that engine. He still risks crashes in other apps. Not quite. Gnumeric starts with default theme, looks strange, but works. M.

Re: Blacklisting themes?

2007-06-22 Thread Mathias Hasselmann
1. User gets a crash in gnumeric-n.m, reports it. 2. Developer determines that the crash is in the theme engine. 3. Developer blacklists the theme engine; releases gnumeric-n.m+1 4. User updates gnumeric, and can't run it anymore because it barfs on that engine. He still risks crashes

Re: Blacklisting themes?

2007-06-22 Thread Benjamin Berg
On Thu, 2007-21-06 at 20:25 -0500, Federico Mena Quintero wrote: On Tue, 2007-06-19 at 15:08 -0400, Morten Welinder wrote: The application programmer has no choice in the matter and cannot really test with all kinds of themes and all kinds of versions of them. But the resulting crashes

Re: Blacklisting themes?

2007-06-22 Thread Jody Goldberg
On Fri, Jun 22, 2007 at 02:04:17PM +0200, Benjamin Berg wrote: On Thu, 2007-21-06 at 20:25 -0500, Federico Mena Quintero wrote: On Tue, 2007-06-19 at 15:08 -0400, Morten Welinder wrote: The application programmer has no choice in the matter and cannot really test with all kinds of

Re: Blacklisting themes?

2007-06-22 Thread Federico Mena Quintero
On Fri, 2007-06-22 at 09:20 -0400, Jody Goldberg wrote: I don't think Morten's intent was to handle the blacklist at the application level. A more practical approach would be a bugbuddy extension that would compare the current theme engine and version against a central collection of known

Re: Blacklisting themes?

2007-06-21 Thread Kalle Vahlman
2007/6/19, Morten Welinder [EMAIL PROTECTED]: The application programmer has no choice in the matter and cannot really test with all kinds of themes and all kinds of versions of them. But the resulting crashes are still going to be blamed on the application and poor me. The usual way to

Re: Blacklisting themes?

2007-06-21 Thread Federico Mena Quintero
On Tue, 2007-06-19 at 15:08 -0400, Morten Welinder wrote: The application programmer has no choice in the matter and cannot really test with all kinds of themes and all kinds of versions of them. But the resulting crashes are still going to be blamed on the application and poor me. So the

Blacklisting themes?

2007-06-19 Thread Morten Welinder
In light of bug 438456, is there (or should there be) a way to blacklist a certain theme engine for a certain version range? Bug 438456 causes memory corruption in any gtk+ application it is applied to. Morten ___ gtk-devel-list mailing list

Re: Blacklisting themes?

2007-06-19 Thread Matthias Clasen
On 6/19/07, Morten Welinder [EMAIL PROTECTED] wrote: In light of bug 438456, is there (or should there be) a way to blacklist a certain theme engine for a certain version range? Bug 438456 causes memory corruption in any gtk+ application it is applied to. I don't see how this is different

Re: Blacklisting themes?

2007-06-19 Thread Morten Welinder
I don't see how this is different from any other memory corrupting bug in, say, a library. From a technical standpoint it is not. However, a theme is a library that is loaded into your application by the end-user. Even if he is not particularly aware of doing so. The application programmer