New rule

2010-10-21 Thread Richard Hughes
How about, if you plan to break API, it's mandatory to write entries in the migration guide. Heck, even a quick email to the mailing list explaining how to convert code might be nice. I'm getting really tired from people changing big parts of the API a few days before release, and then release tea

Re: New rule

2010-10-21 Thread Bastien Nocera
On Thu, 2010-10-21 at 17:33 +0100, Richard Hughes wrote: > How about, if you plan to break API, it's mandatory to write entries > in the migration guide. Heck, even a quick email to the mailing list > explaining how to convert code might be nice. > > I'm getting really tired from people changing b

Re: New rule

2010-10-21 Thread Tristan Van Berkom
On Thu, 2010-10-21 at 17:33 +0100, Richard Hughes wrote: > How about, if you plan to break API, it's mandatory to write entries > in the migration guide. Heck, even a quick email to the mailing list > explaining how to convert code might be nice. > > I'm getting really tired from people changing b

Re: New rule

2010-10-21 Thread Bastien Nocera
On Fri, 2010-10-22 at 01:48 +0900, Tristan Van Berkom wrote: > On Thu, 2010-10-21 at 17:33 +0100, Richard Hughes wrote: > > How about, if you plan to break API, it's mandatory to write entries > > in the migration guide. Heck, even a quick email to the mailing list > > explaining how to convert cod

Re: New rule

2010-10-21 Thread Tristan Van Berkom
On Thu, 2010-10-21 at 17:52 +0100, Bastien Nocera wrote: > On Fri, 2010-10-22 at 01:48 +0900, Tristan Van Berkom wrote: > > On Thu, 2010-10-21 at 17:33 +0100, Richard Hughes wrote: > > > How about, if you plan to break API, it's mandatory to write entries > > > in the migration guide. Heck, even a

Re: New rule

2010-10-21 Thread Bastien Nocera
On Fri, 2010-10-22 at 02:26 +0900, Tristan Van Berkom wrote: > > > And it doesn't fix our problems of applications being unportable to > the > > current GTK+ 3.x branch either. > > If apps are actually not portable at all to the new api, that's > definitely a problem we should address before actu

Re: New rule

2010-10-21 Thread Matthew Barnes
On Fri, 2010-10-22 at 01:48 +0900, Tristan Van Berkom wrote: > If anyone expects to release GNOME 3.0 apps with GTK+ 3.0 release > all at the same time, I have to say that's a bit far fetched. > > We should instead recommend that people port their applications > to GTK+ 3.0 *once we have an API*;

Re: New rule

2010-10-21 Thread Owen Taylor
On Fri, 2010-10-22 at 02:26 +0900, Tristan Van Berkom wrote: > > Except that we're talking about applications that are in the core > > desktop (gnome-bluetooth, gnome-power-manager, gnome-color-manager, > > gnome-packagekit, gnome-control-center), or in the default applications > > (totem in my cas

Re: New rule

2010-10-21 Thread Xan Lopez
On Fri, Oct 22, 2010 at 1:44 AM, Bastien Nocera wrote: > On Thu, 2010-10-21 at 17:33 +0100, Richard Hughes wrote: >> How about, if you plan to break API, it's mandatory to write entries >> in the migration guide. Heck, even a quick email to the mailing list >> explaining how to convert code might

Re: New rule

2010-10-21 Thread Matthias Clasen
On Thu, Oct 21, 2010 at 8:54 PM, Owen Taylor >  - Making sure there is information out about how to fix applications >   that need to be fixed. If updating the porting guide is too hard >   to do immediately, or you are changing something that was never >   in GTK+ 2, then send mail to desktop-dev

Re: New rule

2010-10-22 Thread Richard Hughes
On 21 October 2010 17:44, Bastien Nocera wrote: > devhelp won't compile because WebKitGTK wasn't ported. and: dh-assistant.c: In function 'assistant_key_press_event_cb': dh-assistant.c:49:30: error: 'GDK_Escape' undeclared (first use in this function) Richard. __

Re: New rule

2010-10-22 Thread Bastien Nocera
On Fri, 2010-10-22 at 10:38 +0100, Richard Hughes wrote: > On 21 October 2010 17:44, Bastien Nocera wrote: > > devhelp won't compile because WebKitGTK wasn't ported. > > and: > > dh-assistant.c: In function 'assistant_key_press_event_cb': > dh-assistant.c:49:30: error: 'GDK_Escape' undeclared (f

Re: New rule

2010-10-22 Thread Kristian Rietveld
On Oct 22, 2010, at 11:38 AM, Richard Hughes wrote: > On 21 October 2010 17:44, Bastien Nocera wrote: >> devhelp won't compile because WebKitGTK wasn't ported. > > and: > > dh-assistant.c: In function 'assistant_key_press_event_cb': > dh-assistant.c:49:30: error: 'GDK_Escape' undeclared (first u

Re: New rule

2010-10-22 Thread Olav Vitters
On Fri, Oct 22, 2010 at 10:40:29AM +0100, Bastien Nocera wrote: > On Fri, 2010-10-22 at 10:38 +0100, Richard Hughes wrote: > > On 21 October 2010 17:44, Bastien Nocera wrote: > > > devhelp won't compile because WebKitGTK wasn't ported. > > > > and: > > > > dh-assistant.c: In function 'assistant_

Re: New rule

2010-10-22 Thread Richard Hughes
On 22 October 2010 10:40, Bastien Nocera wrote: > That's hardly a blocker, I guess you can commit that fix yourself :) Right, my point was more to show that developers (and more importantly testers) just aren't running the latest GTK. I think I'm the only one of the gnome-color-manager community

Re: New rule

2010-10-22 Thread Ryan Lortie
hi Bastien, On Thu, 2010-10-21 at 17:44 +0100, Bastien Nocera wrote: > I'll also note that some apps can't be ported, like gnome-control-center > or totem because the only way to get arguments is through "open" which > only deals with files/URIs. Give G_APPLICATION_HANDLES_COMMAND_LINE in the GAp

Re: New rule

2010-10-22 Thread Bastien Nocera
On Fri, 2010-10-22 at 14:34 +0200, Ryan Lortie wrote: > hi Bastien, > > On Thu, 2010-10-21 at 17:44 +0100, Bastien Nocera wrote: > > I'll also note that some apps can't be ported, like gnome-control-center > > or totem because the only way to get arguments is through "open" which > > only deals wi