Re: Proposal: Enable threads by default

2010-01-12 Thread Alexander Larsson
On Tue, 2009-12-01 at 14:29 +0100, Alexander Larsson wrote: > On Thu, 2009-11-26 at 14:35 +0100, Alexander Larsson wrote: > > This was previously discussed here, but was sort of hidden in a > > technical discussion so it got no replies. I'm starting over in > order > > to > > reach a wider target f

Re: Proposal: Enable threads by default

2009-12-07 Thread Stefan Kost
Am 06.12.2009 21:22, schrieb Dan Winship: > On 12/06/2009 10:05 AM, Adam Goode wrote: >> I guess what I really would like is a way that I can use GLib privately >> from my library and have it be thread-safe without requiring users of my >> library have to link against gthread and call g_thread_init

Re: Proposal: Enable threads by default

2009-12-07 Thread Alexander Larsson
On Sun, 2009-12-06 at 14:22 -0500, Dan Winship wrote: > On 12/06/2009 10:05 AM, Adam Goode wrote: > > I guess what I really would like is a way that I can use GLib > privately > > from my library and have it be thread-safe without requiring users > of my > > library have to link against gthread and

Re: Proposal: Enable threads by default

2009-12-06 Thread Dan Winship
On 12/06/2009 10:05 AM, Adam Goode wrote: > I guess what I really would like is a way that I can use GLib privately > from my library and have it be thread-safe without requiring users of my > library have to link against gthread and call g_thread_init. I think it > is primarily just GSlice that is

Re: Proposal: Enable threads by default

2009-12-06 Thread Adam Goode
On 12/06/2009 03:16 AM, Alexander Larsson wrote: > This change only affects the case where the appliation uses gobject (and > thus initializes it early). If g_type_init is not called then there is > no difference wrt the current behaviour. > I see. This seems like a step in the right direction, b

Re: Proposal: Enable threads by default

2009-12-06 Thread Alexander Larsson
On Sat, 2009-12-05 at 19:45 -0500, Adam Goode wrote: > > I'll start with the proposal and then explain the reasons for it: > > > > Starting with next glib release: > > * libgobject links to libgthread > > * g_type_init() starts with: > > > > #ifdef G_THREADS_ENABLED > > if (g_thread_supported()

Re: Proposal: Enable threads by default

2009-12-05 Thread Andrew Cowie
On Sat, 2009-12-05 at 19:45 -0500, Adam Goode wrote: > Specifically, I have a library that internally uses GSlice and > GHashTable, but I don't expose any GLib details. I link my library with > Java and other applications that use pthreads. In the java-gnome library (the Java language bindings to

Re: Proposal: Enable threads by default

2009-12-05 Thread Adam Goode
> I'll start with the proposal and then explain the reasons for it: > > Starting with next glib release: > * libgobject links to libgthread > * g_type_init() starts with: > > #ifdef G_THREADS_ENABLED > if (g_thread_supported()) >g_thread_init (NULL); > #endif > > This means that everything

Re: Proposal: Enable threads by default

2009-12-02 Thread Colin Walters
On Wed, Dec 2, 2009 at 8:38 PM, Alexander Larsson wrote: > > This particular instance is fixed, but there can be a lot more out > there. Why force every app to add this check when we could do it > ourselves. I'm not objecting to defaulting to working around this bug; it's certainly possible other

Re: Proposal: Enable threads by default

2009-12-02 Thread Alexander Larsson
On Wed, 2009-12-02 at 18:01 +, Colin Walters wrote: > On Wed, Dec 2, 2009 at 11:03 AM, Alexander Larsson > wrote: > > > > Running with this patch i ran into an issue while building > gnome-shell: > > > > GENGdm-1.0.gir > > > > GThread-ERROR **: GThread system may only be initialized once.

Re: Proposal: Enable threads by default

2009-12-02 Thread Colin Walters
On Wed, Dec 2, 2009 at 11:03 AM, Alexander Larsson wrote: > > Running with this patch i ran into an issue while building gnome-shell: > >  GEN    Gdm-1.0.gir > > GThread-ERROR **: GThread system may only be initialized once. > aborting... > Command '['/gnome/src/gnome-shell/src/tmp-introspectpoWP_

Re: Proposal: Enable threads by default

2009-12-02 Thread Alexander Larsson
On Wed, 2009-12-02 at 13:07 +, jcup...@gmail.com wrote: > 2009/12/2 Alexander Larsson : > > On Wed, 2009-12-02 at 11:48 +, jcup...@gmail.com wrote: > >> 2009/12/2 Alexander Larsson : > >> > I'm certainly for this. Does anyone know of any system in use > where > >> > gthreads are not availib

Re: Proposal: Enable threads by default

2009-12-02 Thread jcupitt
2009/12/2 Alexander Larsson : > On Wed, 2009-12-02 at 11:48 +, jcup...@gmail.com wrote: >> 2009/12/2 Alexander Larsson : >> > I'm certainly for this. Does anyone know of any system in use where >> > gthreads are not availible? >> >> One problem I've had in the past is writing mysql plugins. >>

Re: Proposal: Enable threads by default

2009-12-02 Thread Alexander Larsson
On Wed, 2009-12-02 at 11:48 +, jcup...@gmail.com wrote: > 2009/12/2 Alexander Larsson : > > I'm certainly for this. Does anyone know of any system in use where > > gthreads are not availible? > > One problem I've had in the past is writing mysql plugins. > > I help maintain an image processin

Re: Proposal: Enable threads by default

2009-12-02 Thread jcupitt
2009/12/2 Alexander Larsson : > I'm certainly for this. Does anyone know of any system in use where > gthreads are not availible? One problem I've had in the past is writing mysql plugins. I help maintain an image processing library, and one use of the library was a mysql plugin that added query-

Re: Proposal: Enable threads by default

2009-12-02 Thread Alexander Larsson
On Tue, 2009-12-01 at 14:29 +0100, Alexander Larsson wrote: > On Thu, 2009-11-26 at 14:35 +0100, Alexander Larsson wrote: > > This was previously discussed here, but was sort of hidden in a > > technical discussion so it got no replies. I'm starting over in > order > > to > > reach a wider target f

Re: Proposal: Enable threads by default

2009-12-02 Thread Alexander Larsson
On Tue, 2009-12-01 at 16:16 -0500, Dan Winship wrote: > On 12/01/2009 03:36 PM, Alexander Larsson wrote: > > I don't think that is quite right. Its only safe to set this define > if > > you can guarantee there is no calls to your code before g_type_init > (or > > g_thread_init directly) is called.

Re: Proposal: Enable threads by default

2009-12-01 Thread Dan Winship
On 12/01/2009 03:36 PM, Alexander Larsson wrote: > I don't think that is quite right. Its only safe to set this define if > you can guarantee there is no calls to your code before g_type_init (or > g_thread_init directly) is called. Hrmph. Could potentially add a define which would cause a G_LIKEL

Re: Proposal: Enable threads by default

2009-12-01 Thread Alexander Larsson
On Tue, 2009-12-01 at 09:26 -0500, Dan Winship wrote: > On 12/01/2009 08:29 AM, Alexander Larsson wrote: > > In addition to enabling threads (if complied in) in g_type_init() it > > adds a G_THREADS_MANDATORY define that if set causes all the > > g_thread_supported() calls to be removed in the g_th

Re: Proposal: Enable threads by default

2009-12-01 Thread Dan Winship
On 12/01/2009 08:29 AM, Alexander Larsson wrote: > In addition to enabling threads (if complied in) in g_type_init() it > adds a G_THREADS_MANDATORY define that if set causes all the > g_thread_supported() calls to be removed in the g_thread_* macros. Should probably add that to Cflags in gobject-

Re: Proposal: Enable threads by default

2009-12-01 Thread Alexander Larsson
On Thu, 2009-11-26 at 14:35 +0100, Alexander Larsson wrote: > This was previously discussed here, but was sort of hidden in a > technical discussion so it got no replies. I'm starting over in order > to > reach a wider target for the discussion. > > I'll start with the proposal and then explain th

Re: Proposal: Enable threads by default

2009-11-26 Thread Alexander Larsson
On Thu, 2009-11-26 at 18:27 +0100, Christian Dywan wrote: > Am Thu, 26 Nov 2009 14:35:36 +0100 > schrieb Alexander Larsson : > > > This was previously discussed here, but was sort of hidden in a > > technical discussion so it got no replies. I'm starting over in > order > > to reach a wider target

Re: Proposal: Enable threads by default

2009-11-26 Thread Tim-Philipp Müller
On Thu, 2009-11-26 at 14:35 +0100, Alexander Larsson wrote: > Starting with next glib release: > * libgobject links to libgthread > * g_type_init() starts with: > > #ifdef G_THREADS_ENABLED > if ([!]g_thread_supported()) >g_thread_init (NULL); > #endif > > This means that everything above

Re: Proposal: Enable threads by default

2009-11-26 Thread Christian Dywan
Am Thu, 26 Nov 2009 14:35:36 +0100 schrieb Alexander Larsson : > This was previously discussed here, but was sort of hidden in a > technical discussion so it got no replies. I'm starting over in order > to reach a wider target for the discussion. > > I'll start with the proposal and then explain

Re: Proposal: Enable threads by default

2009-11-26 Thread Benjamin Otte
Alexander Larsson redhat.com> writes: > Starting with next glib release: > * libgobject links to libgthread > * g_type_init() starts with: > > #ifdef G_THREADS_ENABLED > if (g_thread_supported()) >g_thread_init (NULL); > #endif > Finally. I'm so sick of the issues (mostly performance-rela

Proposal: Enable threads by default

2009-11-26 Thread Alexander Larsson
This was previously discussed here, but was sort of hidden in a technical discussion so it got no replies. I'm starting over in order to reach a wider target for the discussion. I'll start with the proposal and then explain the reasons for it: Starting with next glib release: * libgobject links