Re: Review of wip/carlosg/event-delivery

2017-05-18 Thread Alexander Larsson
On Wed, 2017-05-17 at 17:45 +0200, Carlos Garnacho wrote: > Hej hej, > > On Wed, May 17, 2017 at 3:27 PM, Alexander Larsson > wrote: > > On Wed, 2017-05-17 at 01:04 +0200, Carlos Garnacho wrote: > > > Hey, > > > > > > On Tue, May 16, 2017 at 8:24 PM, Matthias Clasen > > >

Re: Review of wip/carlosg/event-delivery

2017-05-17 Thread Carlos Garnacho
Hej hej, On Wed, May 17, 2017 at 3:27 PM, Alexander Larsson wrote: > On Wed, 2017-05-17 at 01:04 +0200, Carlos Garnacho wrote: >> Hey, >> >> On Tue, May 16, 2017 at 8:24 PM, Matthias Clasen >> wrote: >> > On Tue, May 16, 2017 at 1:25 PM, Carlos

Re: Review of wip/carlosg/event-delivery

2017-05-17 Thread Alexander Larsson
On Wed, 2017-05-17 at 01:04 +0200, Carlos Garnacho wrote: > Hey, > > On Tue, May 16, 2017 at 8:24 PM, Matthias Clasen > wrote: > > On Tue, May 16, 2017 at 1:25 PM, Carlos Garnacho > > wrote: > > > > > > > > > >   - interactive overlay: buttons

Re: Review of wip/carlosg/event-delivery

2017-05-16 Thread Carlos Garnacho
Hey, On Tue, May 16, 2017 at 8:24 PM, Matthias Clasen wrote: > On Tue, May 16, 2017 at 1:25 PM, Carlos Garnacho wrote: >> >> >> > - interactive overlay: buttons over entry get prelights and clicks >> > instead of the entry stealing them >> >>

Re: Review of wip/carlosg/event-delivery

2017-05-16 Thread Matthias Clasen
On Tue, May 16, 2017 at 1:25 PM, Carlos Garnacho wrote: > > > - interactive overlay: buttons over entry get prelights and clicks > > instead of the entry stealing them > > Hmm, the demo however sets the overlay as passthrough? >

Re: Review of wip/carlosg/event-delivery

2017-05-16 Thread Carlos Garnacho
Hi Alex, Thanks for the review! On Tue, May 16, 2017 at 12:54 PM, Alexander Larsson wrote: > I took a quick look at the wip/carlosg/event-delivery branch. > > Here are some things in the tests that seems broken from interactive > testing: > > testgtk > - click on close button

Review of wip/carlosg/event-delivery

2017-05-16 Thread Alexander Larsson
I took a quick look at the wip/carlosg/event-delivery branch. Here are some things in the tests that seems broken from interactive testing: testgtk  - click on close button gives:     Gtk-CRITICAL **: _gtk_widget_captured_event: assertion 'WIDGET_REALIZED_FOR_EVENT (widget, event)' failed