Re: Running -Wall -Werror on glib

2008-12-29 Thread Behdad Esfahbod
Maciej Piechotka wrote: > For example the g_ptr_array_set_size (array, -1) is perfectly legal call > although the exact behaviour is undefined as I believe. Changing the > gint to guint would: > - Change nothing for the 'non-purist' as the for (int i = ...) ... will > still work (the cast will be

Re: Running -Wall -Werror on glib

2008-12-29 Thread Loïc Minier
On Mon, Dec 29, 2008, Maciej Piechotka wrote: > PPS. I'm attaching a small patch for some of the issues: Note that glib/pcre/ is an embedded copy of the pcre lib; would be best to send this part upstream, to the pcre developers. -- Loïc Minier ___ gt

Running -Wall -Werror on glib

2008-12-29 Thread Maciej Piechotka
I've just run compilation with -Wall -Wextra on glib (version from git). There are several types of error: - Unused parameters and similar errors to which solutionis to tell compilator to ignore it - Unused variables and other. Since it is not a highly secure pseudorandom generator I guess they can