Re: test locations

2009-07-13 Thread Benjamin Otte
On Mon, Jul 13, 2009 at 5:02 PM, Sven Herzberg wrote: > Benjamin, > > What's the problem in just keeping to use "make all-am" for your > compile-warning-testing and before you commit, execute "make all" and be > happy (unless you changes the behavior, then you want to run "make > check" as well). >

Re: test locations

2009-07-13 Thread Sven Herzberg
Benjamin, Am Montag, den 13.07.2009, 16:52 +0200 schrieb Benjamin Otte: > On Mon, Jul 13, 2009 at 3:55 PM, Martin Nordholts wrote: > > Always building the tests ensures that they are kept up do date with changes > > in the rest of the code base. If they are not built along with the rest of > > the

Re: test locations

2009-07-13 Thread Benjamin Otte
On Mon, Jul 13, 2009 at 3:55 PM, Martin Nordholts wrote: > Always building the tests ensures that they are kept up do date with changes > in the rest of the code base. If they are not built along with the rest of > the code base then they will eventually become out of sync and someone has > to fix

Re: test locations

2009-07-13 Thread Martin Nordholts
On 07/13/2009 03:47 PM, Matthias Clasen wrote: - Why are the tests built during "make" and not only for "make check"? That is certainly something that can be fixed. I'd welcome a patch to so. Always building the tests ensures that they are kept up do date with changes in the rest o

Re: test locations

2009-07-13 Thread Matthias Clasen
On Mon, Jul 13, 2009 at 5:32 AM, Benjamin Otte wrote: > > Apparently this was not the desired result, as Matthias moved them > back. I tried to read up in the git log about why, but didn't find > anything conclusive. So I'm wondering: > - Should tests be located in $LIB/tests or tests/$LIB and why?

test locations

2009-07-13 Thread Benjamin Otte
Hi, This is about 5694ab7642c9ba6fbb85424e71d1c42c17661dd1 and the location of tests. When hacking on gio, I had complained that make always decided to rebuild the tests in gio/tests while I was hacking on the library. That has quite a few inconveniences: - It results in increased output while bui