Hi,
In the course turning down some verbosity in the diags to check out a
problem with the bitzi code I did this:
diff -u -b -r1.3 dmesh.c
--- src/core/dmesh.c 6 Oct 2004 05:12:18 -0000 1.3
+++ src/core/dmesh.c 18 Oct 2004 23:21:06 -0000
@@ -1,4 +1,4 @@
-/*
+/* -*- mode: cc-mode; tab-width:4; -*-
* $Id: dmesh.c,v 1.3 2004/10/06 05:12:18 cbiere Exp $
*
* Copyright (c) 2002-2003, Raphael Manfredi
@@ -801,9 +801,9 @@
dme->url.idx = idx;
dme->url.name = atom_str_get(name);
- if (dbg)
- printf("dmesh entry created, name %p: %s\n",
- dme->url.name, dme->url.name);
+ if (dbg>2)
+ printf("dmesh entry created, count %d, name %p: %s\n",
+ dm->count, dme->url.name,
dme->url.name);
/*
* The entries are sorted by time. We're going to
unconditionally add
@@ -827,6 +827,14 @@
} else
dm->count++;
+ if (dbg && dme==NULL)
+ {
+ if (file_info_active(sha1)!=NULL)
+ g_warning("dmesh entry for active file thrown away: name
%p: %s",
+ sha1, sha1_base32(sha1));
+ }
+
+
And I saw a load of these:
04/10/19 00:23:05 (WARNING): dmesh entry for active file thrown away:
name 0x83cf1b4: FRS.....
I double checked the SHA1 and sure enough they match active downloads on
my system. Now the dmesh code only actually tries to swarm with a new
entry is successfully added to the mesh which fails if the mesh has more
than a fixed number of entries.
My questions are these:
* Should the MAX_ENTRIES be ignored for files that we are actively
downloading?
* Is the oldest timestamp a suitable test for goodness of the dmesh
entry? Could we be throwing away "good" entries for potentially more
upto date entries that still may not be currently available?
-- Alex, homepage: http://www.bennee.com/~alex/ "It is better to have
tried and failed than to have failed to try, but the result's the same."
- Mike Dennison
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Gtk-gnutella-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel
