[Libguestfs] Re: [PATCH virt-v2v 6/6] virt-v2v: -i vmx: Replace external ssh/scp with nbdkit-ssh-plugin

I pushed this and 3 additional patches upstream in commits 8a387609a0..67fcf66904. Two of the additional patches were just more code tidy up. The final patch removes the paragraph from the documentation related to -ip not covering all ssh cases. From inspection of the code it does look as if we

[Libguestfs] Re: [PATCH virt-v2v 6/6] virt-v2v: -i vmx: Replace external ssh/scp with nbdkit-ssh-plugin

On Wed, Jan 17, 2024 at 09:24:59AM +0100, Laszlo Ersek wrote: > On 1/15/24 19:24, Richard W.M. Jones wrote: > > If you use a -i vmx ssh filename containing '*' then it will expand > > the glob at the remote side. New scp is weird and silently creates a > > directory on the local side, eg: > > > >

[Libguestfs] Re: [PATCH virt-v2v 4/6] virt-v2v: -i vmx: Remove dependency of ssh.ml on Xml.uri

On Wed, Jan 17, 2024 at 07:17:39AM +0100, Laszlo Ersek wrote: > On 1/15/24 19:24, Richard W.M. Jones wrote: > > -let download_file uri output = > > +let download_file ~password ?port ~server ?user path output = > > (1) so here's where I suggest that (if syntactically possible) we don't > bind "pas

[Libguestfs] Re: [PATCH virt-v2v 3/6] virt-v2v: -i vmx: Add the input password to vmx_source

On Wed, Jan 17, 2024 at 06:23:33AM +0100, Laszlo Ersek wrote: > On 1/15/24 19:24, Richard W.M. Jones wrote: > > Since we use the input password in various places in the VMX module, > > store the input password in vmx_source. This neutral refactoring > > makes later changes simpler. > > --- > > in

[Libguestfs] Re: [PATCH virt-v2v 1/6] virt-v2v: -i vmx: Refactor ssh/scp code into a new module

On Wed, Jan 17, 2024 at 05:21:53AM +0100, Laszlo Ersek wrote: > On 1/15/24 19:24, Richard W.M. Jones wrote: > > This is a straight refactor of the existing code that handles ssh/scp > > into a new module. In this commit I just copy the code around without > > doing any cleanup; cleanup will follow

[Libguestfs] Re: [PATCH virt-v2v 4/6] virt-v2v: -i vmx: Remove dependency of ssh.ml on Xml.uri

On 1/17/24 07:17, Laszlo Ersek wrote: > (4) Can we introduce a helper function that takes a URI and returns a > tuple (server, port, user, path)? Then it could be called from both > "input_vmx.ml" and "parse_domain_from_vmx.ml", plus in the latter, we > could use the path component of the returned

[Libguestfs] Re: [PATCH virt-v2v 6/6] virt-v2v: -i vmx: Replace external ssh/scp with nbdkit-ssh-plugin

On 1/15/24 19:24, Richard W.M. Jones wrote: > If you use a -i vmx ssh filename containing '*' then it will expand > the glob at the remote side. New scp is weird and silently creates a > directory on the local side, eg: > > scp 'remote:/tmp/test*' '/tmp/test*' > > if there are multiple files m

[Libguestfs] Re: [PATCH virt-v2v 3/6] virt-v2v: -i vmx: Add the input password to vmx_source

On 1/17/24 06:23, Laszlo Ersek wrote: > (2) A further question: now I wanted to recheck how "Ssh.download_file > uri" actually uses the password file passed in with "-ip", and the > answer, as far as I can tell, is that it doesn't! > > The manual

[Libguestfs] Re: [PATCH virt-v2v 5/6] input/nbdkit_ssh: Make retry filter optional

On 1/15/24 19:24, Richard W.M. Jones wrote: > This filter retries a request on failure. Add a flag to make this > filter optional, but default to using it if available (so there's no > change to default behaviour). > > The reason we want to make this option is that the next commit will > want to