Broken Backtraces, and Part of a Solution

2012-04-18 Thread Noah Lavine
Hello all, I recently realized that backtraces weren't working for me in the most recent build of Guile master. Specifically, I could get to a debug prompt fine, but when I tried to get a backtrace, it always came up empty. The problem happens in this code in

Re: Broken Backtraces, and Part of a Solution

2012-04-18 Thread Noah Lavine
Sorry for the quick update, but this seems to be a result of commit 283ab48d3f20a5c5281cafc29f0c30c8d8ace9ee, on March 7th. The fluid %stacks is set in %start-stack, in boot-9.scm. %start-stack calls make-prompt-tag, also in boot-9.scm. The commit above switched prompt tags from using gensyms to

Re: Broken Backtraces, and Part of a Solution

2012-04-18 Thread Andy Wingo
On Wed 18 Apr 2012 17:02, Noah Lavine noah.b.lav...@gmail.com writes: The problem is that narrow-stack-vector returns #(). It does this because the stack is narrowed to nothing. The narrowing really happens in the functions scm_make_stack and narrow_stack, in stacks.c. The reason it narrows

Re: Broken Backtraces, and Part of a Solution

2012-04-18 Thread Noah Lavine
On Wed, Apr 18, 2012 at 8:56 PM, Andy Wingo wi...@pobox.com wrote: On Wed 18 Apr 2012 17:02, Noah Lavine noah.b.lav...@gmail.com writes: The problem is that narrow-stack-vector returns #(). It does this because the stack is narrowed to nothing. The narrowing really happens in the functions

Re: bug#11262: help text fro sorted? predicate is wrong/misleading.

2012-04-18 Thread Noah Lavine
It looks like you're right, and strangely enough there's a comment in sort.c right above the definition of sorted? that has the correct documentation. I hope other people will correct me if I'm wrong, but I believe the ideal thing for you to do now is submit a patch created with git format-patch.

Re: Broken Backtraces, and Part of a Solution

2012-04-18 Thread Andy Wingo
On Wed 18 Apr 2012 18:08, Noah Lavine noah.b.lav...@gmail.com writes: We need to change to default to consider generic objects as eq?-compared prompt tags. I agree, but you still couldn't use procedures or integers as prompt tags if you wanted make-stack to work, because those are special

Re: Broken Backtraces, and Part of a Solution

2012-04-18 Thread Noah Lavine
Here's a patch that fixes the bug for me. I'd also like to add a test suite for the stack functions, to make sure this doesn't happen again, but I'll look at that later. Noah On Wed, Apr 18, 2012 at 9:36 PM, Andy Wingo wi...@pobox.com wrote: On Wed 18 Apr 2012 18:08, Noah Lavine