[PATCH] In string-split, add support for character sets and predicates.

2012-10-08 Thread Daniel Hartwig
Following up on the thread from last time regexp-split was discussed. On 8 January 2012 07:05, Andy Wingo wrote: > On Sat 31 Dec 2011 06:54, Daniel Hartwig writes: >> * [Vanilla `string-split' expanded to support the CHAR_PRED >> semantics of `string-index' et al.] > > Makes sense to me. > At

Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.6-33-gbcf87e3

2012-10-08 Thread Ludovic Courtès
Hi Mark, "Mark H Weaver" skribis: > commit bcf87e35e17741c279b755b0804776cdc8ee5828 > Author: Mark H Weaver > Date: Mon Oct 8 00:37:09 2012 -0400 > > Don't simplify 'equal?' to 'not' or 'null?'. > > * module/language/tree-il/primitives.scm (*primitive-expand-table*): > Don'

Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.6-31-g2446f8e

2012-10-08 Thread Ludovic Courtès
Hi Mark, Please ignore my previous message, I’ve been reading them in the wrong order. ;-) Mark H Weaver skribis: > (not v) is not the same as (equal? #f v) when v is #nil. [...] > (null? v) is not the same as (equal? '() v) when v is #nil. Ah right, I had thought about #nil, but missed tho

Re: [PATCH] In string-split, add support for character sets and predicates.

2012-10-08 Thread Mark H Weaver
Hi Daniel, Thanks for the patch! I have a few comments. Daniel Hartwig writes: > From 0aeed16baa70eca143fec05e864f98d95d7267e8 Mon Sep 17 00:00:00 2001 > From: Daniel Hartwig > Date: Mon, 8 Oct 2012 18:35:00 +0800 > Subject: [PATCH] In string-split, add support for character sets and > predic

[PATCH] Preserve keyword in 'syntax-rules' and 'define-syntax-rule'

2012-10-08 Thread Mark H Weaver
Hello all, I'd like to be able to do things like this: --8<---cut here---start->8--- (define-syntax alt-environment (syntax-rules () ((alt-environment) (the-environment alt-environment --8<---cut here---end--->

Re: [PATCH] In string-split, add support for character sets and predicates.

2012-10-08 Thread Daniel Hartwig
Hi Mark Thanks for the speedy response. General ACK on all your comments. Some additional notes: On 8 October 2012 23:40, Mark H Weaver wrote: >> [which vs. that] This was straight out of the doc string for string-index. Changed. >> + if (SCM_CHARP (char_pred)) >> +{ >> + goto spl