Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Fri 15 Jul 2016 21:04, Eli Zaretskii writes: > The issues with dirname and basename, for which I posted a patch here: > > https://lists.gnu.org/archive/html/guile-devel/2014-07/msg00012.html > > were subsequently discussed, but the code was not changed, AFAICT. I think we want to go with Gn

Re: MinGW open-process, take N

2016-07-23 Thread Andy Wingo
On Sat 16 Jul 2016 19:02, Eli Zaretskii writes: >> Date: Sat, 16 Jul 2016 16:24:46 +0300 >> From: Eli Zaretskii >> Cc: m...@netris.org, l...@gnu.org, guile-devel@gnu.org >> >> Is it okay to push what I have now, and remove all the tabs from >> posix-w32.c (not just those I added) in a follow-up

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Sat 16 Jul 2016 17:37, Eli Zaretskii writes: >> From: Andy Wingo >> Cc: guile-devel@gnu.org >> Date: Sat, 16 Jul 2016 15:39:23 +0200 >> >> I think the right thing here is to use the mkostemp gnulib module >> instead and pass O_BINARY in the flags. I have made this change in >> git; please l

Re: add command line option to quiet compiler messages

2016-07-23 Thread Andy Wingo
Hi :) On Wed 20 Jul 2016 08:41, Tobin Harding writes: > On Thu, Jul 14, 2016 at 12:01:10PM +0200, Andy Wingo wrote: >> On Wed 13 Jul 2016 06:08, Tobin Harding writes: >> >> > While working on this I discovered that compile messages are output from >> > two >> > separate places (load.c and boo

c-api.test fails on MS-Windows due to non-portable quoting

2016-07-23 Thread Eli Zaretskii
It fails like this: Running c-api.test 'CUR' is not recognized as an internal or external command, operable program or batch file. egrep: Unmatched ( or \('CUR' is not recognized as an internal or external command, operable program or batch file. This is because it quotes she

Guile tests that cannot work on MS-Windows and should be disabled

2016-07-23 Thread Eli Zaretskii
These tests are: . ftw.test, which fails because ftw is not available: FAIL: ftw.test: file-system-fold: test-suite ERROR: ftw.test: file-system-fold: EACCES - arguments: ((unbound-variable #f "Unbound variable: ~S" (getuid) #f)) ERROR: ftw.test: file-system-fold: dangling symlin

Guile test-ffi uses an unportable assumption

2016-07-23 Thread Eli Zaretskii
It assumes that libltdl can only produce a handle for a symbol in the the program itself, as opposed to those loaded from shared libraries. It tries 'strerror'. This cannot work on MS-Windows, unless the program was linked with -export-dynamic, which is not true for the test program. So this test

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Fri 22 Jul 2016 12:21, Eli Zaretskii writes: > Ping! Two out of 3 patches sent here: > > https://lists.gnu.org/archive/html/guile-devel/2016-07/msg00085.html > > are still waiting to be accepted. I pushed the basename/dirname patch, using dirname-lgpl from gnulib as Ludo had suggested many

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Sat 16 Jul 2016 13:24, Eli Zaretskii writes: > From f55f1e8de40b38cc745a930bf5a374c73d3c67ce Mon Sep 17 00:00:00 2001 > From: Eli Zaretskii > Date: Sat, 16 Jul 2016 14:22:06 +0300 > Subject: [PATCH] Fix 'strftime' for MS-Windows > > * libguile/stime.c (scm_strftime) [__MINGW32__]: Don't use t

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 23 Jul 2016 14:15:06 +0200 > > > * libguile/stime.c (scm_strftime) [__MINGW32__]: Don't use the > > trick of appending "0" to the time-zone string, Windows runtime > > doesn't support that. > > +#ifndef __MINGW32__ > > +/* Don't do thi

Re: MinGW-related patches that were reported in 2014 but not applied

2016-07-23 Thread Andy Wingo
On Sat 23 Jul 2016 15:07, Eli Zaretskii writes: >> From: Andy Wingo >> Cc: guile-devel@gnu.org >> Date: Sat, 23 Jul 2016 14:15:06 +0200 >> >> > * libguile/stime.c (scm_strftime) [__MINGW32__]: Don't use the >> > trick of appending "0" to the time-zone string, Windows runtime >> > doesn't suppor

Re: Avoid warnings in threads.c when building without threads

2016-07-23 Thread Andy Wingo
On Sat 16 Jul 2016 19:12, Eli Zaretskii writes: > The patch to shut up these warnings is below. OK to commit? > > --- libguile/null-threads.h~0 2016-01-02 13:32:40.0 +0200 > +++ libguile/null-threads.h 2016-07-15 17:47:37.101375000 +0300 > @@ -43,7 +43,7 @@ > #define scm_i_pthread_cre

Re: Avoid warnings in sockets.c when HAVE_SIN6_SCOPE_ID is unavailable

2016-07-23 Thread Andy Wingo
Hi :) On Sat 16 Jul 2016 19:16, Eli Zaretskii writes: > CC libguile_2.0_la-socket.lo > socket.c: In function 'scm_fill_sockaddr': > socket.c:747:16: warning: variable 'scope_id' set but not used > [-Wunused-but-set-variable] > unsigned long scope_id = 0; > ^ >

Re: Avoid warning about alloca in read.c

2016-07-23 Thread Andy Wingo
On Sat 16 Jul 2016 19:18, Eli Zaretskii writes: >CC libguile_2.0_la-read.lo > read.c: In function 'try_read_ci_chars': > read.c:983:3: warning: implicit declaration of function 'alloca' > [-Wimplicit-function-declaration] > read.c:983:22: warning: incompatible implic

Re: guile-lib - devel branch - patch 4 of 11

2016-07-23 Thread Andy Wingo
On Sun 17 Jul 2016 04:36, Eli Zaretskii writes: > If there are known problems with older versions that get in the way, I > agree. Are there? > > If there are no known problems that interfere with maintaining Guile, > I think refraining from the above will be nicer to our users. To be clear this

Re: Update 'uname' emulation on MS-Windows

2016-07-23 Thread Andy Wingo
On Sun 17 Jul 2016 14:04, Eli Zaretskii writes: >> Date: Sun, 17 Jul 2016 05:37:24 +0300 >> From: Eli Zaretskii >> Cc: guile-devel@gnu.org >> >> > Does the Mingw toolchain supply a suitable manifest automatically ? >> >> No. The manifest should be provided with Guile. > > Of course, singe Gui

Re: c-api.test fails on MS-Windows due to non-portable quoting

2016-07-23 Thread Andy Wingo
On Sat 23 Jul 2016 13:18, Eli Zaretskii writes: > It fails like this: > > Running c-api.test > 'CUR' is not recognized as an internal or external command, > operable program or batch file. > egrep: Unmatched ( or \('CUR' is not recognized as an internal or > external command,

Re: Guile test-ffi uses an unportable assumption

2016-07-23 Thread Andy Wingo
On Sat 23 Jul 2016 13:51, Eli Zaretskii writes: > It assumes that libltdl can only produce a handle for a symbol in the > the program itself, as opposed to those loaded from shared libraries. > It tries 'strerror'. This cannot work on MS-Windows, unless the > program was linked with -export-dyna

Re: Avoid warnings in threads.c when building without threads

2016-07-23 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 23 Jul 2016 22:49:03 +0200 > > On Sat 16 Jul 2016 19:12, Eli Zaretskii writes: > > > The patch to shut up these warnings is below. OK to commit? > > > > --- libguile/null-threads.h~0 2016-01-02 13:32:40.0 +0200 > > +++ lib

Re: Avoid warning about alloca in read.c

2016-07-23 Thread Eli Zaretskii
> From: Andy Wingo > Cc: guile-devel@gnu.org > Date: Sat, 23 Jul 2016 22:57:02 +0200 > > > +#ifdef __MINGW32__ > > +#include > > +#endif > > + > > OK to commit but please remove the ifdef -- just include in all > cases. Is that header available on all supported platforms?