Re: [PATCH] add SRFI-119 / language/wisp to Guile? (new patch with more tests, squashed)

2024-06-01 Thread Dr. Arne Babenhauserheide
Hi Ludo’, Ludovic Courtès writes: > I have the pleasure to inform you that I have finally pushed this! :-) > > Apologies for taking so long, and thank you for being patient. Thank you for reviewing and pushing it! > Some of the suggestions I made earlier¹ were still not implemented > though:

[PATCH] build: Fix undefined 'LIBTOOL' error.

2024-06-01 Thread Collin Funk
Hi, When building from the main branch I see the following error: guile-readline/Makefile.am:47: error: Libtool library used but 'LIBTOOL' is undefined guile-readline/Makefile.am:47: The usual way to define 'LIBTOOL' is to add 'LT_INIT' guile-readline/Makefile.am:47: to 'configure.ac' and

Re: [PATCH] add SRFI-119 / language/wisp to Guile? (new patch with more tests, squashed)

2024-06-01 Thread Ludovic Courtès
Hi Arne, "Dr. Arne Babenhauserheide" skribis: > From 81e7cbbade4fd01e092a2c39a3af90e4abf7f684 Mon Sep 17 00:00:00 2001 > From: Arne Babenhauserheide > Date: Mon, 11 Mar 2024 06:34:52 +0100 > Subject: [PATCH] Add language/wisp, Wisp tests, and SRFI-119 documentation > > *

RE: [PATCH] Make get-bytevector-all suspendable.

2024-06-01 Thread Maxime Devos
Adding to my previous response: Most (all?) tests for suspendable/non-suspendable are shared, and run in both cases, so probably the suspendable get-bytevector-all already has tests.

RE: [PATCH] Make get-bytevector-all suspendable.

2024-06-01 Thread Maxime Devos
>Given that ‘get-bytevector-n!’ already has a variant in suspendable-ports.scm, my preference would be to rewrite ‘get-bytevector-all’ in Scheme (patch attached). That way, it would naturally be suspendable. (It’s also in line with the general strategy of moving things to Scheme.) It currently

Re: [PATCH] Make get-bytevector-all suspendable.

2024-06-01 Thread Ludovic Courtès
Hi Chris, Christopher Baines skribis: > I'm looking at this since it's used in (web response) > read-response-body. > > * module/ice-9/suspendable-ports.scm (get-bytevector-all): New > procedure. > (port-bindings): Add it. Given that ‘get-bytevector-n!’ already has a variant in