Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.

2024-04-12 Thread Denis 'GNUtoo' Carikli
Sorry again for the delay, I had personal issues (that are now mostly fixed) that needed urgent attention and that took all my time. On Fri, 05 Apr 2024 17:03:21 -0500 Rob Browning wrote: > Rob Browning writes: > > > Apologies for the delay, and good point. I should have used eqv? > > rather

Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.

2024-04-12 Thread Denis 'GNUtoo' Carikli
On Tue, 19 Mar 2024 19:21:19 -0500 Rob Browning wrote: > Denis 'GNUtoo' Carikli writes: > > > Would something like that be OK instead?: > > Not sure I understand the question. Were you asking if that'd be OK > elsewhere in the function too? I was just asking if my

[PATCH v2] SRFI-19: Add support for ISO 8601 zones with a colon.

2024-03-19 Thread Denis 'GNUtoo' Carikli
* module/srfi/srfi-19.scm (zone-reader): handle a colon in the zone. * test-suite/tests/srfi-19.test (SRFI date/time library test): Add test. Signed-off-by: Denis 'GNUtoo' Carikli --- ChangeLog v1->v2: - Improved error message to be more meaningful. - Removed duplicated code: in the

Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.

2024-03-19 Thread Denis 'GNUtoo' Carikli
On Mon, 11 Mar 2024 19:25:08 +0100 Denis 'GNUtoo' Carikli wrote: > Also note that I didn't test the code above yet. I tested the code afterward and it passes all the tests. I'll send a v2 in case that makes review easier. Denis. pgp3X68eFC1AE.pgp Description: OpenPGP digital signature

Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.

2024-03-11 Thread Denis 'GNUtoo' Carikli
Hi, Sorry for the delay, On Wed, 06 Mar 2024 12:42:10 -0600 Rob Browning wrote: > Denis 'GNUtoo' Carikli writes: > (...and (not related), I also wondered about making some of the error > messsages more specific, i.e. "Invalid time zone minutes digit" or > something.)

[PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.

2024-02-29 Thread Denis 'GNUtoo' Carikli
* module/srfi/srfi-19.scm (zone-reader): handle a colon in the zone. * test-suite/tests/srfi-19.test (SRFI date/time library test): Add test. Signed-off-by: Denis 'GNUtoo' Carikli --- module/srfi/srfi-19.scm | 5 + test-suite/tests/srfi-19.test | 3 +++ 2 files changed, 8 insertions