Re: [PATCH] primitive resolution for public refs

2012-04-09 Thread BT Templeton
l...@gnu.org (Ludovic Courtès) writes: Hi BT, The patch doesn’t apply currently on stable-2.0. Could you send an updated one, or apply it yourself? It was a patch for master. Committed to stable-2.0 in commit a8004dcb4d7148ec66cbaa109a18715d757700eb -- Inteligenta persono lernas la

Re: [PATCH] primitive resolution for public refs

2012-03-21 Thread Ludovic Courtès
Hi BT, The patch doesn’t apply currently on stable-2.0. Could you send an updated one, or apply it yourself? Thanks, Ludo’.

Re: [PATCH] primitive resolution for public refs

2012-03-16 Thread Ludovic Courtès
Hi BT, BT Templeton b...@hcoop.net skribis: * module/language/tree-il/primitives.scm (resolve-primitives!): Resolve public module-refs to primitives. What about resolving private module-refs too? Here’s the motivation: scheme@(guile-user) (use-modules(ice-9 match)) scheme@(guile-user)

Re: [PATCH] primitive resolution for public refs

2012-03-16 Thread BT Templeton
* module/language/tree-il/primitives.scm (resolve-primitives!): Resolve public module-refs to primitives. * test-suite/tests/tree-il.test: New tests for primitive resolution. --- module/language/tree-il/primitives.scm | 16 +--- test-suite/tests/tree-il.test | 10

[PATCH] primitive resolution for public refs

2012-03-12 Thread BT Templeton
* module/language/tree-il/primitives.scm (resolve-primitives!): Resolve public module-refs to primitives. --- module/language/tree-il/primitives.scm | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/module/language/tree-il/primitives.scm

Re: [PATCH] primitive resolution for public refs

2012-03-12 Thread Noah Lavine
Hello, Are you sure this is correct? What if someone calls the module-set! function on that module between the definition and use of whatever function you're compiling? I agree very strongly that we need to be able to do this sort of optimization, but I think we might need some sort of caching

Re: [PATCH] primitive resolution for public refs

2012-03-12 Thread BT Templeton
Noah Lavine noah.b.lav...@gmail.com writes: Hello, Are you sure this is correct? What if someone calls the module-set! function on that module between the definition and use of whatever function you're compiling? I agree very strongly that we need to be able to do this sort of

Re: [PATCH] primitive resolution for public refs

2012-03-12 Thread Noah Lavine
Hello, I don't think I've changed the correctness wrt `module-set!' and the like -- the current, private-refs-only optimization already exhibits the problem you describe: | scheme@(guile-user) (define old-car car) | scheme@(guile-user) (module-set! (current-module) I think (current-module)

Re: [PATCH] primitive resolution for public refs

2012-03-12 Thread BT Templeton
Noah Lavine noah.b.lav...@gmail.com writes: Hello, I don't think I've changed the correctness wrt `module-set!' and the like -- the current, private-refs-only optimization already exhibits the problem you describe: | scheme@(guile-user) (define old-car car) | scheme@(guile-user)