Hi Maxime,
Maxime Devos writes:
[...]
>>> I now see:
>>>
+ /* For compatibility with older load hooks procedures, fall-back to
+ calling it with a single argument if calling it with two fails. */
+ scm_internal_catch (scm_from_latin1_symbol ("wrong-number-of-args"),
+
Op 11-10-2023 om 04:36 schreef Maxim Cournoyer:
Onderwerp:
Re: [PATCH v4 4/4] load: Display modules depth in output when using
%load-verbosely.
Van:
Maxim Cournoyer
Datum:
11-10-2023 04:36
Aan:
Maxime Devos
CC:
guile-devel@gnu.org
Hi Maxime,
Maxime Devos writes:
[...]
I now see
Hi Maxime,
Maxime Devos writes:
[...]
> I now see:
>
>> + /* For compatibility with older load hooks procedures, fall-back to
>> + calling it with a single argument if calling it with two fails. */
>> + scm_internal_catch (scm_from_latin1_symbol ("wrong-number-of-args"),
>> +
Op 04-10-2023 om 03:42 schreef Maxim Cournoyer:
%load-hook is carefully crafted as to accept both one or two arguments
(for backward compatibility). I didn't pay attention to %load-announce
and I'm surprised it's a public API, as its sole function seems to be
the default %load-hook value.
Th
Hello!
Maxime Devos writes:
> Op 02-10-2023 om 18:13 schreef Maxim Cournoyer:
>>> Something I didn't notice previously:
>>>
>>> Op 25-09-2023 om 16:29 schreef Maxim Cournoyer:
+ if (scm_is_string (args)) {
+ /* C code written for 3.9 and earlier expects this function to
+
Op 02-10-2023 om 18:13 schreef Maxim Cournoyer:
Something I didn't notice previously:
Op 25-09-2023 om 16:29 schreef Maxim Cournoyer:
+ if (scm_is_string (args)) {
+ /* C code written for 3.9 and earlier expects this function to
+ take a single argument (the file name). */
+
Hi Maxime,
Maxime Devos writes:
> Something I didn't notice previously:
>
> Op 25-09-2023 om 16:29 schreef Maxim Cournoyer:
>> + if (scm_is_string (args)) {
>> + /* C code written for 3.9 and earlier expects this function to
>> + take a single argument (the file name). */
>> +
Something I didn't notice previously:
Op 25-09-2023 om 16:29 schreef Maxim Cournoyer:
+ if (scm_is_string (args)) {
+ /* C code written for 3.9 and earlier expects this function to
+ take a single argument (the file name). */
+ filename = args;
+ depth = scm_from_int(0);
* NEWS: Update news.
* THANKS: Add myself.
* doc/guile-api.alist (%load-announce, %load-hook): Add DEPTH argument.
* doc/ref/api-evaluation.texi (Loading): Document new
DEPTH argument for the primitive-load, primitive-load-path and
%load-hook procedures. Update %load-hook example. Document
%load-
