Re: Inlining `scm_getc ()' and friends

2008-04-17 Thread Ludovic Courtès
Hi Neil! Neil Jerram <[EMAIL PROTECTED]> writes: > But why not commit the benchmark code anyway? If there are some > benchmarks there worth running, the more incentive for someone (me?) > to clean up the framework code! You managed to make me change my mind and I just committed `read.bm'. ;-)

Re: Inlining `scm_getc ()' and friends

2008-04-16 Thread Neil Jerram
[EMAIL PROTECTED] (Ludovic Courtès) writes: > Neil Jerram <[EMAIL PROTECTED]> writes: > >> Would it also make sense to commit the benchmark? We already have a >> "benchmark-suite" directory. > > I had a quick look and it seems this directory would need a little bit > of cleanup (e.g., "#!../libgu

Re: Inlining `scm_getc ()' and friends

2008-04-16 Thread Ludovic Courtès
Hi, Neil Jerram <[EMAIL PROTECTED]> writes: > Yes, all looks good to me. Thanks, applied. > Would it also make sense to commit the benchmark? We already have a > "benchmark-suite" directory. I had a quick look and it seems this directory would need a little bit of cleanup (e.g., "#!../libguil

Re: Inlining `scm_getc ()' and friends

2008-04-15 Thread Neil Jerram
[EMAIL PROTECTED] (Ludovic Courtès) writes: > Hello, > > Small I/O functions like `scm_getc ()' deserve to be inlined. For > instance, Andy measured it some time ago: > > http://thread.gmane.org/gmane.lisp.guile.devel/6639 > > I'm planning to apply the attached patch to both `master' and 1.8. >

Inlining `scm_getc ()' and friends

2008-04-14 Thread Ludovic Courtès
Hello, Small I/O functions like `scm_getc ()' deserve to be inlined. For instance, Andy measured it some time ago: http://thread.gmane.org/gmane.lisp.guile.devel/6639 I'm planning to apply the attached patch to both `master' and 1.8. To get an idea of its benefit, I run the attached "benchma