Re: Sputnik test result

2011-01-27 Thread Andy Wingo
Hi Kan-Ru, On Tue 04 Jan 2011 10:23, Kan-Ru Chen ka...@kanru.info writes: I ran the sputniktests[1] from google using the attached guile-es-parse script, which only tests the parser. === Summary === - Ran 5246 tests - Passed 4410 tests (84.1%) - Failed 836 tests (15.9%)

Re: Sputnik test result

2011-01-27 Thread Noah Lavine
Hi all, When I was looking at this a while ago, it looked like a big issue (possibly *the* big issue) with Guile's parser is that it doesn't do automatic semicolon insertion. (In Javascript, semicolons are optional in certain contexts, when the place where the semicolon would be is followed by a

Re: Sputnik test result

2011-01-27 Thread Kan-Ru Chen
Noah Lavine noah.b.lav...@gmail.com writes: Hi all, When I was looking at this a while ago, it looked like a big issue (possibly *the* big issue) with Guile's parser is that it doesn't do automatic semicolon insertion. (In Javascript, semicolons are optional in certain contexts, when the

Re: Sputnik test result (was Re: ECMAScript support broken?)

2011-01-26 Thread Ludovic Courtès
Hi, l...@gnu.org (Ludovic Courtès) writes: Noah Lavine noah.b.lav...@gmail.com writes: The attached patch should add support for ECMAScript unicode literals. I applied this one, along with corresponding test cases. Can you please resubmit the remaining patches with test case(s) for each,

Re: Sputnik test result (was Re: ECMAScript support broken?)

2011-01-26 Thread Noah Lavine
Hi, I finally applied them and wrote the test cases by myself. Thanks a lot! Thanks again for the patches, but please do write test cases next time. I will do that. Sorry for the delay - I've been quite busy lately, and basically all of my Guile mail has been sitting in my inbox waiting to

Re: Sputnik test result (was Re: ECMAScript support broken?)

2011-01-17 Thread Ludovic Courtès
Hi, Thanks for looking into this! Noah Lavine noah.b.lav...@gmail.com writes: The attached patch should add support for ECMAScript unicode literals. I applied this one, along with corresponding test cases. Can you please resubmit the remaining patches with test case(s) for each, and each in

Re: Sputnik test result (was Re: ECMAScript support broken?)

2011-01-11 Thread Noah Lavine
Hello, The attached patch should add support for ECMAScript unicode literals. Noah On Tue, Jan 4, 2011 at 4:23 AM, Kan-Ru Chen ka...@kanru.info wrote: Hi, Noah Lavine noah.b.lav...@gmail.com writes: If you mean give guile a '.js' file have it interpret that with ecmascript, then I think

Re: Sputnik test result (was Re: ECMAScript support broken?)

2011-01-11 Thread Noah Lavine
And this fixes an error that came because Unicode 00A0 (no-break space) is supposed to be considered whitespace in ECMAScript. Noah On Tue, Jan 11, 2011 at 5:33 PM, Noah Lavine noah.b.lav...@gmail.com wrote: This patch fixes a lot of the unexpected token: rbrace errors that had been messing up

Re: Sputnik test result (was Re: ECMAScript support broken?)

2011-01-11 Thread Noah Lavine
And this fixes hexadecimal constants. Guile now parses all Sputnik tests for numeric literals. Noah On Tue, Jan 11, 2011 at 5:59 PM, Noah Lavine noah.b.lav...@gmail.com wrote: This parses decimal numbers with leading zeros correctly. Noah On Tue, Jan 11, 2011 at 5:45 PM, Noah Lavine