Re: branch master updated: licenses: Export license record.

2020-04-27 Thread zimoun
Hey Ludo, On Sun, 26 Apr 2020 at 22:19, Ludovic Courtès wrote: > >> Perhaps this suggests we should document it, maybe in the “Coding Style” > >> section? WDYT? > > I was really thinking about this pattern of not always exposing raw > record constructors or record type descriptors. You mean ad

Re: branch master updated: licenses: Export license record.

2020-04-26 Thread Ludovic Courtès
Hi, zimoun skribis: >> Perhaps this suggests we should document it, maybe in the “Coding Style” >> section? WDYT? I was really thinking about this pattern of not always exposing raw record constructors or record type descriptors. > I have read the Channel section again. Maybe there in the big

Re: branch master updated: licenses: Export license record.

2020-04-26 Thread zimoun
Hi Ludo, On Sun, 26 Apr 2020 at 16:28, Ludovic Courtès wrote: > It’s not particularly “touchy”. It’s just that there was a reason for > it and I found it important to state it because it’s a fairly widespread > programming pattern throughout. I understand. > Perhaps this suggests we should d

Re: branch master updated: licenses: Export license record.

2020-04-26 Thread Ludovic Courtès
Hi Simon, zimoun skribis: > On Thu, 23 Apr 2020 at 23:47, Ludovic Courtès wrote: >> zimoun skribis: [...] >> >> I’m in favor of reverting. > > Sorry, I did not think that the subject was so touchy. :-) It’s not particularly “touchy”. It’s just that there was a reason for it and I found it

Re: branch master updated: licenses: Export license record.

2020-04-26 Thread Ludovic Courtès
Hi, Mathieu Othacehe skribis: >> 2. It’s on purpose that the constructor is not exported. It’s so that >> genuine license objects have to be defined here. (Likewise, record >> type descriptors like are generally kept private to >> maintain encapsulation.) >> >> I’m in favor o

Re: branch master updated: licenses: Export license record.

2020-04-24 Thread Mathieu Othacehe
Hey! > 2. It’s on purpose that the constructor is not exported. It’s so that > genuine license objects have to be defined here. (Likewise, record > type descriptors like are generally kept private to > maintain encapsulation.) > > I’m in favor of reverting. I went to fast on

Re: branch master updated: licenses: Export license record.

2020-04-23 Thread zimoun
On Thu, 23 Apr 2020 at 23:47, Ludovic Courtès wrote: > zimoun skribis: > > On Thu, 23 Apr 2020 at 21:57, Ludovic Courtès wrote: > > > >> guix-commits@gnu.org skribis: > >> > >> > commit f0779922ff260df2404c90504986aa59553154fb > >> > Author: zimoun > >> > AuthorDate: Thu Apr 23 16:09:00 2020 +0

Re: branch master updated: licenses: Export license record.

2020-04-23 Thread Ludovic Courtès
Hi, zimoun skribis: > On Thu, 23 Apr 2020 at 21:57, Ludovic Courtès wrote: > >> guix-commits@gnu.org skribis: >> >> > commit f0779922ff260df2404c90504986aa59553154fb >> > Author: zimoun >> > AuthorDate: Thu Apr 23 16:09:00 2020 +0200 >> > >> > licenses: Export license record. >> > >> >

Re: branch master updated: licenses: Export license record.

2020-04-23 Thread zimoun
On Thu, 23 Apr 2020 at 21:57, Ludovic Courtès wrote: > guix-commits@gnu.org skribis: > > > commit f0779922ff260df2404c90504986aa59553154fb > > Author: zimoun > > AuthorDate: Thu Apr 23 16:09:00 2020 +0200 > > > > licenses: Export license record. > > > > * guix/licenses.scm (): Export it.

Re: branch master updated: licenses: Export license record.

2020-04-23 Thread Ludovic Courtès
Hi! guix-commits@gnu.org skribis: > commit f0779922ff260df2404c90504986aa59553154fb > Author: zimoun > AuthorDate: Thu Apr 23 16:09:00 2020 +0200 > > licenses: Export license record. > > * guix/licenses.scm (): Export it. > > Signed-off-by: Mathieu Othacehe > - #:export

branch master updated: licenses: Export license record.

2020-04-23 Thread guix-commits
This is an automated email from the git hooks/post-receive script. mothacehe pushed a commit to branch master in repository guix. The following commit(s) were added to refs/heads/master by this push: new f077992 licenses: Export license record. f077992 is described below commit f0779922ff2