Re: [PATCH] Add MAFFT.

2015-07-26 Thread Andreas Enge
On Sun, Jul 26, 2015 at 11:43:38AM +0200, Andreas Enge wrote: I would use a snippet for something internal to Guix, or specific to the way we handle things, while a patch is intended to be passed upstream (or sometimes taken from upstream already) to correct a bug in the software. Well, I am

[PATCH] gnu: Add GVFS.

2015-07-26 Thread 宋文武
* gnu/packages/gnome.scm (gvfs): New variable. --- gnu/packages/gnome.scm | 55 ++ 1 file changed, 55 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 0feb5b4..d44cb80 100644 --- a/gnu/packages/gnome.scm +++

Re: [PATCH 08/12] gnu: Add python-mistune.

2015-07-26 Thread Andreas Enge
On Sun, Jul 26, 2015 at 12:08:25PM +0200, Andreas Enge wrote: On Fri, Jul 24, 2015 at 04:18:20PM +0200, Federico Beffa wrote: +(inputs + `((python-setuptools ,python-setuptools) + (python-nose ,python-nose) + (python-cython ,python-cython))) Should these not be

Re: [PATCH 4/7] emacs: Add 'guix-devel-use-current-module'.

2015-07-26 Thread Alex Kost
Mathieu Lirzin (2015-07-25 21:51 +0300) wrote: Alex Kost alez...@gmail.com writes: * emacs/guix-guile.el (guix-guile-current-module): New function. * emacs/guix-devel.el: New file. (guix-devel-use-modules, guix-devel-use-current-module): New functions. * doc/emacs.texi (Emacs

Re: guix-config.el ?

2015-07-26 Thread Mathieu Lirzin
Alex Kost alez...@gmail.com writes: Following the discussion for bug#21127 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21127, I was asking myself if it would be possible and/or desirable to have an equivalent of config.scm for the Emacs interface, in order to avoid having multiple *.el.in

Re: [PATCH] Add MAFFT.

2015-07-26 Thread Andreas Enge
On Sun, Jul 26, 2015 at 01:10:14PM +1000, Ben Woodcroft wrote: I'm actually a bit confused as to the difference between a snippet vs. a patch stage as above - when is each appropriate? Snippets are only for removing non-free software? I would use a snippet for something internal to Guix, or

Re: [PATCH] Add MAFFT.

2015-07-26 Thread Ricardo Wurmus
Andreas Enge andr...@enge.fr writes: On Sun, Jul 26, 2015 at 01:10:14PM +1000, Ben Woodcroft wrote: I'm actually a bit confused as to the difference between a snippet vs. a patch stage as above - when is each appropriate? Snippets are only for removing non-free software? I would use a

Re: [PATCH 4/7] emacs: Add 'guix-devel-use-current-module'.

2015-07-26 Thread Mathieu Lirzin
Alex Kost alez...@gmail.com writes: Mathieu Lirzin (2015-07-25 21:51 +0300) wrote: What do you think about integrating it in section Contributing instead? Maybe, I don't have a preference here. Since it's not really related to package management, I think it would be preferable to move this

Re: [PATCH 08/12] gnu: Add python-mistune.

2015-07-26 Thread Andreas Enge
On Fri, Jul 24, 2015 at 04:18:20PM +0200, Federico Beffa wrote: +(inputs + `((python-setuptools ,python-setuptools) + (python-nose ,python-nose) + (python-cython ,python-cython))) Should these not be native-inputs? +(description A fast markdown parser in pure

Re: [PATCH 01/12] gnu: Add fastcap.

2015-07-26 Thread Andreas Enge
On Fri, Jul 24, 2015 at 04:17:39PM +0200, Federico Beffa wrote: The function 'broken-tarball-fetch' was provided by Ludovic on IRC. I'm not 100% sure about the license. +(license license:bsd-3))) If you compare the license texts, it is not bsd-3, but inspired from it; I would use

Re: Qtwebengine

2015-07-26 Thread Andreas Enge
Attached is the patch. Vlc still compiles with the new qt. Liblxqt does not; we might need to add qt 5.4 again as a separate package. Hydra should tell us if there is more damage... Andreas From 544976bc995182440ab07f6e02dbc4deb6a3f320 Mon Sep 17 00:00:00 2001 From: Andreas Enge andr...@enge.fr

gpl3 vs. gpl3+

2015-07-26 Thread Alex Kost
I see that only several packages uses 'gpl3' license. And I don't really understand the cases when it should be used instead of 'gpl3+'. I looked at aarddict and weechat. They have the same COPYING/LICENSE files as http://www.gnu.org/licenses/gpl.txt. So it should be gpl3+, right? Then I

Re: [PATCH] gnu: Add GVFS.

2015-07-26 Thread Mark H Weaver
宋文武 iyzs...@gmail.com writes: * gnu/packages/gnome.scm (gvfs): New variable. Looks good to me, please push! Thanks, Mark

Re: [PATCH 4/7] emacs: Add 'guix-devel-use-current-module'.

2015-07-26 Thread Alex Kost
Mathieu Lirzin (2015-07-26 17:00 +0300) wrote: Alex Kost alez...@gmail.com writes: Mathieu Lirzin (2015-07-25 21:51 +0300) wrote: What do you think about integrating it in section Contributing instead? Maybe, I don't have a preference here. Since it's not really related to package

Re: gpl3 vs. gpl3+

2015-07-26 Thread Alex Kost
Mark H Weaver (2015-07-26 18:54 +0300) wrote: Alex Kost alez...@gmail.com writes: I see that only several packages uses 'gpl3' license. And I don't really understand the cases when it should be used instead of 'gpl3+'. I looked at aarddict and weechat. They have the same COPYING/LICENSE

Re: Qtwebengine

2015-07-26 Thread Mark H Weaver
宋文武 iyzs...@gmail.com writes: +1 for remove qtwebengine. Agreed. (I tried to split Qt into submodules, but it seems to require a lot of effort which I couldn't give now :-( ) On that subject: I vaguely recall you saying that the system 'pcre' couldn't be used by Qt before because it wasn't

Qtwebengine

2015-07-26 Thread Andreas Enge
Hello, I am trying to update Qt to 5.5.0. Unfortunately, it does not compile; there are error messages such as ../../../src/3rdparty/chromium/ui/gfx/codec/jpeg_codec.cc: In function ‘boolean gfx:: {anonymous}::FillInputBuffer(j_decompress_ptr)’:

Re: [PATCH] python2-ansible, python-ccm and dependencies

2015-07-26 Thread Alex Kost
Eric Dvorsak (2015-07-25 22:58 +0300) wrote: Thank you Ricardo and Alex for taking the time to review and comment my patch. I edited it to take your advices into account. I hope I did not miss anything this time Please add the following line to python.scm: ;;; Copyright © 2015 Eric Dvorsak

Re: [PATCH] python2-ansible, python-ccm and dependencies

2015-07-26 Thread Eric Dvorsak
Ok I have made all the changes you recommended. Thank you for your help. 2015-07-26 11:56 GMT+02:00 Alex Kost alez...@gmail.com: Eric Dvorsak (2015-07-25 22:58 +0300) wrote: Thank you Ricardo and Alex for taking the time to review and comment my patch. I edited it to take your advices into

Re: Qtwebengine

2015-07-26 Thread 宋文武
Andreas Enge andr...@enge.fr writes: Attached is the patch. Vlc still compiles with the new qt. Liblxqt does not; we might need to add qt 5.4 again as a separate package. Hydra should tell us if there is more damage... Andreas From 544976bc995182440ab07f6e02dbc4deb6a3f320 Mon Sep 17

Re: gpl3 vs. gpl3+

2015-07-26 Thread Mark H Weaver
Alex Kost alez...@gmail.com writes: I see that only several packages uses 'gpl3' license. And I don't really understand the cases when it should be used instead of 'gpl3+'. I looked at aarddict and weechat. They have the same COPYING/LICENSE files as http://www.gnu.org/licenses/gpl.txt.

Re: [PATCH 3/3] gnu: Add python-pelican

2015-07-26 Thread Thompson, David
On Mon, Jul 20, 2015 at 9:22 PM, Christopher Allan Webber cweb...@dustycloud.org wrote: Ludovic Courtès writes: Could you send an updated patch? TIA, Ludo’. Done! And thank you! Looks good! I made some minor changes and pushed. Thanks! - Dave

Re: [PATCH 2/3] gnu: Add python-blinker

2015-07-26 Thread Thompson, David
On Mon, Jul 20, 2015 at 9:21 PM, Christopher Allan Webber cweb...@dustycloud.org wrote: Ludovic Courtès writes: Could you send an updated patch? Yep, below! Pushed, thanks! - Dave