Re: [PATCH] Add 12 rubygems.

On 08/01/16 00:29, Ricardo Wurmus wrote: Here’s the review for the other 11 patches, Thanks for all this Ricardo, all pushed now. ben

Re: Qt-5 in core-updates

Andreas Enge writes: > Thanks, 宋文武, for this thorough research! > > On Mon, Jan 25, 2016 at 09:57:13AM +0800, 宋文武 wrote: >> - Patch our python-2.7.x like Ubuntu does. >> >> > > To me, this sounds like th

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

Mathieu Lirzin (2016-01-26 00:41 +0300) wrote: > "Thompson, David" writes: > >> Does the fact that so many files needed to be edited indicate the need >> for a single specification string constructor? If this had already >> been the case, then this patch would have only needed to change 1 or 2 >

Re: [PATCH 7/8] utils: Rename 'dmd-gettext.scm' to 'shepherd-gettext.scm'.

Alex Kost skribis: > Ludovic Courtès (2016-01-25 18:12 +0300) wrote: > >> Alex Kost skribis: >> >>> * utils/dmd-gettext.scm: Rename to... >>> * utils/shepherd-gettext.scm: ... this. >>> * utils/Makefile.am (EXTRA_DIST): Use it. >> >> Actually let’s remove it instead. When we add i18n support, w

Re: [SHEPHERD] [PATCH] service: Improve 'service-list'.

Alex Kost skribis: > Ludovic Courtès (2016-01-25 18:06 +0300) wrote: > >> Alex Kost skribis: >> >>> From f3d21e3ec8a100a966153d03264639ebe48e8872 Mon Sep 17 00:00:00 2001 >>> From: Alex Kost >>> Date: Mon, 25 Jan 2016 11:18:00 +0300 >>> Subject: [PATCH] service: Improve 'service-list'. >>> >>>

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

"Thompson, David" writes: > Does the fact that so many files needed to be edited indicate the need > for a single specification string constructor? If this had already > been the case, then this patch would have only needed to change 1 or 2 > procedures. I don't know if such string constructor

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

Alex Kost writes: > Tremendous work! How did you manage to find all these occurrences? Thank you. In fact I haven't followed any methodic step. I have started editing the heart of the thing (meaning 'package-name->name+version') then look where it was used. adapt the code/docstring and so on.

Re: [PATCH 6/8] support: Rename state file.

On Mon, 25 Jan 2016 21:26:47 +0200 Efraim Flashner wrote: > On Mon, 25 Jan 2016 13:50:19 +0300 > Alex Kost wrote: > > [...] > ^ > --| > > it's a comment, but it's still for dmd > nevermind, just saw patch 8 -- Efraim Flas

Re: [PATCH 6/8] support: Rename state file.

On Mon, 25 Jan 2016 13:50:19 +0300 Alex Kost wrote: > * modules/shepherd/support.scm (default-persistency-state-file): Use > "shepherd" instead of "dmd". > --- > modules/shepherd/support.scm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/modules/shepherd/support.

Re: [PATCH 3/7] emacs: Add 'guix-browse-license-url' command.

Ludovic Courtès (2016-01-23 20:13 +0300) wrote: > Alex Kost skribis: > >> * emacs/guix-main.scm (license-names, license-name->license) >> (license-name->uri): New procedures. >> * emacs/guix-read.el (guix-license-names, guix-read-license-name): New >> procedures. >> * emacs/guix-license.el: N

[PATCH] gnu/packages/linux iptables: include firewall in description

This is a patch to include "firewall" in the description of iptables, as it does not turn up with a search for "firewall" which might not be so intuitive for GNU beginners. I did not want to change the complete description (yet), I am open to suggestions if this short addition is not accurate. The

Re: Qt-5 in core-updates

Thanks, 宋文武, for this thorough research! On Mon, Jan 25, 2016 at 09:57:13AM +0800, 宋文武 wrote: > - Patch our python-2.7.x like Ubuntu does. > > To me, this sounds like the cleanest solution, but probably

Re: [PATCH 8/8] Replace "dmd" with "shepherd" in comments and strings.

Ludovic Courtès (2016-01-25 18:13 +0300) wrote: > Alex Kost skribis: > >> * modules/shepherd/support.scm: Use "shepherd" instead of "dmd" >> everywhere. >> * configure.ac: Likewise. >> * tests/no-home.sh: Likewise. >> * tests/sigint.sh: Likewise. > > OK! > > I think you closed most of the TODO

Re: [SHEPHERD] [PATCH] service: Improve 'service-list'.

Ludovic Courtès (2016-01-25 18:06 +0300) wrote: > Alex Kost skribis: > >> From f3d21e3ec8a100a966153d03264639ebe48e8872 Mon Sep 17 00:00:00 2001 >> From: Alex Kost >> Date: Mon, 25 Jan 2016 11:18:00 +0300 >> Subject: [PATCH] service: Improve 'service-list'. >> >> * modules/shepherd/service.scm (

Re: [PATCH 7/8] utils: Rename 'dmd-gettext.scm' to 'shepherd-gettext.scm'.

Ludovic Courtès (2016-01-25 18:12 +0300) wrote: > Alex Kost skribis: > >> * utils/dmd-gettext.scm: Rename to... >> * utils/shepherd-gettext.scm: ... this. >> * utils/Makefile.am (EXTRA_DIST): Use it. > > Actually let’s remove it instead. When we add i18n support, we’ll use > xgettext, which know

Re: [PATCH 8/8] Replace "dmd" with "shepherd" in comments and strings.

Alex Kost skribis: > * modules/shepherd/support.scm: Use "shepherd" instead of "dmd" > everywhere. > * configure.ac: Likewise. > * tests/no-home.sh: Likewise. > * tests/sigint.sh: Likewise. OK! I think you closed most of the TODO items for the release. :-) So I would like to try it in GuixS

Re: [PATCH 7/8] utils: Rename 'dmd-gettext.scm' to 'shepherd-gettext.scm'.

Alex Kost skribis: > * utils/dmd-gettext.scm: Rename to... > * utils/shepherd-gettext.scm: ... this. > * utils/Makefile.am (EXTRA_DIST): Use it. Actually let’s remove it instead. When we add i18n support, we’ll use xgettext, which knows how to extract strings from Scheme code nowadays (which pr

Re: [PATCH 6/8] support: Rename state file.

Alex Kost skribis: > * modules/shepherd/support.scm (default-persistency-state-file): Use > "shepherd" instead of "dmd". [..] > diff --git a/modules/shepherd/support.scm b/modules/shepherd/support.scm > index f161056..aae8b3c 100644 > --- a/modules/shepherd/support.scm > +++ b/modules/shepher

Re: [PATCH 5/8] Rename default system configuration file.

Alex Kost skribis: > * modules/shepherd/support.scm (default-config-file): Rename > "dmdconf.scm" to "shepherd.conf.scm". > * shepherd.texi (Jump Start): Likewise. OK!

Re: [PATCH 4/8] support: Rename 'make-dmd-user-module' to 'make-user-module'.

Alex Kost skribis: > * modules/shepherd/support.scm (make-dmd-user-module): Rename to... > (make-user-module): ... this. > (load-in-user-module): Adjust accordingly. OK.

Re: [PATCH 3/8] ChangeLog: Rename git repository.

Alex Kost skribis: > * ChangeLog: Use shepherd source. OK.

Re: [PATCH 1/8] tests: misbehaved-client: Rename 'dmd' to 'root'.

Alex Kost skribis: > This is a followup to commit cddf6a5aed5c66f91b93a84afa4b5dadde743b13. > > * tests/misbehaved-client.sh: Use 'root' service name instead of 'dmd'. OK!

Re: [PATCH 2/8] tests: Rename 'dmd_pid' to 'shepherd_pid'.

Alex Kost skribis: > * tests/basic.sh: Rename 'dmd_pid' to 'shepherd_pid'. > * tests/misbehaved-client.sh: Likewise. > * tests/no-home.sh: Likewise. > * tests/respawn.sh: Likewise. > * tests/status-sexp.sh: Likewise. OK!

Re: [SHEPHERD] [PATCH] service: Improve 'service-list'.

Alex Kost skribis: > From f3d21e3ec8a100a966153d03264639ebe48e8872 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Mon, 25 Jan 2016 11:18:00 +0300 > Subject: [PATCH] service: Improve 'service-list'. > > * modules/shepherd/service.scm (service-list): Use > 'lookup-canonical-service' on each

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

On Sun, Jan 24, 2016 at 3:19 PM, Mathieu Lirzin wrote: > > Fixes . > > * guix/build/utils.scm (package-name->name+version): Use '@' for > separating package names and version numbers instead of '-'. This > provides the ability to use numbers in package names. > * guix/p

Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.

Mathieu Lirzin (2016-01-24 23:19 +0300) wrote: > Fixes . > > * guix/build/utils.scm (package-name->name+version): Use '@' for > separating package names and version numbers instead of '-'. This > provides the ability to use numbers in package names. > * guix/packages.sc

[PATCH 5/8] Rename default system configuration file.

* modules/shepherd/support.scm (default-config-file): Rename "dmdconf.scm" to "shepherd.conf.scm". * shepherd.texi (Jump Start): Likewise. --- modules/shepherd/support.scm | 2 +- shepherd.texi| 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/shep

[PATCH 3/8] ChangeLog: Rename git repository.

* ChangeLog: Use shepherd source. --- ChangeLog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 00c3b92..bddfc54 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,4 @@ Normally a ChangeLog is generated at "make dist" time and available in source ta

[PATCH 8/8] Replace "dmd" with "shepherd" in comments and strings.

* modules/shepherd/support.scm: Use "shepherd" instead of "dmd" everywhere. * configure.ac: Likewise. * tests/no-home.sh: Likewise. * tests/sigint.sh: Likewise. --- configure.ac | 2 +- modules/shepherd/support.scm | 16 tests/no-home.sh | 2 +- tes

[PATCH 4/8] support: Rename 'make-dmd-user-module' to 'make-user-module'.

* modules/shepherd/support.scm (make-dmd-user-module): Rename to... (make-user-module): ... this. (load-in-user-module): Adjust accordingly. --- modules/shepherd/support.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/shepherd/support.scm b/modules/shepherd/supp

[PATCH 1/8] tests: misbehaved-client: Rename 'dmd' to 'root'.

This is a followup to commit cddf6a5aed5c66f91b93a84afa4b5dadde743b13. * tests/misbehaved-client.sh: Use 'root' service name instead of 'dmd'. --- tests/misbehaved-client.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/misbehaved-client.sh b/tests/misbehaved-client.sh

[SHEPHERD] [PATCH 0/8]: More dmd -> shepherd patches.

Hello, this is another patchset for moving away from "dmd" name. AFAICT the only files where deco/dmd still present (except NEWS and ANNOUNCE--*) are: THANKS, QUESTIONS and "examples" directory. I don't know whether these files should be modified or not. Patches: [PATCH 1/8] tests: misbehaved-c

[PATCH 7/8] utils: Rename 'dmd-gettext.scm' to 'shepherd-gettext.scm'.

* utils/dmd-gettext.scm: Rename to... * utils/shepherd-gettext.scm: ... this. * utils/Makefile.am (EXTRA_DIST): Use it. --- utils/Makefile.am | 2 +- utils/dmd-gettext.scm | 61 -- utils/shepherd-gettext.scm | 61 ++

[PATCH 6/8] support: Rename state file.

* modules/shepherd/support.scm (default-persistency-state-file): Use "shepherd" instead of "dmd". --- modules/shepherd/support.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/shepherd/support.scm b/modules/shepherd/support.scm index f161056..aae8b3c 100644 ---

[PATCH 2/8] tests: Rename 'dmd_pid' to 'shepherd_pid'.

* tests/basic.sh: Rename 'dmd_pid' to 'shepherd_pid'. * tests/misbehaved-client.sh: Likewise. * tests/no-home.sh: Likewise. * tests/respawn.sh: Likewise. * tests/status-sexp.sh: Likewise. --- tests/basic.sh | 10 +- tests/misbehaved-client.sh | 2 +- tests/no-home.sh

Re: 2 patches

On Fri, 22 Jan 2016 15:25:43 -0500 Leo Famulari wrote: > On Thu, Jan 21, 2016 at 10:53:56AM +0200, Efraim Flashner wrote: > > I've been holding on to these for a bit, waiting to integrate them before > > submitting them. > > > > cmocka: This is supposed to be used by mpv for running the tests, b

Re: Qt-5 in core-updates

iyzs...@member.fsf.org (宋文武) skribis: > Andreas Enge writes: > >> Hello, >> >> qt-5 fails to build on both x86_64 and armhf in core-updates with the >> following error: >> Traceback (most recent call last): >> File >> "/tmp/nix-build-qt-5.5.1.drv-0/qt-everywhere-opensource-src-5.5.1/qtwebkit/S

Re: [PATCH 5/5] Rename 'dmd' service to 'root'.

Alex Kost (2016-01-24 18:33 +0300) wrote: > * modules/shepherd/service.scm (dmd-service): Rename to... > (shepherd-service): ... this. Provide both 'root' and 'shepherd' names. > Adjust the rest file accordingly. > * modules/shepherd.scm: Likewise. > * modules/herd.scm: Likewise. > * modules/halt

Re: [PATCH]: Add pixz.

On 25/01/16 18:22, Ricardo Wurmus wrote: Looks good to me. Thank you. Really? That's the first time you've had no comments I think. Excellent, and thanks. Pushed just now.

Re: [SHEPHERD] [PATCH] service: Improve 'service-list'.

Ludovic Courtès (2016-01-25 00:20 +0300) wrote: > Alex Kost skribis: [...] >> [PATCH 1/5] service: Rename 'services' variable to '%services'. >> [PATCH 2/5] service: Improve style of 'for-each-service'. >> >> [PATCH 3/5] service: 'service-list' returns unique services. >> >> Without this change,

Re: [PATCH]: Add pixz.

Looks good to me. Thank you. (I also checked the license. The FreeBSD/BSD-2 license is explicitly mentioned in the man page, and the text of the license is part of the repository. This should be okay, even though the source files themselves do not have license headers.) ~~ Ricardo