Re: [PATCH] gnu: Move gtkglext from gnome to gtk.

2016-08-16 Thread Ricardo Wurmus
Leo Famulari writes: > On Wed, Aug 17, 2016 at 01:12:07AM +0200, Danny Milosavljevic wrote: >> I'll send a patch. We can think of what we want to do with it - but at least >> we can see the extent then. > > Oh, I see you already sent it. You'd also need to be sure to move the > copyright author

Re: Hardening

2016-08-16 Thread Ricardo Wurmus
Leo Famulari writes: > On Wed, Dec 30, 2015 at 05:06:30PM +0100, Ludovic Courtès wrote: >> Alex Vong skribis: >> > Yes, I grep for `fstack-protector-strong' in the guix code base and no >> > matches are found. It appears no packages are setting this flag >> > currently. I think this flag (perha

Re: [PATCH 2/2] gnu: Add python-kivy

2016-08-16 Thread Mark H Weaver
Dylan Jeffers writes: > Alright I think this is the final patch :) > > From c6f8d8948c0bf0b740022f5e4860c6adca267431 Mon Sep 17 00:00:00 2001 > From: Dylan Jeffers > Date: Sat, 13 Aug 2016 13:22:49 -0700 > Subject: [PATCH] gnu: Add python-kivy. > > * gnu/packages/python.scm (python-kivy, python

Re: Maven

2016-08-16 Thread Ricardo Wurmus
Danny Milosavljevic writes: > I also tried to package the Arduino GUI - but it has lots of Apache > Commons dependencies and those use the Maven repo system. > > Has anyone already packaged Apache Commons libraries? I have not, but the few Java packages I contributed were added because they are

Re: [PATCH 5/5] gnu: Add arduino-makefile.

2016-08-16 Thread Eric Bavier
On Tue, 16 Aug 2016 20:36:32 +0200 Danny Milosavljevic wrote: > * gnu/packages/arduino.scm (arduino-makefile): New variable. > --- > gnu/packages/arduino.scm | 83 > > 1 file changed, 83 insertions(+) > > diff --git a/gnu/packages/arduino.scm b

Re: [PATCH] gnu: Add dlib.

2016-08-16 Thread Ben Woodcroft
On 17/08/16 13:24, Ben Woodcroft wrote: On 17/08/16 09:45, Leo Famulari wrote: On Wed, Aug 17, 2016 at 09:31:11AM +1000, Ben Woodcroft wrote: On 17/08/16 06:47, Leo Famulari wrote: On Tue, Aug 16, 2016 at 11:45:16AM +0100, Marius Bakke wrote: I initially made this package on a foreign di

Re: [PATCH 1/1] gnu: cracklib: Fix CVE-2016-6318.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 11:29:11PM -0500, Eric Bavier wrote: > On Tue, 16 Aug 2016 22:49:55 -0400 > Leo Famulari wrote: > > > * gnu/packages/patches/cracklib-CVE-2016-6318.patch: New file. > > * gnu/local.mk (dist_patch_DATA): Add it. > > * gnu/packages/password-utils.scm (cracklib)[source]: Use

Re: [PATCH 1/1] gnu: cracklib: Fix CVE-2016-6318.

2016-08-16 Thread Eric Bavier
On Tue, 16 Aug 2016 22:49:55 -0400 Leo Famulari wrote: > * gnu/packages/patches/cracklib-CVE-2016-6318.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/password-utils.scm (cracklib)[source]: Use the patch. > --- > gnu/local.mk |

Re: [PATCH] gnu: Add dlib.

2016-08-16 Thread Ben Woodcroft
On 17/08/16 09:45, Leo Famulari wrote: On Wed, Aug 17, 2016 at 09:31:11AM +1000, Ben Woodcroft wrote: On 17/08/16 06:47, Leo Famulari wrote: On Tue, Aug 16, 2016 at 11:45:16AM +0100, Marius Bakke wrote: I initially made this package on a foreign distro without "lapack" in inputs and have ve

Re: [PATCH 2/2] gnu: tcsh: Update to 6.19.00.

2016-08-16 Thread Leo Famulari
On Wed, Aug 17, 2016 at 01:50:28AM +0200, Tobias Geerinckx-Rice wrote: > On 07/08/16 04:18, Leo Famulari wrote: > > Btw, what do others think about updating this on master? `guix > > refresh -l` reports 309 rebuilds. > > OK, what I thought was an obvious leaf package turns out not to be. I > didn'

[PATCH 1/1] gnu: cracklib: Fix CVE-2016-6318.

2016-08-16 Thread Leo Famulari
* gnu/packages/patches/cracklib-CVE-2016-6318.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/password-utils.scm (cracklib)[source]: Use the patch. --- gnu/local.mk | 1 + gnu/packages/password-utils.scm | 2 + gnu/

[PATCH 0/1] Cracklib security CVE-2016-6318

2016-08-16 Thread Leo Famulari
A stack overflow in Cracklib that could potentially lead to arbitrary code execution was just disclosed: http://seclists.org/oss-sec/2016/q3/290 "When an application compiled against the cracklib libary, such as "passwd" is used to parse the GECOS field, it could cause the application to crash or

Re: Hardening

2016-08-16 Thread Leo Famulari
On Wed, Dec 30, 2015 at 05:06:30PM +0100, Ludovic Courtès wrote: > Alex Vong skribis: > > Yes, I grep for `fstack-protector-strong' in the guix code base and no > > matches are found. It appears no packages are setting this flag > > currently. I think this flag (perhaps also a couple others) shoul

Re: [PATCH 2/2] gnu: tcsh: Update to 6.19.00.

2016-08-16 Thread Tobias Geerinckx-Rice
Leo, On 07/08/16 04:18, Leo Famulari wrote: > It is possible to test 32-bit i686 from x86_64 with `guix build > --system=i686-linux tcsh`. I only do this for critical packages, > however, unless I happen to have the i686 base system already in my > store. Thanks very much! The i686 build only

Re: [PATCH] gnu: Add dlib.

2016-08-16 Thread Leo Famulari
On Wed, Aug 17, 2016 at 09:31:11AM +1000, Ben Woodcroft wrote: > > > On 17/08/16 06:47, Leo Famulari wrote: > > On Tue, Aug 16, 2016 at 11:45:16AM +0100, Marius Bakke wrote: > > > I initially made this package on a foreign distro without "lapack" in > > > inputs and have verified that dropping LA

Re: [PATCH] gnu: Move gtkglext from gnome to gtk.

2016-08-16 Thread Leo Famulari
On Wed, Aug 17, 2016 at 01:12:07AM +0200, Danny Milosavljevic wrote: > I'll send a patch. We can think of what we want to do with it - but at least > we can see the extent then. Oh, I see you already sent it. You'd also need to be sure to move the copyright authorship lines around properly. I don

Re: [PATCH] gnu: Move gtkglext from gnome to gtk.

2016-08-16 Thread Leo Famulari
On Wed, Aug 17, 2016 at 01:12:07AM +0200, Danny Milosavljevic wrote: > I've checked how bad it would be to move all the stuff: > > * gnu/packages/gnome.scm (libcroco, json-glib, libxklavier): Move variables > from here... > * gnu/packages/glib.scm (libcroco, json-glib, libxklavier): ... to here.

Re: [PATCH] gnu: Add dlib.

2016-08-16 Thread Ben Woodcroft
On 17/08/16 06:47, Leo Famulari wrote: On Tue, Aug 16, 2016 at 11:45:16AM +0100, Marius Bakke wrote: I initially made this package on a foreign distro without "lapack" in inputs and have verified that dropping LAPACK makes the tests pass. I also found some other optional dependencies after di

Re: [PATCH 4/5] gnu: arduino: Add arduino-libraries.

2016-08-16 Thread Danny Milosavljevic
> This seems like a false inheritence to me. Do arduino-hardware and > arduino-libraries really need to be separate packages? Not really. >but it seems like you might be able to do away with the dependencies setup Right now maybe. But there is a huge Arduino Java IDE and I'd rather not depend

[PATCH] gnu: move freedesktop stuff to "freedesktop.scm", gtk stuff to "gtk.scm", gnome stuff to "gnome.scm"

2016-08-16 Thread Danny Milosavljevic
gnu: move freedesktop stuff to "freedesktop.scm", gtk stuff to "gtk.scm", gnome stuff to "gnome.scm" * gnu/packages/gnome.scm (libcroco, json-glib, libxklavier): Move variables from here... * gnu/packages/glib.scm (libcroco, json-glib, libxklavier): ... to here. * gnu/packages/gnome.scm (deskt

Re: [PATCH] gnu: Move gtkglext from gnome to gtk.

2016-08-16 Thread Danny Milosavljevic
I've checked how bad it would be to move all the stuff: * gnu/packages/gnome.scm (libcroco, json-glib, libxklavier): Move variables from here... * gnu/packages/glib.scm (libcroco, json-glib, libxklavier): ... to here. * gnu/packages/gnome.scm (desktop-file-utils, shared-mime-info, hicolor-icon-

Re: [PATCH 4/5] gnu: arduino: Add arduino-libraries.

2016-08-16 Thread Eric Bavier
On Tue, 16 Aug 2016 20:36:31 +0200 Danny Milosavljevic wrote: > * gnu/packages/arduino.scm (arduino-libraries): New variable. > --- > gnu/packages/arduino.scm | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/gnu/packages/arduino.scm b/gnu/packages/arduino.scm > index a

Re: [PATCH 3/5] gnu: arduino: Add arduino-hardware

2016-08-16 Thread Eric Bavier
On Tue, 16 Aug 2016 20:36:30 +0200 Danny Milosavljevic wrote: > * gnu/packages/arduino.scm (arduino-hardware): New variable. > --- > gnu/packages/arduino.scm | 53 > > 1 file changed, 53 insertions(+) > > diff --git a/gnu/packages/arduino.scm b

Re: [PATCH 0/1] Perl 5.24.0 update

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 06:43:57PM -0400, Leo Famulari wrote: > And the perl-no-build-time patch deactivated the code that embedded the > compilation timestamp that is normally printed by `perl -V`. Perl 5.24.0 > can take this value from the macro PERL_BUILD_DATE [2], so I removed the > old patch a

[PATCH 1/1] gnu: perl: Update to 5.24.0.

2016-08-16 Thread Leo Famulari
* gnu/packages/perl.scm: Update to 5.24.0. [source]: Add and remove patches. * gnu/packages/patches/perl-reproducible-build-date.patch: New file. * gnu/packages/patches/perl-CVE-2015-8607.patch, gnu/packages/patches/perl-CVE-2016-2381.patch, gnu/packages/patches/perl-no-build-time.patch, gnu/packag

[PATCH 0/1] Perl 5.24.0 update

2016-08-16 Thread Leo Famulari
This updates Perl to 5.24.0. I tested it by creating perl-next on master, and building that. I also made perl-boot0 use perl-next and built that perl-boot0 successfully. The patches for CVE-2015-8607 and CVE-2016-2381 are removed, since those issues have been fixed in this release, in Perl commit

Re: [PATCH 1/5] gnu: Add "arduino" module.

2016-08-16 Thread Eric Bavier
On Tue, 16 Aug 2016 20:36:28 +0200 Danny Milosavljevic wrote: > * gnu/packages/arduino.scm: New file. > --- > gnu/packages/arduino.scm | 31 +++ > 1 file changed, 31 insertions(+) > create mode 100644 gnu/packages/arduino.scm You can feel free to just create the mod

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread Eric Bavier
On Tue, 16 Aug 2016 23:15:07 +0300 Alex Kost wrote: > David Craven (2016-08-16 21:39 +0300) wrote: > > > * gnu/packages/gstreamer.scm (define-module): Import guix licenses with > > #:prefix > > license:. > > (orc): Likewise. > > (gstreamer): Likewise. > > (gst-plugins-base): Likewise. >

Re: [PATCH 16/24] gnu: gstreamer: Add qt-gstreamer.

2016-08-16 Thread Eric Bavier
Hello David, You can remove the "gstreamer: " bit from the commit subject. On Tue, 16 Aug 2016 20:39:30 +0200 David Craven wrote: > * gnu/packages/gstreamer.scm (qt-gstreamer): New variable. > --- > gnu/packages/gstreamer.scm | 42 ++ > 1 file changed, 4

Re: [PATCH v3] gnu: Add python-lirc, python2-lirc.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 11:28:09PM +0200, Danny Milosavljevic wrote: > gnu: Add python-lirc, python2-lirc. > > * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables. Thanks, applied as 231313f76!

[PATCH v3] gnu: Add python-lirc, python2-lirc.

2016-08-16 Thread Danny Milosavljevic
gnu: Add python-lirc, python2-lirc. * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables. --- gnu/packages/lirc.scm | 51 +++ 1 file changed, 51 insertions(+) diff --git a/gnu/packages/lirc.scm b/gnu/packages/lirc.scm index e3f60e3..d

Re: [PATCH 16/24] gnu: gstreamer: Add qt-gstreamer.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 08:39:30PM +0200, David Craven wrote: > * gnu/packages/gstreamer.scm (qt-gstreamer): New variable. > + #:validate-runpath? #f)) My understanding is that if the runpath validator fails, then something is wrong with the package. Why is it disabled here?

Re: [PATCH 13/24] gnu: polkit-qt: Use modular qt.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 09:17:56PM +0200, Danny Milosavljevic wrote: > > - `(("qt" ,qt))) ; qt-4 according to the pkg-config files > > + `(("qtbase" ,qtbase))) > > That won't be qt-4 anymore. Is that OK? It won't have been using qt-4 anyways, since the qt variable has always been qt@5. qt

Re: [PATCH v2] gnu: python: Add python-lirc.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 10:21:15PM +0200, Danny Milosavljevic wrote: > gnu: python: Add python-lirc. > > * gnu/packages/python.scm (python-lirc, python2-lirc): New variables. Can you put it in the lirc module? > +(define-public python-lirc > + (let ((commit "4091fe918f3eed2513dad008828565cace408

Re: [PATCH] gnu: Add dlib.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 11:45:16AM +0100, Marius Bakke wrote: > I initially made this package on a foreign distro without "lapack" in > inputs and have verified that dropping LAPACK makes the tests pass. > > I also found some other optional dependencies after digging around the > source, as well a

Re: [PATCH] gnu: Move gtkglext from gnome to gtk.

2016-08-16 Thread Danny Milosavljevic
> Okay. Do the games and engineering modules still need to import the > gnome module if we make this move? Yes. The reasons that they still need gnome.scm are: - engineering.scm references desktop-file-utils and shared-mime-info which are freedesktop things (i.e. common to all desktop environm

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread David Craven
> I like this patch. However in general (a question for Guix people): is > there a reason to use #:select for licenses? Or would it be better to > use #:prefix everywhere? If the latter (my preference), I think it > would be good to make this "#:select"→"#:prefix" change in a single > patch inst

[PATCH v2] gnu: python: Add python-lirc.

2016-08-16 Thread Danny Milosavljevic
gnu: python: Add python-lirc. * gnu/packages/python.scm (python-lirc, python2-lirc): New variables. --- gnu/packages/python.scm | 49 + 1 file changed, 49 insertions(+) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index abb90d8..c

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread Alex Kost
David Craven (2016-08-16 21:39 +0300) wrote: > * gnu/packages/gstreamer.scm (define-module): Import guix licenses with > #:prefix > license:. > (orc): Likewise. > (gstreamer): Likewise. > (gst-plugins-base): Likewise. > (gst-plugins-good): Likewise. > (gst-plugins-bad): Likewise. >

Re: [PATCH] gnu: Move gtkglext from gnome to gtk.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 10:09:16PM +0200, Danny Milosavljevic wrote: > Hi Leo, > > On Tue, 16 Aug 2016 16:03:03 -0400 > Leo Famulari wrote: > > > On Tue, Aug 16, 2016 at 08:01:04PM +0200, Danny Milosavljevic wrote: > > > gnu: Move gtkglext from gnome to gtk. > > > > > > * gnu/packages/gnome.scm

Re: [PATCH] gnu: Move gtkglext from gnome to gtk.

2016-08-16 Thread Danny Milosavljevic
Hi Leo, On Tue, 16 Aug 2016 16:03:03 -0400 Leo Famulari wrote: > On Tue, Aug 16, 2016 at 08:01:04PM +0200, Danny Milosavljevic wrote: > > gnu: Move gtkglext from gnome to gtk. > > > > * gnu/packages/gnome.scm (gtkglext): Moved from here... > > * gnu/packages/gtk.scm (gtkglext): ... to here >

Re: [PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

2016-08-16 Thread Alex Kost
David Craven (2016-08-16 21:39 +0300) wrote: > * gnu/packages/kde-frameworks.scm (networkmanager-qt) > [propagated-inputs]: Add NETWORK-MANAGER. > [inputs]: Remove NETWORK-MANAGER. I would write 'network-manager' instead of NETWORK-MANAGER. Also there should be a reason for propagating (prob

Re: [PATCH 09/24] gnu: freedesktop: Add wayland-protocols.

2016-08-16 Thread Alex Kost
David Craven (2016-08-16 21:39 +0300) wrote: > * gnu/packages/freedesktop.scm (wayland-protocols): New variable. > --- > gnu/packages/freedesktop.scm | 22 ++ > 1 file changed, 22 insertions(+) > > > diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm > in

Re: [PATCH 06/24] gnu: xml: Add jsoncpp.

2016-08-16 Thread Alex Kost
David Craven (2016-08-16 21:39 +0300) wrote: > * gnu/packages/xml.scm (jsoncpp): New variable. > --- > gnu/packages/xml.scm | 19 +++ > 1 file changed, 19 insertions(+) > > > diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm > index 660a0b9..72403c2 100644 > --- a/gnu/packa

Re: [PATCH] gnu: Move gtkglext from gnome to gtk.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 08:01:04PM +0200, Danny Milosavljevic wrote: > gnu: Move gtkglext from gnome to gtk. > > * gnu/packages/gnome.scm (gtkglext): Moved from here... > * gnu/packages/gtk.scm (gtkglext): ... to here Why? I see that the package relates to GTK+, but it's also GNOME software. And

Re: [PATCH 08/24] gnu: xorg: Add lndir.

2016-08-16 Thread Alex Kost
David Craven (2016-08-16 21:39 +0300) wrote: > * gnu/packages/xorg.scm (lndir): New variable. Nice program, I didn't know about it, thanks! > --- > gnu/packages/xorg.scm | 25 + > 1 file changed, 25 insertions(+) > > > diff --git a/gnu/packages/xorg.scm b/gnu/packages/xo

Re: [PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info.

2016-08-16 Thread Danny Milosavljevic
> +(synopsis "Datbase of broadband connection configuration") > +(description "Datbase of broadband connection configuration.") ^^ a

Re: [PATCH] gnu: pypi importer: Remove python-setuptools and hint on how to re-add it.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 08:13:10PM +0200, Danny Milosavljevic wrote: > gnu: pypi importer: Remove python-setuptools and hint on how to re-add it. I'm in favor of not automatically adding setuptools to packages created with the PyPi importer. For the packages that require setuptools, packagers can

Re: [PATCH 06/24] gnu: xml: Add jsoncpp.

2016-08-16 Thread Danny Milosavljevic
Also, why the XML package? I suggest "serialization.scm" or something.

Re: [PATCH 05/24] gnu: xml: Add yaml-cpp.

2016-08-16 Thread Alex Kost
David Craven (2016-08-16 21:39 +0300) wrote: > * gnu/packages/xml.scm (yaml-cpp): New variable. > --- > gnu/packages/xml.scm | 24 > 1 file changed, 24 insertions(+) > > > diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm > index cfdc6c0..660a0b9 100644 > --- a/gnu

Re: [PATCH v2 2/6] gnu: fpga: Add abc.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 02:40:23PM -0400, Thompson, David wrote: > +;; FIXME use license: MIT Modern variant as described in: > +;; > +(license license:expat > > Could someone who knows more about this license chime in about what > t

Re: [PATCH 09/24] gnu: freedesktop: Add wayland-protocols.

2016-08-16 Thread Danny Milosavljevic
> +(inputs > + `(("wayland" ,wayland))) > +(native-inputs > + `(("pkg-config" ,pkg-config))) > +(synopsis "Wayland protocols") > +(description "Contains Xml definitions of the wayland protocols.") ^XML ^Wayland If it only cont

Re: [PATCH 07/24] gnu: compression: Add snappy.

2016-08-16 Thread Alex Kost
David Craven (2016-08-16 21:39 +0300) wrote: > * gnu/packages/compression.scm (snappy): New variable. > --- > gnu/packages/compression.scm | 36 > 1 file changed, 36 insertions(+) > > > diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm >

Re: [PATCH] gnu: Add libunique.

2016-08-16 Thread Leo Famulari
On Mon, Aug 15, 2016 at 11:33:26PM +, ng0 wrote: > Leo Famulari writes: > > Is this package required by something else that we are working on? What > > is the use case? > > (gnunet-gtk): > > (arguments > `(#:configure-flags > (list "--without-libunique" Okay, th

Re: [PATCH] gnu: pypi importer: Remove python-setuptools and hint on how to re-add it.

2016-08-16 Thread Pjotr Prins
On Tue, Aug 16, 2016 at 09:39:52PM +0200, Danny Milosavljevic wrote: > Hi, > > > Can you be more specific why it is removed? I don't understand the harm > > it does or doesn't do when it's included. > > Would this not be bad for packages which require setuptools? Not all python packages require s

Re: [PATCH 24/24] gnu: qt: Update qt to 5.7.0.

2016-08-16 Thread Danny Milosavljevic
LGTM!

Re: [PATCH] gnu: pypi importer: Remove python-setuptools and hint on how to re-add it.

2016-08-16 Thread Danny Milosavljevic
Hi, > Can you be more specific why it is removed? I don't understand the harm > it does or doesn't do when it's included. > Would this not be bad for packages which require setuptools? Python 3.4 integrated setuptools into the main distribution. It doesn't require an external python-setuptools.

Re: [PATCH 03/24] gnu: qt: Add qtgraphicaleffects.

2016-08-16 Thread Danny Milosavljevic
LGTM!

Re: [PATCH 06/24] gnu: xml: Add jsoncpp.

2016-08-16 Thread Danny Milosavljevic
Might it make sense to also mention that it is optionally public domain? Otherwise LGTM.

Re: [PATCH] NON-WORKING: new package: sent -- simple presentation tool

2016-08-16 Thread Eric Bavier
On Sun, 14 Aug 2016 11:04:15 +0300 Dmitry Bogatov wrote: > > This is my take on the patch. It builds and works fine. > > > > Dmitry, I added a copyright line for you; does it seem alright? > > Perfectly. Thank you for saving patch from rot. > No problem, sorry it took so long to get through

Re: [PATCH 23/24] gnu: qtkeychain: Use modular qt.

2016-08-16 Thread Danny Milosavljevic
LGTM!

Re: [PATCH 22/24] gnu: poppler-qt5: Use modular qt.

2016-08-16 Thread Danny Milosavljevic
LGTM!

Re: [PATCH 21/24] gnu: gst-plugins-bad: Use modular qt.

2016-08-16 Thread Danny Milosavljevic
LGTM!

Re: [PATCH 20/24] gnu: bitcoin-core: Use modular qt.

2016-08-16 Thread Danny Milosavljevic
LGTM!

Re: [PATCH] gnu: pypi importer: Remove python-setuptools and hint on how to re-add it.

2016-08-16 Thread ng0
Hi, Danny Milosavljevic writes: > gnu: pypi importer: Remove python-setuptools and hint on how to re-add it. Can you be more specific why it is removed? I don't understand the harm it does or doesn't do when it's included. Would this not be bad for packages which require setuptools? > * guix/i

Re: [PATCH 17/24] gnu: kwidgetsaddons: Fix test failure.

2016-08-16 Thread Danny Milosavljevic
>(system (string-append (assoc-ref inputs "xorg-server") > - "/bin/Xvfb :1 &")) > + "/bin/Xvfb :1 -screen 0 640x480x24 &")) Might (setenv "QT_QPA_PLATFORM" "offscreen") also be enough? Starting a

Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread Danny Milosavljevic
LGTM.

Re: [PATCH 19/24] gnu: fritzing: Use modular qt.

2016-08-16 Thread Danny Milosavljevic
LGTM.

Re: [PATCH 13/24] gnu: polkit-qt: Use modular qt.

2016-08-16 Thread Danny Milosavljevic
> - `(("qt" ,qt))) ; qt-4 according to the pkg-config files > + `(("qtbase" ,qtbase))) That won't be qt-4 anymore. Is that OK?

Re: [PATCH 18/24] gnu: qsynth: Use modular qt.

2016-08-16 Thread Danny Milosavljevic
LGTM

[PATCH] gnu: python: Add python-lirc.

2016-08-16 Thread Danny Milosavljevic
gnu: python: Add python-lirc. * gnu/packages/python.scm (python-lirc, python2-lirc): New variables. --- gnu/packages/python.scm | 50 + 1 file changed, 50 insertions(+) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index abb90d8..4

Re: [PATCH] gnu: Add clojure.

2016-08-16 Thread Pjotr Prins
On Tue, Aug 16, 2016 at 08:45:17PM +0200, Ricardo Wurmus wrote: > > Alex Vong writes: > > > Thanks for the review too. The changes looks good to me, excepts that it > > seems 'find-files' will find all files with name matching the regex > > recursively, but `scandir' will only list the files on

Maven

2016-08-16 Thread Danny Milosavljevic
Hi, I also tried to package the Arduino GUI - but it has lots of Apache Commons dependencies and those use the Maven repo system. Has anyone already packaged Apache Commons libraries?

Re: QtHaveModule

2016-08-16 Thread David Craven
Hi >> Hi, I just sent a patch to add 'QMAKEPATH' as search-path, which should >> fix this issue. > Thank you! Yes this fixes the issue and is a lot cleaner than what I > came up with... I sent a couple of patches to the mailing list that will require the qt and kde packages to be rebuilt (like t

Re: [PATCH] gnu: simple-scan: Update to 3.21.90.

2016-08-16 Thread Leo Famulari
On Tue, Aug 16, 2016 at 07:29:54PM +0200, Tobias Geerinckx-Rice wrote: > * gnu/packages/gnome.scm (simple-scan): Update to 3.21.90. > [inputs]: Remove libgudev. > [native-inputs]: Replace intltool dependency with gnu-gettext. Looks good, assuming that it's working for you!

Re: [PATCH] gnu: Add clojure.

2016-08-16 Thread Ricardo Wurmus
Alex Vong writes: > Thanks for the review too. The changes looks good to me, excepts that it > seems 'find-files' will find all files with name matching the regex > recursively, but `scandir' will only list the files on the 1st > level. Ah, I didn’t notice that this is what you were trying to d

[PATCH 23/24] gnu: qtkeychain: Use modular qt.

2016-08-16 Thread David Craven
* gnu/packages/qt.scm (qtkeychain)[inputs]: Add QTBASE. Remove QT. [native-inputs]: Add QTTOOLS. --- gnu/packages/qt.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 19488ac..021bb70 100644 --- a/gnu/packages/qt.scm +++ b/

[PATCH 18/24] gnu: qsynth: Use modular qt.

2016-08-16 Thread David Craven
* gnu/packages/audio.scm (qsynth)[inputs]: Add QTBASE, QTX11EXTRAS. Remove QT. [native-inputs]: Add QTTOOLS. --- gnu/packages/audio.scm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 5c42aaa..a21cd5b 100644 --- a/g

[PATCH 4/5] gnu: arduino: Add arduino-libraries.

2016-08-16 Thread Danny Milosavljevic
* gnu/packages/arduino.scm (arduino-libraries): New variable. --- gnu/packages/arduino.scm | 15 +++ 1 file changed, 15 insertions(+) diff --git a/gnu/packages/arduino.scm b/gnu/packages/arduino.scm index ae69c04..675df80 100644 --- a/gnu/packages/arduino.scm +++ b/gnu/packages/ardui

Re: [PATCH v2 2/6] gnu: fpga: Add abc.

2016-08-16 Thread Thompson, David
diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm index 112d53b..7571f87 100644 --- a/gnu/packages/fpga.scm +++ b/gnu/packages/fpga.scm @@ -38,3 +38,46 @@ #:use-module (gnu packages version-control) #:use-module (gnu packages libftdi)) +;; To compile as C code (default): +;; make

[PATCH 24/24] gnu: qt: Update qt to 5.7.0.

2016-08-16 Thread David Craven
* gnu/packages/qt.scm (qtbase): Update it. (qtsvg): Update it. (qtimageformats): Update it. (qtx11extras): Update it. (qtxmlpatterns): Update it. (qtdeclarative): Update it. (qtconnectivity): Update it. (qtwebsockets): Update it. (qtsensors): Update it. (qtmultimedia): Update it

[PATCH 22/24] gnu: poppler-qt5: Use modular qt.

2016-08-16 Thread David Craven
* gnu/packages/pdf.scm (poppler-qt)[inputs]: Add QTBASE. Remove QT. --- gnu/packages/pdf.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm index 439adb9..4b08048 100644 --- a/gnu/packages/pdf.scm +++ b/gnu/packages/pdf.scm @@ -118,7

[PATCH 19/24] gnu: fritzing: Use modular qt.

2016-08-16 Thread David Craven
* gnu/packages/engineering.scm (fritzing)[inputs]: Add QTBASE, QTSERIALPORT, QTSVG. Remove QT. --- gnu/packages/engineering.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index f6c3d5f..dad38e0 100644 --- a/g

[PATCH 21/24] gnu: gst-plugins-bad: Use modular qt.

2016-08-16 Thread David Craven
* gnu/packages/gstreamer.scm (gst-plugins-bad)[inputs]: Add QTBASE. Remove QT. --- gnu/packages/gstreamer.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm index ee3c9e4..0d8a74d 100644 --- a/gnu/packages/gstreamer.scm +

[PATCH 14/24] gnu: gstreamer: Use license: prefix.

2016-08-16 Thread David Craven
* gnu/packages/gstreamer.scm (define-module): Import guix licenses with #:prefix license:. (orc): Likewise. (gstreamer): Likewise. (gst-plugins-base): Likewise. (gst-plugins-good): Likewise. (gst-plugins-bad): Likewise. (gst-plugins-ugly): Likewise. (gst-libav): Likewise. (python-

[PATCH 16/24] gnu: gstreamer: Add qt-gstreamer.

2016-08-16 Thread David Craven
* gnu/packages/gstreamer.scm (qt-gstreamer): New variable. --- gnu/packages/gstreamer.scm | 42 ++ 1 file changed, 42 insertions(+) diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm index 54919cd..ee3c9e4 100644 --- a/gnu/packages/gstream

[PATCH 17/24] gnu: kwidgetsaddons: Fix test failure.

2016-08-16 Thread David Craven
* gnu/packages/kde-frameworks.scm (kwidgetsaddons)[arguments]: Enable tests. Set Xvfb pixel depth to 24 bits. --- gnu/packages/kde-frameworks.scm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index

[PATCH 08/24] gnu: xorg: Add lndir.

2016-08-16 Thread David Craven
* gnu/packages/xorg.scm (lndir): New variable. --- gnu/packages/xorg.scm | 25 + 1 file changed, 25 insertions(+) diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm index b24e437..1e7da68 100644 --- a/gnu/packages/xorg.scm +++ b/gnu/packages/xorg.scm @@ -133,6 +133

[PATCH 13/24] gnu: polkit-qt: Use modular qt.

2016-08-16 Thread David Craven
* gnu/packages/polkit.scm (polkit-qt)[propagated-inputs]: Use QTBASE instead of QT. --- gnu/packages/polkit.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/polkit.scm b/gnu/packages/polkit.scm index 08b753a..e224ca2 100644 --- a/gnu/packages/polkit.scm +++ b/

[PATCH 20/24] gnu: bitcoin-core: Use modular qt.

2016-08-16 Thread David Craven
* gnu/packages/finance.scm (bitcoin-core)[inputs]: Add QTBASE. Remove QT. --- gnu/packages/finance.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 179e325..21a2276 100644 --- a/gnu/packages/finance.scm +++ b/gnu/pack

[PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include directory.

2016-08-16 Thread David Craven
* gnu/packages/gstreamer.scm (gstreamer)[arguments]: Add symlink-gstconfig.h phase. --- gnu/packages/gstreamer.scm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm index bd99880..54919cd 100644 --- a/gnu/packa

[PATCH 09/24] gnu: freedesktop: Add wayland-protocols.

2016-08-16 Thread David Craven
* gnu/packages/freedesktop.scm (wayland-protocols): New variable. --- gnu/packages/freedesktop.scm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm index 0262d0a..a24d8fa 100644 --- a/gnu/packages/freedesktop.sc

[PATCH 10/24] gnu: networkmanager-qt: Propagate network-manager.

2016-08-16 Thread David Craven
* gnu/packages/kde-frameworks.scm (networkmanager-qt) [propagated-inputs]: Add NETWORK-MANAGER. [inputs]: Remove NETWORK-MANAGER. --- gnu/packages/kde-frameworks.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-fram

[PATCH 05/24] gnu: xml: Add yaml-cpp.

2016-08-16 Thread David Craven
* gnu/packages/xml.scm (yaml-cpp): New variable. --- gnu/packages/xml.scm | 24 1 file changed, 24 insertions(+) diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm index cfdc6c0..660a0b9 100644 --- a/gnu/packages/xml.scm +++ b/gnu/packages/xml.scm @@ -12,6 +12,7 @@

[PATCH 07/24] gnu: compression: Add snappy.

2016-08-16 Thread David Craven
* gnu/packages/compression.scm (snappy): New variable. --- gnu/packages/compression.scm | 36 1 file changed, 36 insertions(+) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index e63c1af..cd1866b 100644 --- a/gnu/packages/compression

[PATCH 11/24] gnu: modemmanager-qt: Propagate modem-manager.

2016-08-16 Thread David Craven
* gnu/packages/kde-frameworks.scm (modemmanager-qt) [propagated-inputs]: Add MODEM-MANAGER. [inputs]: Remove MODEM-MANAGER. --- gnu/packages/kde-frameworks.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks

[PATCH 12/24] gnu: gnome: Add mobile-broadband-provider-info.

2016-08-16 Thread David Craven
* gnu/packages/gnome.scm (mobile-broadband-provider-info): New variable. --- gnu/packages/gnome.scm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 4a0be01..7bc0445 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packa

[PATCH 01/24] gnu: qt: Add qtquickcontrols.

2016-08-16 Thread David Craven
* gnu/packages/qt.scm (qtquickcontrols): New variable. --- gnu/packages/qt.scm | 17 + 1 file changed, 17 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index a12c526..ca777dd 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -802,6 +802,23 @@ dev

[PATCH 02/24] gnu: qt: Add qtquickcontrols2.

2016-08-16 Thread David Craven
* gnu/packages/qt.scm (qtquickcontrols2): New variable. --- gnu/packages/qt.scm | 17 + 1 file changed, 17 insertions(+) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index ca777dd..65b6d82 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -819,6 +819,23 @@ de

[PATCH 04/24] gnu: databases: Add lmdb.

2016-08-16 Thread David Craven
* gnu/packages/databases.scm (lmdb): New variable. --- gnu/packages/databases.scm | 29 + 1 file changed, 29 insertions(+) diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm index d3a44f7..0a6b267 100644 --- a/gnu/packages/databases.scm +++ b/gnu/pack

  1   2   >