Re: maradns reproducibility fixes and the merits of picking a random number

2022-06-27 Thread Vagrant Cascadian
On 2022-06-22, Vagrant Cascadian wrote: > On 2022-06-08, Vagrant Cascadian wrote: >> On 2022-06-08, Efraim Flashner wrote: >>> On Tue, Jun 07, 2022 at 07:20:25AM +0200, Julien Lepiller wrote: On June 7, 2022 5:24:22 AM GMT+02:00, Felix Lechner wrote: >On Mon, Jun 6, 2022 at 6:50 PM

Re: Experimental nar-herder support for serving fixed output files by hash

2022-06-27 Thread Maxim Cournoyer
Hi, [...] > What I was getting at here though, ignoring the implementation, was > whether this is worthwhile to do? As in, is there benefit to having this > and being able to extend the content addressed mirrors that Guix uses? It's an effort/reward analysis that you are in the best position to

Re: Dealing with upstream issues

2022-06-27 Thread Maxime Devos
zimoun schreef op ma 27-06-2022 om 17:23 [+0200]: > Old unsolved bugs are still open.  The cross-compilation of one package is > an issue for sure, but: > >  1. it is not an issue for inclusion in Guix >  2. it has to be solved by people interested by cross-compilation Unfortunately, systematic c

Re: Dealing with upstream issues

2022-06-27 Thread Maxime Devos
zimoun schreef op ma 27-06-2022 om 17:23 [+0200]: > Old unsolved bugs are still open Sometimes they aren't: * https://issues.guix.gnu.org/45828 * https://issues.guix.gnu.org/26705 * https://issues.guix.gnu.org/25719 (exception handling hasn't been cleaned up before closing) * https://issues.

Re: Dealing with upstream issues

2022-06-27 Thread Maxime Devos
zimoun schreef op ma 27-06-2022 om 17:23 [+0200]: > You are mixing unrelated topics, IMHO. > > We have policies, not standard. > > «A policy is a set of ideas or plans that is used as a basis for making > decisions, especially in politics, economics, or business.» > > «A standard is a level of

Re: Dealing with upstream issues

2022-06-27 Thread Maxime Devos
zimoun schreef op ma 27-06-2022 om 17:06 [+0200]: > Do you mean > > --8<---cut here---start->8--- > > +(define-public harec > > +  (let ((commit "bbabe09bddf74bd699f8ad2224fdd6e2eefbd35e") > > (revision "0")) > Despite what (guix style) may tell you, revision go

Re: Dealing with upstream issues

2022-06-27 Thread zimoun
Hi, On Mon, 27 Jun 2022 at 16:32, Maxime Devos wrote: >> Maybe I misunderstand the point.  To me, the aim of the package >> submission is the inclusion in Guix.  AFAIK, the Guix project is not >> applying any standard audit on the upstream code before inclusion. >> >> Therefore, if the upstream

Re: Dealing with upstream issues

2022-06-27 Thread zimoun
On Mon, 27 Jun 2022 at 16:20, Maxime Devos wrote: > E.g.: https://issues.guix.gnu.org/55606#16 Do you mean --8<---cut here---start->8--- > +(define-public harec > + (let ((commit "bbabe09bddf74bd699f8ad2224fdd6e2eefbd35e") > (revision "0")) Despite what (gui

Re: Dealing with upstream issues

2022-06-27 Thread Maxime Devos
zimoun schreef op ma 27-06-2022 om 14:53 [+0200]: > Maybe I misunderstand the point.  To me, the aim of the package > submission is the inclusion in Guix.  AFAIK, the Guix project is not > applying any standard audit on the upstream code before inclusion. > > Therefore, if the upstream code is poo

Re: Dealing with upstream issues

2022-06-27 Thread Maxime Devos
zimoun schreef op ma 27-06-2022 om 14:32 [+0200]: > Hi Maxime, > > On Mon, 27 Jun 2022 at 12:37, Maxime Devos wrote: > > > Also, some of those rules are incorrect -- "guix style" occasionally > > makes things wrong and patch submitters had to be told to not follow > > it. > > Do you have concre

[Shepherd] Service monitoring agent

2022-06-27 Thread Ludovic Courtès
Hello Guix! I recently pushed a Shepherd branch called ‘wip-service-monitor’: https://git.savannah.gnu.org/cgit/shepherd.git/log/?h=wip-service-monitor It creates a “service monitoring agent”—code that runs in a separate fiber and encapsulates the current state of services: registered, running

Re: Dealing with upstream issues

2022-06-27 Thread zimoun
Hi, Well, from my understanding, there is mismatches between “review process”, “adoption in Guix” and “fix upstream”. On Mon, 27 Jun 2022 at 12:10, Ludovic Courtès wrote: >> AFAICT the issues have not been reported upstream yet, so I don't think >> we can close this entry on debbugs yet. Whil

Unreproducible «When Docker images become fixed-point»?

2022-06-27 Thread zimoun
Hi, Preparing a session about Guix, I was checking this blog post: https://hpc.guix.info/blog/2021/10/when-docker-images-become-fixed-point/ explaining how to rebuild a Docker pack using a Docker pack produced by Guix itself. It is from Oct. 2021. The pack built by the post is: /gnu/stor

Re: Dealing with upstream issues

2022-06-27 Thread zimoun
Hi Maxime, On Mon, 27 Jun 2022 at 12:37, Maxime Devos wrote: > Also, some of those rules are incorrect -- "guix style" occasionally > makes things wrong and patch submitters had to be told to not follow > it. Do you have concrete examples in mind? Cheers, simon

Re: Experimental nar-herder support for serving fixed output files by hash

2022-06-27 Thread Christopher Baines
Ludovic Courtès writes: >> The code isn't great, there's some difficulty in extracting the single >> file from the nar, but the biggest problem is a limitation in the guile >> fibers web server. Currently, responses have to be read in to memory, >> which is fine for we pages, but not great if yo

Re: Dealing with upstream issues

2022-06-27 Thread Maxime Devos
Maxime Devos schreef op ma 27-06-2022 om 12:30 [+0200]: > We can ask to do send the notice upstream, if it's in the rules (I > consider this to be part of the unwritten rules). [...] > I also consider them to not be rules as in ‘if they are followed, it > WILL be accepted’ but more guidelines like

Re: Dealing with upstream issues

2022-06-27 Thread Maxime Devos
Ludovic Courtès schreef op ma 27-06-2022 om 12:10 [+0200]: > Regarding the review process, I think we should strive for a predictable > process—not requesting work from the submitter beyond what they can > expect.  Submitters can be expected to follow the written rules¹ and > perhaps a few more rul

Dealing with upstream issues

2022-06-27 Thread Ludovic Courtès
Hi Maxime, (Moving to guix-devel; starting point at .) Maxime Devos skribis: >> That said, I think it’s a bit too much to ask of a downstream packager >> or user to address these issues.  As I see it, these issues should be >> reported upstream and addressed

Re: Experimental nar-herder support for serving fixed output files by hash

2022-06-27 Thread Ludovic Courtès
Hello, Christopher Baines skribis: > With the nar-herder, the implementation is a little trickier. Since the > nar-herder manages a collection of nars, rather than serving things from > the store, it might have the file being requested but it's inside a > probably compressed nar file. So, to res

Re: reader macros for hidden packages

2022-06-27 Thread Ludovic Courtès
Hi, jgart skribis: > Out of curiosity, is it possible to make reader macros like this with guile? > > ``` > @hidden > (define-public python-httplib2 As Maxime notes, ‘read-hash-extend’ is the only reader extension mechanism, and it only supports hash-prefixed extensions. That said, I very much