Re: [PATCH]: add freepats and timidity

2015-02-24 Thread Ludovic Courtès
Andreas Enge skribis: > On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote: >> +(define-public timidity++ >> + (package >> +(name "timidity++") > > Back to names... I would call this "timidity". The package guidelines only > state that underscores are replaced by "-", but the gen

Re: [PATCH]: add freepats and timidity

2015-02-22 Thread Ricardo Wurmus
Attached are two new patches for Freepats and TiMidity++. The contents of the Freepats tarball are now unpacked to $out/share/freepats/, so there should be no conflicts anymore. In TiMidity++ I removed the Tcl/Tk interface and added the ncurses interface instead (the Tcl interface didn't actuall

Re: [PATCH]: add freepats and timidity

2015-02-19 Thread Andreas Enge
On Thu, Feb 19, 2015 at 10:09:38PM +0100, Ricardo Wurmus wrote: > I see. Wouldn't it be better to place the README in > share/doc/{timidity,freepats}/README rather than removing it? I think it is unusual, but could be done for freepats, which has no other documentation (apart from "guix -s freepa

Re: [PATCH]: add freepats and timidity

2015-02-19 Thread Ricardo Wurmus
Andreas Enge writes: > On Thu, Feb 19, 2015 at 09:03:34PM +0100, Ricardo Wurmus wrote: >> Is copying the license and the readme file a problem? In my teensy >> store I count 382 readme files alone. It doesn't seem unusual to >> include the readme. > > I think it is not good style. And it can cr

Re: [PATCH]: add freepats and timidity

2015-02-19 Thread Andreas Enge
On Thu, Feb 19, 2015 at 09:03:34PM +0100, Ricardo Wurmus wrote: > Is copying the license and the readme file a problem? In my teensy > store I count 382 readme files alone. It doesn't seem unusual to > include the readme. I think it is not good style. And it can create collisions if several pack

Re: [PATCH]: add freepats and timidity

2015-02-19 Thread Ricardo Wurmus
Andreas Enge writes: > On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote: >> +(define-public timidity++ >> + (package >> +(name "timidity++") > > Back to names... I would call this "timidity". The package guidelines only > state that underscores are replaced by "-", but the gene

Re: [PATCH]: add freepats and timidity

2015-02-19 Thread Ricardo Wurmus
Andreas Enge writes: > On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote: >> + (copy-recursively "." out) > > I think this is a bit too much, as it also copies COPYING and README. > I would suggest to only copy the patch folders Drum_000 and Tone_000 and > free

Re: [PATCH]: add freepats and timidity

2015-02-19 Thread Andreas Enge
Hi again, thanks a lot for the two packages, they work for me. Nevertheless two comments. On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote: > +(define-public timidity++ > + (package > +(name "timidity++") Back to names... I would call this "timidity". The package guidelines on

Re: [PATCH]: add freepats and timidity

2015-02-19 Thread Andreas Enge
Hello, On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote: > + (copy-recursively "." out) I think this is a bit too much, as it also copies COPYING and README. I would suggest to only copy the patch folders Drum_000 and Tone_000 and freepats.cfg. Andreas

[PATCH]: add freepats and timidity

2015-02-19 Thread Ricardo Wurmus
Hi Guix, attached are two patches: one for freepats and another for the MIDI player TiMidity++. TiMidity++ comes with a simple configuration file referencing the freepats configuration, so it's usable out of the box. ~~ Ricardo >From b9e2401e7447f5c777e50cf00a360e2f7795df92 Mon Sep 17 00:00:00