Re: [PATCH] Add MAFFT.

2015-09-16 Thread Ricardo Wurmus
Ludovic Courtès writes: > Ben Woodcroft skribis: > >> From 0796e8be05977e6d30eab787a1550bd8d1f12b2d Mon Sep 17 00:00:00 2001 >> From: Ben Woodcroft >> Date: Sat, 12 Sep 2015 22:10:20 +1000 >> Subject: [PATCH] gnu: Add mafft. >> >> * gnu/packages/bioinformatics.scm (mafft): New variable. > > I’l

Re: [PATCH] Add MAFFT.

2015-09-16 Thread Ludovic Courtès
Ben Woodcroft skribis: > From 0796e8be05977e6d30eab787a1550bd8d1f12b2d Mon Sep 17 00:00:00 2001 > From: Ben Woodcroft > Date: Sat, 12 Sep 2015 22:10:20 +1000 > Subject: [PATCH] gnu: Add mafft. > > * gnu/packages/bioinformatics.scm (mafft): New variable. I’ll leave it to Ricardo, but two minor c

Re: [PATCH] Add MAFFT.

2015-09-12 Thread Ben Woodcroft
On 07/09/15 18:55, Andreas Enge wrote: On Tue, Aug 25, 2015 at 10:58:42PM +0200, Ludovic Courtès wrote: It seems this message was left unanswered. Andreas? I had a cursory look at the patch, here are some comments: [..] +protein sequences. For instance, it offers L-INS-i (accurate; for alig

Re: [PATCH] Add MAFFT.

2015-09-07 Thread Ricardo Wurmus
Andreas Enge writes: >> +protein sequences. For instance, it offers L-INS-i (accurate; for alignment >> +of > Is this an artefact of the mailer? In the original patch I see this instead: > + "MAFFT offers a range of multiple alignment methods for nucleotide and > +protein sequences. For

Re: [PATCH] Add MAFFT.

2015-09-07 Thread Andreas Enge
On Tue, Aug 25, 2015 at 10:58:42PM +0200, Ludovic Courtès wrote: > It seems this message was left unanswered. Andreas? I had a cursory look at the patch, here are some comments: On Thu, Jul 23, 2015 at 10:43:31PM +1000, Ben Woodcroft wrote: > + #:make-flags (list (string-append "PREFIX=" (

Re: [PATCH] Add MAFFT.

2015-08-25 Thread Ludovic Courtès
Ben Woodcroft skribis: > On 26/07/15 20:29, Andreas Enge wrote: >> On Sun, Jul 26, 2015 at 11:43:38AM +0200, Andreas Enge wrote: >>> I would use a snippet for something internal to Guix, or specific to the >>> way we handle things, while a patch is intended to be passed upstream (or >>> sometimes

Re: [PATCH] Add MAFFT.

2015-07-31 Thread Ben Woodcroft
On 26/07/15 20:29, Andreas Enge wrote: On Sun, Jul 26, 2015 at 11:43:38AM +0200, Andreas Enge wrote: I would use a snippet for something internal to Guix, or specific to the way we handle things, while a patch is intended to be passed upstream (or sometimes taken from upstream already) to corr

Re: [PATCH] Add MAFFT.

2015-07-26 Thread Andreas Enge
On Sun, Jul 26, 2015 at 11:43:38AM +0200, Andreas Enge wrote: > I would use a snippet for something internal to Guix, or specific to the > way we handle things, while a patch is intended to be passed upstream (or > sometimes taken from upstream already) to correct a bug in the software. Well, I am

Re: [PATCH] Add MAFFT.

2015-07-26 Thread Ricardo Wurmus
Andreas Enge writes: > On Sun, Jul 26, 2015 at 01:10:14PM +1000, Ben Woodcroft wrote: >> I'm actually a bit confused as to the difference between a snippet vs. a >> patch stage as above - when is each appropriate? Snippets are only for >> removing non-free software? > > I would use a snippet for

Re: [PATCH] Add MAFFT.

2015-07-26 Thread Andreas Enge
On Sun, Jul 26, 2015 at 01:10:14PM +1000, Ben Woodcroft wrote: > I'm actually a bit confused as to the difference between a snippet vs. a > patch stage as above - when is each appropriate? Snippets are only for > removing non-free software? I would use a snippet for something internal to Guix, or

Re: [PATCH] Add MAFFT.

2015-07-25 Thread Ben Woodcroft
On 26/07/15 05:26, Ricardo Wurmus wrote: Hi Ben, + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'enter-dir +(lambda _ (chdir "core") #t)) + ;; on advice from the MAFFT authors, do not distribute mafft-profile, + ;; mafft

Re: [PATCH] Add MAFFT.

2015-07-25 Thread Ricardo Wurmus
Hi Ben, > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'enter-dir > +(lambda _ (chdir "core") #t)) > + ;; on advice from the MAFFT authors, do not distribute > mafft-profile, > + ;; mafft-distance mafft-homologs.rb

[PATCH] Add MAFFT.

2015-07-23 Thread Ben Woodcroft
Note that the "extensions" listed on the website are research/non-profit only, and so not fit for inclusion. >From b966b0c8ab9b194bbb7089cc4b4e3a9727862691 Mon Sep 17 00:00:00 2001 From: Ben Woodcroft Date: Thu, 23 Jul 2015 22:42:17 +1000 Subject: [PATCH] gnu: Add mafft. * gnu/packages/bioinform