Re: [PATCH] Add libiax

2016-06-01 Thread Leo Famulari
On Wed, Jun 01, 2016 at 09:40:36AM -0500, Lukas Gradl wrote: > OK, I changed the name to libiax2 and added the license field + comment > from your patch. Thanks! Pushed as 4ff2060524. I noticed in my final review that the commit title was like this: gnu: telephony: Add libiax2. Our convention i

Re: [PATCH] Add libiax

2016-06-01 Thread Lukas Gradl
Leo Famulari writes: > On Tue, May 31, 2016 at 09:02:21PM +0200, Andreas Enge wrote: >> Hello, >> >> just a quick comment on the name: >> >> On Mon, May 30, 2016 at 02:47:55PM -0500, Lukas Gradl wrote: >> > Upstream seems to refer to the software as "iax" "libiax" and "libiax2" >> > interchange

Re: [PATCH] Add libiax

2016-05-31 Thread Leo Famulari
On Tue, May 31, 2016 at 09:13:23PM +0200, Andreas Enge wrote: > On Tue, May 31, 2016 at 12:25:55PM -0400, Leo Famulari wrote: > > Since I don't understand the fine points of these things, I ask the > > group: can a source distribution be LGPL 2.0 and include GPL components? > > In my understanding

Re: [PATCH] Add libiax

2016-05-31 Thread Leo Famulari
On Tue, May 31, 2016 at 09:02:21PM +0200, Andreas Enge wrote: > Hello, > > just a quick comment on the name: > > On Mon, May 30, 2016 at 02:47:55PM -0500, Lukas Gradl wrote: > > Upstream seems to refer to the software as "iax" "libiax" and "libiax2" > > interchangeably. The "2" was the closest t

Re: [PATCH] Add libiax

2016-05-31 Thread Leo Famulari
On Tue, May 31, 2016 at 12:25:55PM -0400, Leo Famulari wrote: > On Mon, May 30, 2016 at 02:50:02PM -0500, Lukas Gradl wrote: > > * gnu/packages/telephony.scm (libiax): New variable. > > > + (license lgpl2.0 > > In my final review, I found that some source files are licensed under > the G

Re: [PATCH] Add libiax

2016-05-31 Thread Andreas Enge
On Tue, May 31, 2016 at 12:25:55PM -0400, Leo Famulari wrote: > Since I don't understand the fine points of these things, I ask the > group: can a source distribution be LGPL 2.0 and include GPL components? In my understanding, mixing LGPL and GPL (assuming the versions are compatible) "upgrades"

Re: [PATCH] Add libiax

2016-05-31 Thread Andreas Enge
Hello, just a quick comment on the name: On Mon, May 30, 2016 at 02:47:55PM -0500, Lukas Gradl wrote: > Upstream seems to refer to the software as "iax" "libiax" and "libiax2" > interchangeably. The "2" was the closest thing I could find to a version > number. notice that the tarball name is al

Re: [PATCH] Add libiax

2016-05-31 Thread Efraim Flashner
On Tue, May 31, 2016 at 12:25:55PM -0400, Leo Famulari wrote: > On Mon, May 30, 2016 at 02:50:02PM -0500, Lukas Gradl wrote: > > * gnu/packages/telephony.scm (libiax): New variable. > > > + (license lgpl2.0 > > In my final review, I found that some source files are licensed under > the G

Re: [PATCH] Add libiax

2016-05-31 Thread Leo Famulari
On Mon, May 30, 2016 at 02:50:02PM -0500, Lukas Gradl wrote: > * gnu/packages/telephony.scm (libiax): New variable. > + (license lgpl2.0 In my final review, I found that some source files are licensed under the GPL (no version specified) as well as one public-domain file. The details are

Re: [PATCH] Add libiax

2016-05-30 Thread Lukas Gradl
Leo Famulari writes: > On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote: >> + #:use-module (gnu packages autotools) >^ > Also, there is some extra whitespace at the end of the line above. > Oops! Good catch! >> + (uri >> +

Re: [PATCH] Add libiax

2016-05-30 Thread Lukas Gradl
Thank you for your review! Leo Famulari writes: > On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote: >> >> Hi Guix, >> >> Attached is a patch for LibIAX, a library that is used by the Ring >> (formerly SFLphone). > > Cool! > >> Upstream seems to use no version numbers. I used the g

Re: [PATCH] Add libiax

2016-05-28 Thread Leo Famulari
On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote: > + #:use-module (gnu packages autotools) ^ Also, there is some extra whitespace at the end of the line above. > + (uri > + (string-append > + "https://gitlab.savoi

Re: [PATCH] Add libiax

2016-05-28 Thread Leo Famulari
On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote: > > Hi Guix, > > Attached is a patch for LibIAX, a library that is used by the Ring > (formerly SFLphone). Cool! > Upstream seems to use no version numbers. I used the git commit ID that > is also refered to in the version that is bu

[PATCH] Add libiax

2016-05-28 Thread Lukas Gradl
Hi Guix, Attached is a patch for LibIAX, a library that is used by the Ring (formerly SFLphone). Upstream seems to use no version numbers. I used the git commit ID that is also refered to in the version that is bundeled with Ring. This is also the latest commit to libiax. Thank you! >From b