Re: [PATCH] gnu: Add Red Eclipse.

2016-05-04 Thread Alex Kost
Andreas Enge (2016-05-03 22:23 +0300) wrote: > On Tue, May 03, 2016 at 10:08:52PM +0300, Alex Kost wrote: >> Only the package name is renamed here. I think it would be more >> consistent to rename the variable as well. > > My apologies, indeed. I will push an additional patch. I see, thanks! >

Re: [PATCH] gnu: Add Red Eclipse.

2016-05-04 Thread Alex Kost
Albin (2016-05-03 22:24 +0300) wrote: > Den 2016-05-03 kl. 21:09, skrev Alex Kost: >> Andreas Enge (2016-05-02 13:38 +0300) wrote: >> >>> On Tue, Apr 26, 2016 at 01:22:33PM +0300, Alex Kost wrote: > + (name "redeclipse") I would name the package "red-eclipse", but it probably doesn'

Re: [PATCH] gnu: Add Red Eclipse.

2016-05-03 Thread Andreas Enge
On Tue, May 03, 2016 at 09:24:46PM +0200, Albin wrote: > I just installed 'red-eclipse' from a git checkout and then the link to > the binary was named 'redeclipse_linux' and not 'red-eclipse' as I had > expected. Well, this happens; we usually do not modify binary names from upstream. For instanc

Re: [PATCH] gnu: Add Red Eclipse.

2016-05-03 Thread Albin
Den 2016-05-03 kl. 21:09, skrev Alex Kost: > Andreas Enge (2016-05-02 13:38 +0300) wrote: > >> On Tue, Apr 26, 2016 at 01:22:33PM +0300, Alex Kost wrote: + (name "redeclipse") >>> I would name the package "red-eclipse", but it probably doesn't matter. >> >> That would be in line with our

Re: [PATCH] gnu: Add Red Eclipse.

2016-05-03 Thread Andreas Enge
On Tue, May 03, 2016 at 10:08:52PM +0300, Alex Kost wrote: > Only the package name is renamed here. I think it would be more > consistent to rename the variable as well. My apologies, indeed. I will push an additional patch. On Tue, May 03, 2016 at 10:09:40PM +0300, Alex Kost wrote: > Probably;

Re: [PATCH] gnu: Add Red Eclipse.

2016-05-03 Thread Alex Kost
Andreas Enge (2016-05-02 13:38 +0300) wrote: > On Tue, Apr 26, 2016 at 01:22:33PM +0300, Alex Kost wrote: >> > + (name "redeclipse") >> I would name the package "red-eclipse", but it probably doesn't matter. > > That would be in line with our package naming guidelines: replace everything > th

Re: [PATCH] gnu: Add Red Eclipse.

2016-05-03 Thread Alex Kost
> From 1a78f4bb97d2697a3e202a21c3d222b30c136ac4 Mon Sep 17 00:00:00 2001 > From: Kei Yamashita > Date: Tue, 3 May 2016 12:04:38 -0400 > Subject: [PATCH] gnu: Rename redeclipse package to match naming specification. > > * gnu/packages/games.scm (redeclipse): Rename to... > (red-eclipse): ...this. >

Re: [PATCH] gnu: Add Red Eclipse.

2016-05-03 Thread Andreas Enge
On Tue, May 03, 2016 at 12:10:22PM -0400, Kei Yamashita wrote: > Here's a patch if anyone wants to apply it. Thanks a lot, I just pushed. Andreas

Re: [PATCH] gnu: Add Red Eclipse.

2016-05-03 Thread Kei Yamashita
On Mon, 2 May 2016 12:38:37 +0200 Andreas Enge wrote: > On Tue, Apr 26, 2016 at 01:22:33PM +0300, Alex Kost wrote: > > > + (name "redeclipse") > > I would name the package "red-eclipse", but it probably doesn't > > matter. > > That would be in line with our package naming guidelines: re

Re: [PATCH] gnu: Add Red Eclipse.

2016-05-02 Thread Andreas Enge
On Tue, Apr 26, 2016 at 01:22:33PM +0300, Alex Kost wrote: > > + (name "redeclipse") > I would name the package "red-eclipse", but it probably doesn't matter. That would be in line with our package naming guidelines: replace everything that is not [A-Za-z0-9] by a '-'. Do you think we could s

Re: [PATCH] gnu: Add Red Eclipse.

2016-04-28 Thread Alex Kost
Ludovic Courtès (2016-04-27 15:14 +0300) wrote: >>> + "Red Eclipse is an open-source arena shooter, created from the Cube2 > > s/open-source// Oops, I didn't notice this, thanks! >>> + ;; License information available in detail at the following link: >>> + ;; http://redeclipse.ne

Re: [PATCH] gnu: Add Red Eclipse.

2016-04-27 Thread Ludovic Courtès
Alex Kost skribis: [...] >> + ;; Create origin records for the many separate data packages. >> + ,@(map (match-lambda >> + ((name hash) >> + (list name >> + (origin >> + (method url-fetch) >> +

Re: [PATCH] gnu: Add Red Eclipse.

2016-04-26 Thread Alex Kost
Kei Yamashita (2016-04-23 14:46 +0300) wrote: Thanks, this is very impressive work!! I don't have any significant notes, so if there will be no other comments, I'm going to fix them and commit this patch. [...] > +(define-public redeclipse > + (let ((data-sources > + '(("acerspyro" > "

Re: [PATCH] gnu: Add Red Eclipse.

2016-04-23 Thread Kei Yamashita
Huh. The email client did report an SMTP error... On Sat, 23 Apr 2016 09:18:32 +0200 Florian Paul Schmidt wrote: > On 23.04.2016 08:20, Kei Yamashita wrote: > > With much help from others on IRC, this patch works! If necessary > > or preferable, please suggest changes to make this patch more > >

Re: [PATCH] gnu: Add Red Eclipse.

2016-04-23 Thread Florian Paul Schmidt
On 23.04.2016 08:20, Kei Yamashita wrote: > With much help from others on IRC, this patch works! If necessary > or preferable, please suggest changes to make this patch more > maintainable in the long run. > Hi, I think you forgot to attach the patch :) Flo -- https://fps.io signature.asc

[PATCH] gnu: Add Red Eclipse.

2016-04-22 Thread Kei Yamashita
With much help from others on IRC, this patch works! If necessary or preferable, please suggest changes to make this patch more maintainable in the long run.