Re: [PATCH] gnu: Add asunder.

2016-12-25 Thread Leo Famulari
On Sun, Dec 25, 2016 at 08:48:35AM +0100, John Darrington wrote: > On Sat, Dec 24, 2016 at 06:03:45PM -0800, Chris Marusich wrote: > > Why is the wrapper not good here? What would be a better solution? > > Here's why I think the wrapper produced by 'wrap-program' is a good >

Re: [PATCH] gnu: Add asunder.

2016-12-24 Thread John Darrington
On Sat, Dec 24, 2016 at 06:03:45PM -0800, Chris Marusich wrote: Why is the wrapper not good here? What would be a better solution? Here's why I think the wrapper produced by 'wrap-program' is a good solution in this case: * The wrapper script allows us to package t

Re: [PATCH] gnu: Add asunder.

2016-12-24 Thread Chris Marusich
John Darrington writes: > On Fri, Dec 23, 2016 at 06:11:44PM -0800, Chris Marusich wrote: > Leo Famulari writes: > > > On Fri, Dec 23, 2016 at 12:16:24AM -0800, Chris Marusich wrote: > >> Hi Leo, > >> > >> I've responded to the feedback from you, Hartmut, and John

Re: [PATCH] gnu: Add asunder.

2016-12-23 Thread John Darrington
On Fri, Dec 23, 2016 at 06:11:44PM -0800, Chris Marusich wrote: Leo Famulari writes: > On Fri, Dec 23, 2016 at 12:16:24AM -0800, Chris Marusich wrote: >> Hi Leo, >> >> I've responded to the feedback from you, Hartmut, and John. How does >> the latest patch loo

Re: [PATCH] gnu: Add asunder.

2016-12-23 Thread Chris Marusich
Leo Famulari writes: > On Fri, Dec 23, 2016 at 12:16:24AM -0800, Chris Marusich wrote: >> Hi Leo, >> >> I've responded to the feedback from you, Hartmut, and John. How does >> the latest patch look? It's available here: >> >> https://lists.gnu.org/archive/html/guix-devel/2016-12/msg00707.html

Re: [PATCH] gnu: Add asunder.

2016-12-23 Thread Leo Famulari
On Fri, Dec 23, 2016 at 12:16:24AM -0800, Chris Marusich wrote: > Hi Leo, > > I've responded to the feedback from you, Hartmut, and John. How does > the latest patch look? It's available here: > > https://lists.gnu.org/archive/html/guix-devel/2016-12/msg00707.html Thanks for the reminder! I pu

Re: [PATCH] gnu: Add asunder.

2016-12-23 Thread Chris Marusich
Hi Leo, I've responded to the feedback from you, Hartmut, and John. How does the latest patch look? It's available here: https://lists.gnu.org/archive/html/guix-devel/2016-12/msg00707.html -- Chris signature.asc Description: PGP signature

Re: [PATCH] gnu: Add asunder.

2016-12-18 Thread Chris Marusich
g neroAacEnc and to Monkey's >> audio >> + ;; using mac, but we do not include those libraries as they are >> non-free. > > This comment isn't necessary, in my opinion. OK. I've removed it. >> +(description >> + "Asunder is a graphical Audio CD ripper a

Re: [PATCH] gnu: Add asunder.

2016-12-17 Thread Leo Famulari
On Sat, Dec 17, 2016 at 01:20:40AM -0800, Chris Marusich wrote: > * gnu/packages/cdrom.scm (asunder): New variable. Thanks! > +(home-page "http://www.littlesvr.ca/asunder/index.php";) I agree with the other reviewers about the home-page. > +(inputs `(("gtk+-2" ,gtk+-2) > +

Re: [PATCH] gnu: Add asunder.

2016-12-17 Thread Hartmut Goebel
Am 17.12.2016 um 10:20 schrieb Chris Marusich: > +(home-page "http://www.littlesvr.ca/asunder/index.php";) I'd leave of the "index.php" here. Its uselass and ugly :-) -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com | | www.crazy-compilers.com

Re: [PATCH] gnu: Add asunder.

2016-12-17 Thread John Darrington
On Sat, Dec 17, 2016 at 01:20:40AM -0800, Chris Marusich wrote: +(define-public asunder + (package +(name "asunder") +(version "2.8") +(home-page "http://www.littlesvr.ca/asunder/index.php";) +(source (origin + (method url-fetch) It

[PATCH] gnu: Add asunder.

2016-12-17 Thread Chris Marusich
* gnu/packages/cdrom.scm (asunder): New variable. --- gnu/packages/cdrom.scm | 44 1 file changed, 44 insertions(+) diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm index 829156a7c..b78382ec6 100644 --- a/gnu/packages/cdrom.scm +++ b/gnu/pa