Re: [PATCH] gnu: Add di.

2016-07-08 Thread John J Foerch
Leo Famulari writes: > On Thu, Jul 07, 2016 at 12:30:11PM -0400, John J Foerch wrote: >> Any remaining blocking issues on this? > > Pushed as 614023981! Many thanks. -- John Foerch

Re: [PATCH] gnu: Add di.

2016-07-08 Thread Alex Kost
Leo Famulari (2016-07-07 20:37 +0300) wrote: > On Thu, Jul 07, 2016 at 12:30:11PM -0400, John J Foerch wrote: >> Any remaining blocking issues on this? > > Not really... I've been struggling to write the comment that justifies > skipping the tests :) Nice comment after all :-) ("Obscure test fa

Re: [PATCH] gnu: Add di.

2016-07-07 Thread Leo Famulari
On Thu, Jul 07, 2016 at 12:30:11PM -0400, John J Foerch wrote: > Any remaining blocking issues on this? Pushed as 614023981!

Re: [PATCH] gnu: Add di.

2016-07-07 Thread Leo Famulari
On Thu, Jul 07, 2016 at 12:30:11PM -0400, John J Foerch wrote: > Any remaining blocking issues on this? Not really... I've been struggling to write the comment that justifies skipping the tests :) Any suggestions?

Re: [PATCH] gnu: Add di.

2016-07-07 Thread John J Foerch
John J Foerch writes: > Leo Famulari writes: > >> On Mon, Jul 04, 2016 at 11:18:50AM -0400, John J Foerch wrote: >>> * gnu/packages/admin.scm (di): New variable. >> >> A few final nitpicks before others make a decision about the test suite >> ;) >> >>> +(arguments >>> + `(#:phases >>> +

Re: [PATCH] gnu: Add di.

2016-07-04 Thread John J Foerch
Leo Famulari writes: > On Mon, Jul 04, 2016 at 09:43:55AM +0300, Alex Kost wrote: >> John J Foerch (2016-07-04 06:47 +0300) wrote: >> > A test relating to an included perl module Filesys::di fails. I hadn't >> > intended to include that module in the package, as all I'm interested in >> > is the

Re: [PATCH] gnu: Add di.

2016-07-04 Thread John J Foerch
Leo Famulari writes: > On Mon, Jul 04, 2016 at 11:18:50AM -0400, John J Foerch wrote: >> * gnu/packages/admin.scm (di): New variable. > > A few final nitpicks before others make a decision about the test suite > ;) > >> +(arguments >> + `(#:phases >> + (modify-phases %standard-phase

Re: [PATCH] gnu: Add di.

2016-07-04 Thread Leo Famulari
On Mon, Jul 04, 2016 at 11:18:50AM -0400, John J Foerch wrote: > * gnu/packages/admin.scm (di): New variable. A few final nitpicks before others make a decision about the test suite ;) > +(arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'configure) >

Re: [PATCH] gnu: Add di.

2016-07-04 Thread Leo Famulari
On Mon, Jul 04, 2016 at 09:43:55AM +0300, Alex Kost wrote: > John J Foerch (2016-07-04 06:47 +0300) wrote: > > A test relating to an included perl module Filesys::di fails. I hadn't > > intended to include that module in the package, as all I'm interested in > > is the 'di' binary. Given that, I

Re: [PATCH] gnu: Add di.

2016-07-04 Thread John J Foerch
> As for me, I would also disable the tests. All these handmade Makefiles > in all sub-directories are a nightmare. I think trying to figure out > what is needed to run the tests doesn't worth it. > > Also don't forget to add a copyright line for yourself in the beginning > of "admin.scm".

Re: [PATCH] gnu: Add di.

2016-07-03 Thread Alex Kost
John J Foerch (2016-07-04 06:47 +0300) wrote: > John J Foerch writes: > >> Leo Famulari writes: >> >>> On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote: * gnu/packages/admin.scm (di): New variable. >>> >>> Thanks! >>> +(arguments + `(#:phases + (mod

Re: [PATCH] gnu: Add di.

2016-07-03 Thread John J Foerch
John J Foerch writes: > Leo Famulari writes: > >> On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote: >>> * gnu/packages/admin.scm (di): New variable. >> >> Thanks! >> >>> +(arguments >>> + `(#:phases >>> + (modify-phases %standard-phases >>> + (delete 'configure

Re: [PATCH] gnu: Add di.

2016-07-03 Thread John J Foerch
Leo Famulari writes: > On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote: >> * gnu/packages/admin.scm (di): New variable. > > Thanks! > >> +(arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (delete 'configure) >> + (delete 'check) > > D

Re: [PATCH] gnu: Add di.

2016-07-03 Thread Leo Famulari
On Sat, Jul 02, 2016 at 03:13:52PM -0400, John J Foerch wrote: > * gnu/packages/admin.scm (di): New variable. Thanks! > +(arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (delete 'check) Did you try setting `#:test-target "tes

[PATCH] gnu: Add di.

2016-07-02 Thread John J Foerch
Hello, Here is a package for the program 'di' (df alternative). Let me know if anything is amiss, cheers! John Foerch >From 4ef5a6edba2e10a59865a6aba134d2f0532c7503 Mon Sep 17 00:00:00 2001 From: "John J. Foerch" Date: Sat, 2 Jul 2016 15:08:30 -0400 Subject: [PAT