Nikita Karetnikov nik...@karetnikov.org skribis:
Frankly, I don’t like it. I think the default behavior should not be to
let the user shoot themself in the foot.
WDYT?
OK, what about these patches? Can I push them?
From 86d29a8b233d5cf6549fbcddf43b185086b7d178 Mon Sep 17 00:00:00 2001
Nikita Karetnikov nik...@karetnikov.org skribis:
Oh. I’d prefer if it would delete all generations but the current one.
That’s a fairly useful pattern: suppose you want to make space on your
disk (and you know you won’t need to roll back), it’d be handy to run:
guix package
Frankly, I don’t like it. I think the default behavior should not be to
let the user shoot themself in the foot.
WDYT?
OK, what about these patches? Can I push them?
From 86d29a8b233d5cf6549fbcddf43b185086b7d178 Mon Sep 17 00:00:00 2001
From: Nikita Karetnikov nik...@karetnikov.org
Date:
Nothing has to be changed; it’s just that I’d prefer to put the bits
that introduce ‘link-to-empty-environment’ in a separate patch, for
clarity.
I could do it, but it may be easier for you to do it, no?
Ah, I simply misunderstood. I’ll do it.
pgpBmYpaLw3VH.pgp
Description: PGP signature
“Delete the generations matching @var{patterns} or ... when omitted.”
Or what actually? I would expect it to delete all the generations but
the current one when PATTERN is omitted, right?
‘--delete-generations’ deletes everything and points the profile to the
zeroth generation. There are
00:00:00 2001
From: Nikita Karetnikov nik...@karetnikov.org
Date: Sun, 22 Sep 2013 18:50:06 +
Subject: [PATCH] guix package: Add '--delete-generations'.
* guix/scripts/package.scm (link-to-empty-environment)
(switch-to-previous-generation): New functions.
(roll-back): Replace internal
I think we should change ‘--list-generations’ to not output the zeroth
generation. Even though it could be present in the profile, users
shouldn’t be concerned about it.
Currently, ‘--delete-generations’ ignores the zeroth generation. Other
options seem even more confusing:
1. If you don’t
Nikita Karetnikov nik...@karetnikov.org skribis:
Can I push this patch to ‘master’? Do you see any problems?
Looks good! Minor issues discussed below.
I had noticed that ‘--roll-back’ doesn’t output anything with
‘--dry-run’, so I implemented ‘--delete-generations’ similarly. Maybe
it