On 06/24/2015 09:49 PM, Ludovic Courtès wrote:
> Cyril Roelandt skribis:
>
>> WDYT?
>
> Makes sense to me.
>
> The latest version of the patch (posted on Monday 15th) LGTM;
> please push.
>
Pushed in ff986890ece06b0623a7c8b3048dea1206f076ea .
Cyril.
Cyril Roelandt skribis:
> WDYT?
Makes sense to me.
The latest version of the patch (posted on Monday 15th) LGTM;
please push.
Thank you!
Ludo’.
On 06/18/2015 12:45 PM, Amirouche Boubekki wrote:
> Héllo,
>
Hey,
>
> If I'm not mistaken this patch relies only on the presence of
> requirements.txt. This is not a required file in python packaging.
> otherwise said, we miss a lot using this method. I think the best way to
> do that would
On 2015-06-21 22:56, l...@gnu.org wrote:
Amirouche Boubekki skribis:
If I'm not mistaken this patch relies only on the presence of
requirements.txt. This is not a required file in python
packaging. otherwise said, we miss a lot using this method. I think
the best way to do that would be to:
-
Amirouche Boubekki skribis:
> If I'm not mistaken this patch relies only on the presence of
> requirements.txt. This is not a required file in python
> packaging. otherwise said, we miss a lot using this method. I think
> the best way to do that would be to:
>
> - download the package and extract
On 2015-06-19 17:32, Christopher Allan Webber wrote:
Amirouche Boubekki writes:
Héllo,
If I'm not mistaken this patch relies only on the presence of
requirements.txt. This is not a required file in python packaging.
otherwise said, we miss a lot using this method. I think the best way
to
do
Amirouche Boubekki writes:
> Héllo,
>
>
> If I'm not mistaken this patch relies only on the presence of
> requirements.txt. This is not a required file in python packaging.
> otherwise said, we miss a lot using this method. I think the best way to
> do that would be to:
>
> - download the packa
* guix/import/pypi.scm (python->package-name, maybe-inputs, compute-inputs,
guess-requirements): New procedures.
* guix/import/pypi.scm (guix-hash-url): Now takes a filename instead of an
URL as input.
* guix/import/pypi.scm (make-pypi-sexp): Now tries to generate the inputs
automagically.
*
Cyril Roelandt skribis:
> * guix/import/pypi.scm (compute-inputs, guess-requirements): New procedures.
Nice!
Please mention the ‘guix-hash-url’, ‘make-pypi-sexp’,
‘python->package-name’, etc. changes and the tests.
> +(define (maybe-inputs python->package-name inputs)
> + (match inputs
> +
* guix/import/pypi.scm (compute-inputs, guess-requirements): New procedures.
---
guix/import/pypi.scm | 149 ---
tests/pypi.scm | 41 +-
2 files changed, 146 insertions(+), 44 deletions(-)
diff --git a/guix/import/pypi.scm b/guix/
David Thompson skribis:
>> +(map (lambda (input)
>> + (list input (list 'unquote (string->symbol input
>
> Could be rephrased as:
>
> `(,input (,'unqoute ,(string->symbol input)))
>
> Not sure if it's a good idea, though. Ludo? ;)
Not sure either. :-) The original may be
Cyril Roelandt writes:
> * guix/import/pypi.scm (compute-inputs, guess-requirements): New procedures.
> ---
> guix/import/pypi.scm | 149
> ---
> 1 file changed, 118 insertions(+), 31 deletions(-)
>
> diff --git a/guix/import/pypi.scm b/guix/impor
Cyril Roelandt skribis:
> * guix/import/pypi.scm (compute-inputs, guess-requirements): New procedures.
Just some superficial comments. David, anything else?
> +(define (guix-hash-url filename)
> + "Return the hash of FILENAME in nix-base32 format."
> + (bytevector->nix-base32-string
> + (c
* guix/import/pypi.scm (compute-inputs, guess-requirements): New procedures.
---
guix/import/pypi.scm | 149 ---
1 file changed, 118 insertions(+), 31 deletions(-)
diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index 8567cad..1091deb 10064
14 matches
Mail list logo
