Re: [PATCH] mps-youtube, revision 3

2016-11-05 Thread ng0
Marius Bakke writes: > Hartmut Goebel writes: > >> Am 04.11.2016 um 20:23 schrieb ng0: >>> [PATCH 1/2] gnu: Add python-pafy. >>> >>> - made youtube-dl propagated-input as suggested by harmut >>> >>> [PATCH 2/2] gnu: Add mps-youtube. >>> >>> - no changes >>> >> >> Both LGTM. >> >> Adding the comm

Re: [PATCH] mps-youtube, revision 3

2016-11-05 Thread Marius Bakke
Hartmut Goebel writes: > Am 04.11.2016 um 20:23 schrieb ng0: >> [PATCH 1/2] gnu: Add python-pafy. >> >> - made youtube-dl propagated-input as suggested by harmut >> >> [PATCH 2/2] gnu: Add mps-youtube. >> >> - no changes >> > > Both LGTM. > > Adding the comment about youtube_dl was a good idea :-

Re: [PATCH] mps-youtube, revision 3

2016-11-04 Thread Hartmut Goebel
Am 04.11.2016 um 20:23 schrieb ng0: > [PATCH 1/2] gnu: Add python-pafy. > > - made youtube-dl propagated-input as suggested by harmut > > [PATCH 2/2] gnu: Add mps-youtube. > > - no changes > Both LGTM. Adding the comment about youtube_dl was a good idea :-) -- Regards Hartmut Goebel | Hartmut

[PATCH] mps-youtube, revision 3

2016-11-04 Thread ng0
[PATCH 1/2] gnu: Add python-pafy. - made youtube-dl propagated-input as suggested by harmut [PATCH 2/2] gnu: Add mps-youtube. - no changes

[PATCH] mps-youtube, revision 2.

2016-11-02 Thread ng0
[PATCH 1/2] gnu: Add python-pafy. no changes. [PATCH 2/2] gnu: Add mps-youtube. changes: removed inputs, expanded description

Re: [PATCH] mps-youtube

2016-11-02 Thread Marius Bakke
ng0 writes: >>> So far they are in (inputs). Are those supposed to be installed by the >>> users themselves? >> >> For optional dependencies (i.e. if mps-youtube gracefully handles >> missing ffmpeg), leaving it up to the user is good (but then it should >> not be an input). For "hard" runtime d

Re: [PATCH] mps-youtube

2016-11-02 Thread ng0
Marius Bakke writes: > ng0 writes: > >> I am not sure about how the non-python runtime dependencies are supposed to >> be handled in python packages. >> >> python-pafy needs youtube-dl to function. >> mps-youtube needs at least mpv and optionally ffmpeg to deal with conversion >> of formats. >

Re: [PATCH] mps-youtube

2016-11-02 Thread Marius Bakke
ng0 writes: > I am not sure about how the non-python runtime dependencies are supposed to > be handled in python packages. > > python-pafy needs youtube-dl to function. > mps-youtube needs at least mpv and optionally ffmpeg to deal with conversion > of formats. Have you checked whether the inp

[PATCH] mps-youtube

2016-11-02 Thread ng0
I am not sure about how the non-python runtime dependencies are supposed to be handled in python packages. python-pafy needs youtube-dl to function. mps-youtube needs at least mpv and optionally ffmpeg to deal with conversion of formats. So far they are in (inputs). Are those supposed to be ins