Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-03-12 Thread Clément Lassieur
Ludovic Courtès writes: > Clément Lassieur skribis: > >> There are two other patches concerning services: >> http://lists.gnu.org/archive/html/guix-devel/2017-02/msg01154.html >> >> Please, could someone do a review on these? :) > > I my inbox I have a reply

Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-03-12 Thread Ludovic Courtès
Clément Lassieur skribis: > There are two other patches concerning services: > http://lists.gnu.org/archive/html/guix-devel/2017-02/msg01154.html > > Please, could someone do a review on these? :) I my inbox I have a reply from Andy saying: > Great patches; will apply

Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-03-11 Thread Clément Lassieur
Hi Ludovic, > Clément Lassieur skribis: > > Given that Andy okayed the patch, I think you should go ahead and push it! Done, applied to master as eba560765a5afccbc5d3b64df410d89b1f79a18e. There are two other patches concerning services:

Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-03-11 Thread Ludovic Courtès
Hi Clément, Clément Lassieur skribis: >>> Well, maybe here "lmtp" is not the section name, but the path, relative >>> to "base_dir". Sould I update the documentation to specify that "path" >>> may be relative to "base_dir" too? >> >> Sure, anyway patch LGTM. Thanks for

Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-02-27 Thread Clément Lassieur
>> Well, maybe here "lmtp" is not the section name, but the path, relative >> to "base_dir". Sould I update the documentation to specify that "path" >> may be relative to "base_dir" too? > > Sure, anyway patch LGTM. Thanks for taking the time to explain. My pleasure! Here is the new version,

Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-02-27 Thread Andy Wingo
On Mon 27 Feb 2017 10:39, Clément Lassieur writes: > Clément Lassieur writes: > >> Andy Wingo writes: >> >>> On Sun 26 Feb 2017 20:42, Clément Lassieur writes: >>> * gnu/services/mail.scm

Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-02-27 Thread Clément Lassieur
Clément Lassieur writes: > Andy Wingo writes: > >> On Sun 26 Feb 2017 20:42, Clément Lassieur writes: >> >>> * gnu/services/mail.scm (unix-listener-configuration)[path] >>> (fifo-listener-configuration)[path]: Change type from

Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-02-27 Thread Clément Lassieur
Andy Wingo writes: > On Sun 26 Feb 2017 20:42, Clément Lassieur writes: > >> * gnu/services/mail.scm (unix-listener-configuration)[path] >> (fifo-listener-configuration)[path]: Change type from 'file-name' to >> 'string'. >> * doc/guix.texi (Mail

Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-02-27 Thread Andy Wingo
On Sun 26 Feb 2017 20:42, Clément Lassieur writes: > * gnu/services/mail.scm (unix-listener-configuration)[path] > (fifo-listener-configuration)[path]: Change type from 'file-name' to > 'string'. > * doc/guix.texi (Mail Services): Document it. Why's that? Is the extra

[PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.

2017-02-26 Thread Clément Lassieur
* gnu/services/mail.scm (unix-listener-configuration)[path] (fifo-listener-configuration)[path]: Change type from 'file-name' to 'string'. * doc/guix.texi (Mail Services): Document it. --- doc/guix.texi | 8 gnu/services/mail.scm | 8 2 files changed, 8 insertions(+),