Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-03-02 Thread Mark H Weaver
Danny Milosavljevic writes: > On Fri, 24 Feb 2017 17:13:53 -0500 > Mark H Weaver wrote: > >> If the purpose here is to facilitate mutating anything in the store, > > That's not what it does. It's used in the profile hook. 'union-build > is basically just reused to avoid code duplication. See PAT

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-27 Thread Huang, Ying
iyzs...@member.fsf.org (宋文武) writes: > "Huang, Ying" writes: > > Hi, sorry for my late reply. > >> Danny Milosavljevic writes: >> >>> Hi, >>> >>> yeah, I've looked at it and I see what you are trying to do. >>> >>> You modified 'union to replicate the directory tree and symlink >>> only the non-

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-27 Thread Danny Milosavljevic
Hi Mark, On Fri, 24 Feb 2017 17:13:53 -0500 Mark H Weaver wrote: > If the purpose here is to facilitate mutating anything in the store, That's not what it does. It's used in the profile hook. 'union-build is basically just reused to avoid code duplication. See PATCH 2/2. > then we cannot acce

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-26 Thread 宋文武
"Huang, Ying" writes: Hi, sorry for my late reply. > Danny Milosavljevic writes: > >> Hi, >> >> yeah, I've looked at it and I see what you are trying to do. >> >> You modified 'union to replicate the directory tree and symlink only the >> non-directory files - in order to be able to add "font

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-25 Thread Huang, Ying
Mark H Weaver writes: > Danny Milosavljevic writes: > >> yeah, I've looked at it and I see what you are trying to do. >> >> You modified 'union to replicate the directory tree and symlink only >> the non-directory files - in order to be able to add "fonts.dir" in >> those directories. > > If the

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-25 Thread Huang, Ying
Danny Milosavljevic writes: > Hi, > > yeah, I've looked at it and I see what you are trying to do. > > You modified 'union to replicate the directory tree and symlink only the > non-directory files - in order to be able to add "fonts.dir" in those > directories. > > The previous version symlink

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-24 Thread Huang, Ying
Danny Milosavljevic writes: > Hi, > > yeah, I've looked at it and I see what you are trying to do. > > You modified 'union to replicate the directory tree and symlink only the > non-directory files - in order to be able to add "fonts.dir" in those > directories. > > The previous version symlink

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-24 Thread Huang, Ying
Hi, Andy, Andy Wingo writes: > Hi :) > > On Fri 24 Feb 2017 13:40, "Huang, Ying" writes: > >>>(define (union output inputs) >>> (match inputs >>>((input) >>> - ;; There's only one input, so just make a link. >>> - (symlink* input output)) >>> + ;; There's only

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-24 Thread Mark H Weaver
Danny Milosavljevic writes: > yeah, I've looked at it and I see what you are trying to do. > > You modified 'union to replicate the directory tree and symlink only > the non-directory files - in order to be able to add "fonts.dir" in > those directories. If the purpose here is to facilitate muta

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-24 Thread Danny Milosavljevic
Hi, yeah, I've looked at it and I see what you are trying to do. You modified 'union to replicate the directory tree and symlink only the non-directory files - in order to be able to add "fonts.dir" in those directories. The previous version symlinked entire directories, too, and you wouldn't

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-24 Thread Andy Wingo
Hi :) On Fri 24 Feb 2017 13:40, "Huang, Ying" writes: >>(define (union output inputs) >> (match inputs >>((input) >> - ;; There's only one input, so just make a link. >> - (symlink* input output)) >> + ;; There's only one input, so just make a link unless >> c

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-24 Thread Huang, Ying
Hi, All, Can anyone help me to review this patch? Best Regards, Huang, Ying huang_ying_cari...@163.com writes: > From: Huang Ying > > * guix/build/union.scm (union-build): Add create-all-directory? keyword > parameter. To add/remove some files from the directory. > --- > guix/build/union.s

[PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

2017-02-17 Thread huang_ying_caritas
From: Huang Ying * guix/build/union.scm (union-build): Add create-all-directory? keyword parameter. To add/remove some files from the directory. --- guix/build/union.scm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/guix/build/union.scm b/guix/build/union.scm in