Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Leo Famulari
On Mon, Nov 28, 2016 at 12:20:53AM +0100, Tobias Geerinckx-Rice wrote: > On 28/11/16 00:15, Tobias Geerinckx-Rice wrote: > > this (libjpeg-turbo) was *already* bundled and used by icecat, [...] > > Some fortuitous grepping revealed that our spice packages also #warns > about *not* being built

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Leo Famulari
On Mon, Nov 28, 2016 at 12:15:01AM +0100, Tobias Geerinckx-Rice wrote: > There seems to be some misunderstanding here. Sorry if it wasn't clear: > this (libjpeg-turbo) was *already* bundled and used by icecat, as the > ‘media/libjpeg’ (sic) that this patch removes. You'll find the same SIMD > code

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Tobias Geerinckx-Rice
On 28/11/16 00:15, Tobias Geerinckx-Rice wrote: > this (libjpeg-turbo) was *already* bundled and used by icecat, [...] Some fortuitous grepping revealed that our spice packages also #warns about *not* being built with libjpeg-turbo. Absent any known drawbacks, I'd follow upstreams'

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Tobias Geerinckx-Rice
Andreas, Leo, Thanks for the feedback! On 27/11/16 22:41, Leo Famulari wrote: > I'm not sure, but the comment seems to indicate that we don't want to > use it: > > ;; According to > ;; http://sourceforge.net/projects/libjpeg-turbo/ , > ;; "libjpeg-turbo is a derivative of libjpeg that > ;; uses

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Leo Famulari
On Sun, Nov 27, 2016 at 11:28:45PM +0100, Marius Bakke wrote: > Marius Bakke writes: > > > Leo Famulari writes: > > > >> On Sun, Nov 27, 2016 at 10:02:35PM +0100, Tobias Geerinckx-Rice wrote: > >>> Leo, > >>> > >>> On 27/11/16 21:56, Leo Famulari wrote:

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Leo Famulari
On Sun, Nov 27, 2016 at 10:50:35PM +0100, Marius Bakke wrote: > Leo Famulari writes: > > I'm not sure, but the comment seems to indicate that we don't want to > > use it: > > > > ;; According to > > ;; http://sourceforge.net/projects/libjpeg-turbo/ , > > ;; "libjpeg-turbo is a

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Marius Bakke
Marius Bakke writes: > Leo Famulari writes: > >> On Sun, Nov 27, 2016 at 10:02:35PM +0100, Tobias Geerinckx-Rice wrote: >>> Leo, >>> >>> On 27/11/16 21:56, Leo Famulari wrote: >>> > Will this work on nachines that don't support SSE? My understanding is

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Marius Bakke
Leo Famulari writes: > On Sun, Nov 27, 2016 at 10:02:35PM +0100, Tobias Geerinckx-Rice wrote: >> Leo, >> >> On 27/11/16 21:56, Leo Famulari wrote: >> > Will this work on nachines that don't support SSE? My understanding is >> > that we don't wish to require it. >> >> Why

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Leo Famulari
On Sun, Nov 27, 2016 at 10:02:35PM +0100, Tobias Geerinckx-Rice wrote: > Leo, > > On 27/11/16 21:56, Leo Famulari wrote: > > Will this work on nachines that don't support SSE? My understanding is > > that we don't wish to require it. > > Why wouldn't it? > > I don't often use Icecat, but when I

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Tobias Geerinckx-Rice
Leo, On 27/11/16 21:56, Leo Famulari wrote: > Will this work on nachines that don't support SSE? My understanding is > that we don't wish to require it. Why wouldn't it? I don't often use Icecat, but when I do... I don't see why it would require SSE by default. ;-) And it's not like we ever

Re: [PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Leo Famulari
On Sun, Nov 27, 2016 at 09:17:07PM +0100, Tobias Geerinckx-Rice wrote: > * gnu/packages/gnuzilla.scm (icecat)[source]: Remove bundled libjpeg. > [inputs]: Add libjpeg-turbo. > [arguments]: Use it. > - ;; Fails with "libjpeg-turbo JCS_EXTENSIONS > -

[PATCH 2/2] gnu: icecat: Use libjpeg-turbo instead of bundled libjpeg.

2016-11-27 Thread Tobias Geerinckx-Rice
* gnu/packages/gnuzilla.scm (icecat)[source]: Remove bundled libjpeg. [inputs]: Add libjpeg-turbo. [arguments]: Use it. --- gnu/packages/gnuzilla.scm | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index