Re: [RFC] Improve Python package quality

2021-01-07 Thread Lars-Dominik Braun
Hi, for reference, the patchset is now tracked by issue 45712 (http://issues.guix.gnu.org/45712) Cheers, Lars

Re: [RFC] Improve Python package quality

2021-01-06 Thread Hartmut Goebel
Am 05.01.21 um 11:48 schrieb Vincent Legoll: > That is better, but the separate file would allow to have proper > syntax highlighting, allow linting/pep8'ing, etc. Probably not worth the effort for trying to put this into a separate file. -- Regards Hartmut Goebel | Hartmut Goebel | h.

Re: [RFC] Improve Python package quality

2021-01-05 Thread Vincent Legoll
On Tue, Jan 5, 2021 at 11:28 AM Lars-Dominik Braun wrote: > > Like in a separate pure-python file. > I don’t know how unfortunately. Any ideas? No sorry, I'm still a newbie > I moved it into a separate top-level variable now and turned it into a > single multi-line Scheme string. That makes it e

Re: [RFC] Improve Python package quality

2021-01-05 Thread Lars-Dominik Braun
Hi Vincent, > I like the idea of better testing for our python packages, but would it be > possible to avoid embedding the python code as scheme strings ? > Like in a separate pure-python file. I don’t know how unfortunately. Any ideas? I moved it into a separate top-level variable now and turned

Re: [RFC] Improve Python package quality

2021-01-05 Thread Vincent Legoll
Hello, I like the idea of better testing for our python packages, but would it be possible to avoid embedding the python code as scheme strings ? Like in a separate pure-python file. WDYT ? -- Vincent Legoll

Re: [RFC] Improve Python package quality

2021-01-05 Thread Lars-Dominik Braun
Hi Hartmut, > this is a good idea. (Since you where mentioning setuptools, I first was > afraid your solution would be tightened to setuptools, but it is not. > Well done!) afaik pkg_resources is technically a part of setuptools, although it is distributed with Python. > This comment should go

Re: [RFC] Improve Python package quality

2021-01-03 Thread Tobias Geerinckx-Rice
Lars(-Dominik?), I'll defer to others on the finer points of (Scheme-string-embedded-)Python, but just wanted to say: Lars-Dominik Braun 写道: My proposal adds some build-time checks to guarentee three properties: This is utterly awesome. Thank you so much. Kind regards, T G-R signature.

Re: [RFC] Improve Python package quality

2021-01-03 Thread Hartmut Goebel
Hi Lars, this is a good idea. (Since you where mentioning setuptools, I first was afraid your solution would be tightened to setuptools, but it is not. Well done!) Some comments (most of which are nit-picking): +;; Python 2 support. +"from __future__ import print_function" This comment sh

[RFC] Improve Python package quality

2021-01-03 Thread Lars-Dominik Braun
Hi, I’d like to propose adding an additional phase to python-build-system to improve Guix’ Python package quality. Python is an interpreted language without any compile-time checks. Any errors are only visible at run-time, including missing or wrong imports. Additionally most Python packages use