Re: 01/03: guix: store: Add ensure-path.

2020-11-27 Thread Ludovic Courtès
Hi, Mathieu Othacehe skribis: >> Yeah, ‘guix offload’ should not connect to the daemon. It does so >> currently for one thing (registering GC roots IIRC), which should be >> done in Scheme instead. > > Why shouldn't it connect to the daemon? In the current implementation of > the nix daemon, th

Re: 01/03: guix: store: Add ensure-path.

2020-11-23 Thread Mathieu Othacehe
Hey, > So perhaps we should adjust the docstring to reflect that? Sure, done with: d9e57db72479812cfa30ed8e30a6351959f9a2b2. > Yeah, ‘guix offload’ should not connect to the daemon. It does so > currently for one thing (registering GC roots IIRC), which should be > done in Scheme instead. Wh

Re: 01/03: guix: store: Add ensure-path.

2020-11-23 Thread Ludovic Courtès
Hi, Mathieu Othacehe skribis: >> Looking at LocalStore::ensurePath, I don’t think a GC root is made. >> You have to call ‘add-temp-root’ if you want that to happen, no? > > Yes, I think we do indeed. So perhaps we should adjust the docstring to reflect that? >> However ‘ensure-path’ can substi

Re: 01/03: guix: store: Add ensure-path.

2020-11-23 Thread Mathieu Othacehe
Hey, > Looking at LocalStore::ensurePath, I don’t think a GC root is made. > You have to call ‘add-temp-root’ if you want that to happen, no? Yes, I think we do indeed. > However ‘ensure-path’ can substitute the store item, which I suppose > means you can substitute .drv files without building

Re: 01/03: guix: store: Add ensure-path.

2020-11-23 Thread Christopher Baines
Ludovic Courtès writes: > Hi! > > guix-comm...@gnu.org skribis: > >> commit 2a7e1121d83ee173a7a0dbfb978a4ac363c7c4a6 >> Author: Mathieu Othacehe >> AuthorDate: Wed Nov 4 14:39:40 2020 +0100 >> >> guix: store: Add ensure-path. >> >> * guix/store.scm (ensure-path): New procedure. > >

Re: 01/03: guix: store: Add ensure-path.

2020-11-22 Thread Ludovic Courtès
Hi! guix-comm...@gnu.org skribis: > commit 2a7e1121d83ee173a7a0dbfb978a4ac363c7c4a6 > Author: Mathieu Othacehe > AuthorDate: Wed Nov 4 14:39:40 2020 +0100 > > guix: store: Add ensure-path. > > * guix/store.scm (ensure-path): New procedure. [...] > +(define-operation (ensure-path (