Re: 04/04: offload: Avoid using '_' as a 'match' pattern.

2017-05-03 Thread Ludovic Courtès
Mark H Weaver skribis: > l...@gnu.org (Ludovic Courtès) writes: >> In hindsight, it would have been wiser to just rename ‘_’ in (guix ui) >> to something else, like ‘G_’. Well, it’s not too late. Should we do >> that? Thoughts? > > I agree that renaming '_' in (guix ui) is the better approach.

Re: 04/04: offload: Avoid using '_' as a 'match' pattern.

2017-04-22 Thread Tobias Geerinckx-Rice
Ludo', On 21/04/17 19:24, Ludovic Courtès wrote: > Only in modules that import (guix ui). > > This is due to the fact that macros in Guile 2.2 match “literals” > differently: normal bindings (like ‘_’ from (guix ui)) can shadow > literals. The ‘NEWS’ file of Guile 2.2 puts it this way: [...] Th

Re: 04/04: offload: Avoid using '_' as a 'match' pattern.

2017-04-22 Thread Alex Kost
Mark H Weaver (2017-04-21 14:05 -0400) wrote: > l...@gnu.org (Ludovic Courtès) writes: >> In hindsight, it would have been wiser to just rename ‘_’ in (guix ui) >> to something else, like ‘G_’. Well, it’s not too late. Should we do >> that? Thoughts? > > I agree that renaming '_' in (guix ui) i

Re: 04/04: offload: Avoid using '_' as a 'match' pattern.

2017-04-21 Thread Mark H Weaver
l...@gnu.org (Ludovic Courtès) writes: > In hindsight, it would have been wiser to just rename ‘_’ in (guix ui) > to something else, like ‘G_’. Well, it’s not too late. Should we do > that? Thoughts? I agree that renaming '_' in (guix ui) is the better approach. Mark

Re: 04/04: offload: Avoid using '_' as a 'match' pattern.

2017-04-21 Thread Ludovic Courtès
Hi, Tobias Geerinckx-Rice skribis: > On 21/04/17 17:24, Ludovic Court�s wrote: >> commit ba97e454bfbc168098212b37881b50b4fe6e1eb2 Author: Ludovic >> Courtès Date: Fri Apr 21 17:18:54 2017 >> +0200 >> >> offload: Avoid using '_' as a 'match' pattern. >> >> * guix/scripts/offload.scm (host-ke

Re: 04/04: offload: Avoid using '_' as a 'match' pattern.

2017-04-21 Thread Tobias Geerinckx-Rice
Ludo', On 21/04/17 17:24, Ludovic Court�s wrote: > commit ba97e454bfbc168098212b37881b50b4fe6e1eb2 Author: Ludovic > Courtès Date: Fri Apr 21 17:18:54 2017 > +0200 > > offload: Avoid using '_' as a 'match' pattern. > > * guix/scripts/offload.scm (host-key->type+key, machine-load) > (process-