> I understand the concerns of David Craven regarding
> ‘cargo-build-system’, though OTOH I’m tempted to think
> ‘cargo-build-system’ is probably not so bad if it managed to build all
> this. ;-) But anyway, I’ll David and you figure out what the best
> approach is!
I haven't inspected all the
Ludovic Courtès writes:
> Hi!
>
> Thanks for all the work!
>
> I second Ricardo’s comment about systematically running ‘guix lint’
> before submitting, especially for a patch series that is this large.
>
> If you think the review might take several round trips, it might be more
>
Hi!
Thanks for all the work!
I second Ricardo’s comment about systematically running ‘guix lint’
before submitting, especially for a patch series that is this large.
If you think the review might take several round trips, it might be more
convenient to publish it as a branch somewhere, to avoid
Danny Milosavljevic writes:
> Hi ng0,
>
>> > For those I checked (like rust-openssl-sys) left me in confusion. Does our
>> > cargo build-system just build nothing?
>
> Most Rust libraries are installed as source code (similar to C++ templates
> which are also installed
> Both can happen at the same time and help each other. I/we need
> these patches, and I think keeping this branch around on our (my)
> side will help finding bugs in the cargo build-system. I just
> hope it won't be another year until it all works well enough.
Well if you'd like to help there, I
David Craven writes:
>> One more addition: I will only send a rebased patch series after
>> all patches have been reviewed.
>
>> I think running “guix lint” is essential before submitting patches to
>> the mailing list, because it avoids wasted effort for a lot of common
>>
Hi ng0,
> > For those I checked (like rust-openssl-sys) left me in confusion. Does our
> > cargo build-system just build nothing?
Most Rust libraries are installed as source code (similar to C++ templates
which are also installed as source code).
The current Guix master cargo build system
> One more addition: I will only send a rebased patch series after
> all patches have been reviewed.
> I think running “guix lint” is essential before submitting patches to
> the mailing list, because it avoids wasted effort for a lot of common
> mistakes.
It is my opinion that it is to early to
ng0 writes:
> ... and I still am not sure wether the build system works or not (see bottom
> of this email) because I still have to learn more about this language. Our
> prototype will soon switch to fluid (it's currently using qml-material but I
> refrained from adding that
ng0 writes:
> I have not run any of the 81 packages through guix lint, I would if I
> would know a way to mass lint a list of packages.
“guix lint” accepts more than one argument so you can lint all of the
packages with one command. I do the same for R packages.
Using Emacs
... and I still am not sure wether the build system works or not (see bottom of
this email) because I still have to learn more about this language. Our
prototype will soon switch to fluid (it's currently using qml-material but I
refrained from adding that as its upstream looks like it moved on
11 matches
Mail list logo