Re: A script to check an edit does not break anything

2020-06-16 Thread Ludovic Courtès
Hi Edouard, Edouard Klein skribis: > Ludovic Courtès writes: [...] >> However, this is definitely something ‘guix lint’ could check with >> something along the lines of the patch below. > > Thank you for pushing profile-collisions, it certainly is helpful for > finding such problems, and it pe

Re: A script to check an edit does not break anything

2020-06-13 Thread Ludovic Courtès
Hi Edouard, Edouard Klein skribis: > Because of the subtle consequences of editing a package are hard to keep > track of, I wrote the attached script (you need sharness to run it, but > with slight modification it can become a standalone script). > > This script goes beyond the instructions of t

Re: A script to check an edit does not break anything

2020-06-11 Thread Vincent Legoll
Hello Edouard, I think you left a hardcoded package name in your script, line 29, fix with: s/python-websockets/$package/ Also you sometimes use $package vs ${package} This kind of thing (maybe converted into scheme what about `guix before-submit') should be a valuable addition to guix, it wou

Re: A script to check an edit does not break anything

2020-06-11 Thread Edouard Klein
An now with the attachment. #!/bin/bash # Put this script in a subfolder (e.g. gpwc) # of the guix source # And install sharness in it # https://github.com/chriscool/sharness # Install prove as well # https://linux.die.net/man/1/prove # To run the tests, invoke # prove gpwc.t # Fill in the names

A script to check an edit does not break anything

2020-06-11 Thread Edouard Klein
Dear Guixers, I recently broke jupyter while updating python-prompt-toolkit (a mistake I'm still trying to fix...) despite doing my best to follow the instructions of the manual: https://guix.gnu.org/manual/en/html_node/Packaging-Guidelines.html https://guix.gnu.org/manual/en/html_node/Submitting-